From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Yoni Rabkin Newsgroups: gmane.emacs.devel Subject: Re: Colour selection in shr Date: Mon, 03 Nov 2014 14:55:13 -0500 Message-ID: <87d294ys7y.fsf@rabkins.net> References: <8761ex10e0.fsf@rabkins.net> <87wq7cza1n.fsf@rabkins.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1415044539 30913 80.91.229.3 (3 Nov 2014 19:55:39 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 3 Nov 2014 19:55:39 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 03 20:55:33 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XlNiu-0002tT-RG for ged-emacs-devel@m.gmane.org; Mon, 03 Nov 2014 20:55:32 +0100 Original-Received: from localhost ([::1]:37063 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlNiu-0003jK-9H for ged-emacs-devel@m.gmane.org; Mon, 03 Nov 2014 14:55:32 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43312) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlNij-0003hS-5X for emacs-devel@gnu.org; Mon, 03 Nov 2014 14:55:26 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XlNid-0007q4-GG for emacs-devel@gnu.org; Mon, 03 Nov 2014 14:55:21 -0500 Original-Received: from smtprelay0166.hostedemail.com ([216.40.44.166]:57774 helo=smtprelay.hostedemail.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlNid-0007py-CD for emacs-devel@gnu.org; Mon, 03 Nov 2014 14:55:15 -0500 Original-Received: from filter.hostedemail.com (unknown [216.40.38.60]) by smtprelay02.hostedemail.com (Postfix) with ESMTP id DD52712BA16 for ; Mon, 3 Nov 2014 19:55:14 +0000 (UTC) X-Session-Marker: 796F6E69407261626B696E732E6E6574 X-HE-Tag: bear87_4ad76ce358a05 X-Filterd-Recvd-Size: 2385 Original-Received: from yrk-ThinkPad-T410.rabkins.net (c-75-69-93-148.hsd1.nh.comcast.net [75.69.93.148]) (Authenticated sender: yoni@rabkins.net) by omf03.hostedemail.com (Postfix) with ESMTPA for ; Mon, 3 Nov 2014 19:55:14 +0000 (UTC) X-Ethics: Use GNU In-Reply-To: (Lars Magne Ingebrigtsen's message of "Mon, 03 Nov 2014 18:26:22 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 216.40.44.166 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:176307 Archived-At: Lars Magne Ingebrigtsen writes: > Yoni Rabkin writes: > >> For instance, see: >> http://www.classicalnotes.net/classics3/appassionata.html > > Ok; looks reasonable to me. The luminance could perhaps be pushed up a > bit... > > But as you say: > >> "Difficult" in this case is subjective and dependent on the way my eyes >> work, or in my case >> (http://en.wikipedia.org/wiki/Astigmatism_%28eye%29#Based_on_axis_of_the_principal_meridians), >> the particular way my eyes don't work. I'm sure that a healthy person >> can see the text, but for me the bright white background makes the text >> effectively invisible (the background white "bleeds" into the letters). > > Emacs should definitely provide a way to switch colourisation off > completely for the users that want/need that. And, come to think of it, > it should probably switch off that on TTYs, too, if the user hasn't > specified whether the background is `light' or `dark'. > > A patch to shr.el to provide a defcustom to switch off everything > colourful would be appreciated. A patch to shr.el won't work. When called through Eww, title tags are colorized by shr.el but body tags are colored by eww.el. So turning off colorization in shr.el would still leave `eww-colorize-region' in eww working. So I'm hesitating a moment just in case you are thinking of moving all of the Eww's coloration into either eww.el or shr.el. -- "Cut your own wood and it will warm you twice"