From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 11cf3e9: Implement a new function directory-files-recursively Date: Sat, 13 Dec 2014 08:35:39 +0100 Organization: Emacs Helm Message-ID: <87d27o80j8.fsf@gmail.com> References: <20141209062121.9440.90058@vcs.savannah.gnu.org> <87ppbrpfx4.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1418456193 24543 80.91.229.3 (13 Dec 2014 07:36:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 13 Dec 2014 07:36:33 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 13 08:36:24 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XzhFX-0002mi-7k for ged-emacs-devel@m.gmane.org; Sat, 13 Dec 2014 08:36:23 +0100 Original-Received: from localhost ([::1]:60522 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XzhFW-0003NT-Qt for ged-emacs-devel@m.gmane.org; Sat, 13 Dec 2014 02:36:22 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44095) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XzhFF-0003N9-Rc for emacs-devel@gnu.org; Sat, 13 Dec 2014 02:36:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XzhF9-0004FR-Li for emacs-devel@gnu.org; Sat, 13 Dec 2014 02:36:05 -0500 Original-Received: from plane.gmane.org ([80.91.229.3]:55371) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XzhF9-0004FM-F8 for emacs-devel@gnu.org; Sat, 13 Dec 2014 02:35:59 -0500 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1XzhF5-0001yE-Sn for emacs-devel@gnu.org; Sat, 13 Dec 2014 08:35:55 +0100 Original-Received: from 37.161.199.35 ([37.161.199.35]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 13 Dec 2014 08:35:55 +0100 Original-Received: from thierry.volpiatto by 37.161.199.35 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 13 Dec 2014 08:35:55 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 24 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 37.161.199.35 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) Cancel-Lock: sha1:dZgTTOZBCiGpHTxqgo0YZPVPUO0= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:179977 Archived-At: Stefan Monnier writes: >> Stefan, is `file-name-all-completions'+`file-symlink-p' still 10x faster >> than `directory-files'+`file-directory-p'? > > As long as the file-symlink-p call is only made for directories, it > shouldn't affect the speed very much. I am not sure the speed is 10X faster vs directory-files, especially when sorting the resulting list of `file-name-all-completions'. Also it seems the function is still inflooping even with the check of file-symlink-p (a bug of file-name-all-completions ?). My own function is working fine using (directory-files+file-attributes) with decent performances, but if I try to use (file-name-all-completions+check "/$") it infloop also. PS: Sorry if I sent two mails off list. -- Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997