bug#19552: 25.0.50; void-function class-slot-initarg with new EIEIO changes

[Eric Abrahamsen <eric@ericabrahamsen.net>]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> The other is the "gh" Github-access package from Melpa: that gives "too
>> many arguments to defclass".
>
> Can you show a backtrace for that error?

I don't know how to get a proper backtrace for compilation errors...

After installing the gh package, it tries to compile, and ends up with
this *Compile Log*:

Leaving directory `/home/eric/.emacs.d/elpa/gh-20141230.158'
\f
Compiling file /home/eric/.emacs.d/elpa/gh-20141230.158/gh-api.el at Mon Jan 12 14:21:14 2015
Entering directory `/home/eric/.emacs.d/elpa/gh-20141230.158/'
gh-api.el:39:1:Error: Too many arguments to `defclass'
\f
Compiling file /home/eric/.emacs.d/elpa/gh-20141230.158/gh-auth.el at Mon Jan 12 14:21:14 2015
gh-auth.el:171:1:Error: Too many arguments to `defclass'
\f
Compiling file /home/eric/.emacs.d/elpa/gh-20141230.158/gh-autoloads.el at Mon Jan 12 14:21:14 2015
;\f
Compiling file /home/eric/.emacs.d/elpa/gh-20141230.158/gh-cache.el at Mon Jan 12 14:21:14 2015
gh-cache.el:35:1:Error: Too many arguments to `defclass'
\f
Compiling file /home/eric/.emacs.d/elpa/gh-20141230.158/gh-common.el at Mon Jan 12 14:21:14 2015
\f
Compiling file /home/eric/.emacs.d/elpa/gh-20141230.158/gh-gist.el at Mon Jan 12 14:21:14 2015
gh-gist.el:35:1:Error: Too many arguments to `defclass'
\f
Compiling file /home/eric/.emacs.d/elpa/gh-20141230.158/gh-issue-comments.el at Mon Jan 12 14:21:14 2015
gh-issue-comments.el:41:1:Error: Too many arguments to `defclass'
\f
Compiling file /home/eric/.emacs.d/elpa/gh-20141230.158/gh-issues.el at Mon Jan 12 14:21:14 2015
gh-issues.el:39:1:Error: Too many arguments to `defclass'
\f
Compiling file /home/eric/.emacs.d/elpa/gh-20141230.158/gh-oauth.el at Mon Jan 12 14:21:14 2015
gh-oauth.el:35:1:Error: Too many arguments to `defclass'
\f
Compiling file /home/eric/.emacs.d/elpa/gh-20141230.158/gh-orgs.el at Mon Jan 12 14:21:14 2015
gh-orgs.el:35:1:Error: Too many arguments to `defclass'
\f
Compiling file /home/eric/.emacs.d/elpa/gh-20141230.158/gh-pkg.el at Mon Jan 12 14:21:14 2015
\f
Compiling file /home/eric/.emacs.d/elpa/gh-20141230.158/gh-profile.el at Mon Jan 12 14:21:14 2015
\f
Compiling file /home/eric/.emacs.d/elpa/gh-20141230.158/gh-pull-comments.el at Mon Jan 12 14:21:15 2015
gh-pull-comments.el:45:1:Error: Too many arguments to `defclass'
\f
Compiling file /home/eric/.emacs.d/elpa/gh-20141230.158/gh-pulls.el at Mon Jan 12 14:21:15 2015
gh-pulls.el:35:1:Error: Too many arguments to `defclass'
\f
Compiling file /home/eric/.emacs.d/elpa/gh-20141230.158/gh-repos.el at Mon Jan 12 14:21:15 2015
gh-repos.el:35:1:Error: Too many arguments to `defclass'
\f
Compiling file /home/eric/.emacs.d/elpa/gh-20141230.158/gh-url.el at Mon Jan 12 14:21:15 2015
\f
Compiling file /home/eric/.emacs.d/elpa/gh-20141230.158/gh-users.el at Mon Jan 12 14:21:15 2015
gh-users.el:35:1:Error: Too many arguments to `defclass'
\f
Compiling file /home/eric/.emacs.d/elpa/gh-20141230.158/gh.el at Mon Jan 12 14:21:15 2015
gh.el:29:1:Error: Too many arguments to `defclass'

Following any of the linked errors leads to the require statements at
the top of the file in question, and round and round you go. I can't
actually get to a real error related to defclass. There's something odd
about the require pattern of this package: gh-auth.el ends this way:

(provide 'gh-auth)
;; to avoid circular dependencies...
(require 'gh-oauth)
;;; gh-auth.el ends here

I don't really understand why. It might be worth getting Yann Hodique to
comment.