From: Thierry Volpiatto <thierry.volpiatto@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Artur Malabarba <arturmalabarba@gmail.com>,
emacs-devel <emacs-devel@gnu.org>
Subject: Re: package.el dependencies
Date: Thu, 29 Jan 2015 08:22:08 +0100 [thread overview]
Message-ID: <87d25yt5jz.fsf@gmail.com> (raw)
In-Reply-To: <87egqetap7.fsf@gmail.com>
Thierry Volpiatto <thierry.volpiatto@gmail.com> writes:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
>>>> +(defcustom packages-installed-directly nil
>>>> + "Store here packages installed explicitely by user.
>>>> +This variable will be feeded automaticaly by emacs,
>>>> +so you should not modify it yourself.
>>> Then don't make it a defcustom :-).
>>
>> I agree with Arthur's reaction to the docstring's message. But I think
>> in reality the problem is in the docstring: there's nothing wrong with
>> setting this variable via Custom (or via setq).
>> We should very much support such usage.
>>
>> E.g. we should provide a command which makes sure that all packages in
>> packages-installed-directly are indeed installed. So a user can copy
>> her init file to a new computer and then use this command to
>> auto-install all the packages she likes.
>>
>> Of course, this also hints at the fact that the name is not right.
>> The name should be more along the lines of "user selected packages", or
>> something like that.
>
> Ok done, I haven't done the rename of `packages-installed-directly'
> though, I leave you the choice of the name.
I have also added a reinstall command which is handy when one want to
reinstall a package which is not directly installed.
> diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
> index ba9fcd2..92bcbf1 100644
> --- a/lisp/emacs-lisp/package.el
> +++ b/lisp/emacs-lisp/package.el
> @@ -335,10 +335,12 @@ contents of the archive."
>
> (defcustom packages-installed-directly nil
> "Store here packages installed explicitely by user.
> -This variable will be feeded automaticaly by emacs,
> -so you should not modify it yourself.
> +This variable will be feeded automatically by emacs,
> +when installing a new package.
> This variable will be used by `package-autoremove' to decide
> -which packages are no more needed."
> +which packages are no more needed.
> +You can use it to (re)install packages on other machines
> +by running `package-user-selected-packages-install'."
> :group 'package
> :type '(repeat (choice symbol)))
>
> @@ -1428,6 +1430,27 @@ The file can either be a tar file or an Emacs Lisp file."
> (indirect indirect-deps)
> (t (append direct-deps indirect-deps)))))
>
> +(defun package-user-selected-packages-installed-p ()
> + (cl-loop for p in packages-installed-directly
> + always (package-installed-p p)))
> +
> +;;;###autoload
> +(defun package-user-selected-packages-install ()
> + "Ensure packages in `packages-installed-directly' are installed.
> +If some packages are not installed propose to install them."
> + (interactive)
> + (cl-loop for p in packages-installed-directly
> + unless (package-installed-p p)
> + collect p into lst
> + finally
> + (if lst
> + (when (y-or-n-p
> + (format "%s packages will be installed:\n%s, proceed?"
> + (length lst)
> + (mapconcat 'symbol-name lst ", ")))
> + (mapc 'package-install lst))
> + (message "All your packages are already installed"))))
> +
> (defun package-used-elsewhere-p (pkg &optional pkg-list)
> "Check in PKG-LIST if PKG is used elsewhere as dependency.
> When not specified, PKG-LIST default to `package-alist' with PKG entry removed.
> @@ -1618,6 +1641,9 @@ If optional arg NO-ACTIVATE is non-nil, don't activate packages."
> (unless no-activate
> (dolist (elt package-alist)
> (package-activate (car elt))))
> + (unless (package-user-selected-packages-installed-p)
> + (when (y-or-n-p "It seems some user-installed packages are missing, update now? ")
> + (package-user-selected-packages-install)))
> (setq package--initialized t))
>
> \f
--
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997
next prev parent reply other threads:[~2015-01-29 7:22 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-23 13:37 package.el dependencies Thierry Volpiatto
2015-01-23 13:46 ` Dmitry Gutov
2015-01-23 14:12 ` Ivan Shmakov
2015-01-23 20:40 ` Stefan Monnier
2015-01-23 21:02 ` Thierry Volpiatto
2015-01-24 0:50 ` Artur Malabarba
2015-01-24 4:55 ` Stefan Monnier
2015-01-25 6:51 ` Thierry Volpiatto
2015-01-26 7:17 ` Thierry Volpiatto
2015-01-26 9:19 ` Artur Malabarba
2015-01-26 9:54 ` Thierry Volpiatto
2015-01-26 12:46 ` Artur Malabarba
2015-01-26 14:52 ` Stefan Monnier
2015-01-27 6:10 ` Thierry Volpiatto
2015-01-27 11:52 ` Artur Malabarba
2015-01-25 9:18 ` Thierry Volpiatto
2015-01-25 14:54 ` Stefan Monnier
2015-01-25 15:48 ` Thierry Volpiatto
2015-01-25 17:10 ` Dmitry Gutov
2015-01-25 18:32 ` Stephen Leake
2015-01-25 18:21 ` Artur Malabarba
2015-01-26 4:48 ` Thierry Volpiatto
2015-01-26 12:35 ` Artur Malabarba
2015-01-26 12:53 ` Artur Malabarba
2015-01-26 15:22 ` Thierry Volpiatto
2015-01-26 15:44 ` Stefan Monnier
2015-01-27 6:08 ` Thierry Volpiatto
2015-01-26 16:34 ` Artur Malabarba
2015-01-28 7:30 ` Thierry Volpiatto
2015-01-28 8:55 ` Thierry Volpiatto
2015-01-28 12:42 ` Thierry Volpiatto
2015-01-28 13:17 ` Artur Malabarba
2015-01-28 14:32 ` Thierry Volpiatto
2015-01-28 13:40 ` Dmitry Gutov
2015-01-28 10:47 ` Artur Malabarba
2015-01-28 11:58 ` Thierry Volpiatto
2015-01-28 19:33 ` Stefan Monnier
2015-01-28 19:50 ` Ivan Shmakov
2015-01-28 20:12 ` Artur Malabarba
2015-01-28 22:20 ` Stefan Monnier
2015-01-29 5:31 ` Thierry Volpiatto
2015-01-29 7:22 ` Thierry Volpiatto [this message]
2015-01-30 5:38 ` Thierry Volpiatto
2015-01-30 16:43 ` Artur Malabarba
2015-01-30 17:13 ` Thierry Volpiatto
2015-01-31 6:01 ` Thierry Volpiatto
2015-01-31 10:58 ` Artur Malabarba
2015-01-31 20:26 ` Stefan Monnier
[not found] ` <874mr67gjb.fsf@gmail.com>
[not found] ` <jwvvbjmnun4.fsf-monnier+emacs@gnu.org>
[not found] ` <87oapervqv.fsf@gmail.com>
[not found] ` <jwvk302nnmd.fsf-monnier+emacs@gnu.org>
[not found] ` <877fw2kp1y.fsf@gmail.com>
[not found] ` <jwvioflbrlg.fsf-monnier+emacs@gnu.org>
[not found] ` <87d25tps2q.fsf@gmail.com>
[not found] ` <jwvy4oggva5.fsf-monnier+emacs@gnu.org>
2015-02-02 20:35 ` Thierry Volpiatto
2015-02-02 21:37 ` Artur Malabarba
2015-02-03 4:53 ` Thierry Volpiatto
2015-02-03 5:13 ` Stefan Monnier
2015-02-03 10:04 ` Artur Malabarba
2015-02-03 14:06 ` Artur Malabarba
2015-02-03 5:45 ` Thierry Volpiatto
2015-02-03 10:05 ` Artur Malabarba
2015-02-03 10:18 ` Thierry Volpiatto
2015-02-03 11:39 ` Artur Malabarba
2015-02-02 21:19 ` Thierry Volpiatto
2015-02-02 21:22 ` Dmitry Gutov
2015-02-03 11:39 ` Artur Malabarba
2015-02-03 11:44 ` Dmitry Gutov
2015-01-31 6:51 ` Thierry Volpiatto
2015-01-31 20:30 ` Stefan Monnier
2015-01-31 22:10 ` Thierry Volpiatto
2015-01-31 23:26 ` Artur Malabarba
2015-02-01 6:29 ` Thierry Volpiatto
2015-02-01 7:02 ` Thierry Volpiatto
2015-02-01 15:55 ` Thierry Volpiatto
2015-02-01 23:47 ` Artur Malabarba
2015-02-02 12:00 ` Artur Malabarba
2015-02-02 13:14 ` Thierry Volpiatto
2015-02-02 14:14 ` Thierry Volpiatto
2015-02-02 14:56 ` Artur Malabarba
2015-02-02 15:19 ` Thierry Volpiatto
2015-02-02 15:33 ` Thierry Volpiatto
2015-02-02 15:50 ` Artur Malabarba
2015-02-02 16:07 ` Thierry Volpiatto
2015-02-02 21:23 ` Thierry Volpiatto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d25yt5jz.fsf@gmail.com \
--to=thierry.volpiatto@gmail.com \
--cc=arturmalabarba@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.