From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Matthew Carter Newsgroups: gmane.emacs.devel Subject: Re: GNU Elpa Theme (ahungry-theme) - should I add code to auto load-theme it? Date: Thu, 05 Feb 2015 14:58:45 -0500 Organization: Ahungry (http://ahungry.com) Message-ID: <87d25odtai.fsf@ahungry.com> References: <87iofo7xfo.fsf@ahungry.com> <87mw4sdzi0.fsf@ahungry.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1423166340 28188 80.91.229.3 (5 Feb 2015 19:59:00 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 5 Feb 2015 19:59:00 +0000 (UTC) Cc: Artur Malabarba , emacs-devel To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 05 20:58:59 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YJSZm-00030x-BY for ged-emacs-devel@m.gmane.org; Thu, 05 Feb 2015 20:58:58 +0100 Original-Received: from localhost ([::1]:44986 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJSZl-0006FB-Nk for ged-emacs-devel@m.gmane.org; Thu, 05 Feb 2015 14:58:57 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36072) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJSZi-0006EN-Cm for emacs-devel@gnu.org; Thu, 05 Feb 2015 14:58:55 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YJSZd-0005EE-Az for emacs-devel@gnu.org; Thu, 05 Feb 2015 14:58:54 -0500 Original-Received: from li130-200.members.linode.com ([69.164.215.200]:33427 helo=mail.ahungry.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJSZd-0005EA-7Y for emacs-devel@gnu.org; Thu, 05 Feb 2015 14:58:49 -0500 Original-Received: from Prometheus (99-40-9-245.lightspeed.livnmi.sbcglobal.net [99.40.9.245]) by mail.ahungry.com (Postfix) with ESMTPSA id 9F06B4079; Thu, 5 Feb 2015 14:58:46 -0500 (EST) In-Reply-To: (Stefan Monnier's message of "Thu, 05 Feb 2015 14:13:26 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 69.164.215.200 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:182476 Archived-At: Stefan Monnier writes: >> The fact that the theme becomes active upon a require isn't unintended >> functionality is it? > > I can't speak for the coder's intentions, but at least normally > loading/requiring a file is not supposed to have such side-effects, so > I'd consider it a bug. > > > Stefan > Hi Stefan, By coder and bug, are you referring to my ahungry-theme ELPA package, or the author of the deftheme components/package built into emacs 24? My theme has 3 calls in it: (deftheme ahungry) (custom-theme-set-faces 'ahungry ) (provide-theme 'ahungry) Which I thought were the 3 standard components to a custom theme file? In most cases, a user has zero reason to #'require the theme unless they plan to load it, so the fact that the #'require acts as a #'load-theme (but based off the load-path instead of custom-theme-load-path) seems like a good side-effect to me (at least until the ELPA generated autoload file has support for adding ELPA loaded themes into the custom-theme-load-path automatically). -- Matthew Carter (m@ahungry.com) http://ahungry.com