all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Matthew Carter <m@ahungry.com>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: Artur Malabarba <bruce.connor.am@gmail.com>,
	emacs-devel <emacs-devel@gnu.org>
Subject: Re: GNU Elpa Theme (ahungry-theme) - should I add code to auto load-theme it?
Date: Thu, 05 Feb 2015 14:58:45 -0500	[thread overview]
Message-ID: <87d25odtai.fsf@ahungry.com> (raw)
In-Reply-To: <jwv7fvw41g7.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Thu, 05 Feb 2015 14:13:26 -0500")

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

>> The fact that the theme becomes active upon a require isn't unintended
>> functionality is it?
>
> I can't speak for the coder's intentions, but at least normally
> loading/requiring a file is not supposed to have such side-effects, so
> I'd consider it a bug.
>
>
>         Stefan
>

Hi Stefan,

By coder and bug, are you referring to my ahungry-theme ELPA package, or
the author of the deftheme components/package built into emacs 24?

My theme has 3 calls in it:

(deftheme ahungry)
(custom-theme-set-faces 'ahungry <theme face settings omitted>)
(provide-theme 'ahungry)

Which I thought were the 3 standard components to a custom theme file?

In most cases, a user has zero reason to #'require the theme unless they
plan to load it, so the fact that the #'require acts as a #'load-theme
(but based off the load-path instead of custom-theme-load-path) seems
like a good side-effect to me (at least until the ELPA generated
autoload file has support for adding ELPA loaded themes into the
custom-theme-load-path automatically).

-- 
Matthew Carter (m@ahungry.com)
http://ahungry.com



  reply	other threads:[~2015-02-05 19:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-30 21:47 GNU Elpa Theme (ahungry-theme) - should I add code to auto load-theme it? Matthew Carter
2015-01-30 21:50 ` Dmitry Gutov
2015-01-30 23:57 ` Artur Malabarba
2015-02-05 17:44   ` Matthew Carter
2015-02-05 19:13     ` Stefan Monnier
2015-02-05 19:58       ` Matthew Carter [this message]
2015-02-05 20:48         ` Stefan Monnier
2015-02-05 22:08         ` Artur Malabarba
2015-02-06  4:03           ` Matthew Carter
2015-02-06  8:59             ` Artur Malabarba
2015-02-05 19:31     ` Ivan Shmakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d25odtai.fsf@ahungry.com \
    --to=m@ahungry.com \
    --cc=bruce.connor.am@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@IRO.UMontreal.CA \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.