bug#19903: 24.4; wrong-type-argument symbolp "bold" during enriched-encode

[Ivan Shmakov <ivan@siamics.net>]

>>>>> Stefan Monnier <monnier@iro.umontreal.ca> writes:

 >> + (warn "Face %S is a string; interning" face)

 >> + (message "Face %S is a string; interning" face)

 > Why `warn' in one and `message' in the other?

	By the time we hit this in ‘face-attribute’, the point at which
	the sub-setandard string-named face was introduced is presumably
	long gone, so there’s no good reason to use ‘warn’.

	On the contrary, ‘facemenu-add-face’ is likely to be invoked
	either directly by the user, or as part of some other
	interactive command.  Should the call result in a warning,
	the user would probably be able to gather enough context from
	his or her actions immediately preceding the warning.

 > These could end up spewing a lot of warnings at times, so it's a bit
 > risky, but if such uses are sufficiently rare it might be OK.

	At least so I hope.

-- 
FSF associate member #7257  http://boycottsystemd.org/  … 3013 B6A0 230E 334A