Bug #18834 needs backporting

Bug #18834 needs backporting

[Jordan Wilson]

I don't know if this is the right mailing list to bring this up, so I
apologise if it isn't.

Bug #18834's patch needs backporting to emacs24. It's eww's "Exit"
tool-bar button not working.
--
Jordan Wilson
Sent from Gnus v5.13, Emacs 24.4.90.1

Re: Bug #18834 needs backporting

[Eli Zaretskii]

> From: Jordan Wilson <inopem@gmail.com>
> Date: Fri, 20 Feb 2015 22:42:30 +0000
> 
> I don't know if this is the right mailing list to bring this up, so I
> apologise if it isn't.
> 
> Bug #18834's patch needs backporting to emacs24. It's eww's "Exit"
> tool-bar button not working.

Unless this is a regression from 24.4, this backport will have to wait
until after 24.5 is released, sorry.

Re: Bug #18834 needs backporting

[Stefan Monnier]

>> Bug #18834's patch needs backporting to emacs24. It's eww's "Exit"
>> tool-bar button not working.
> Unless this is a regression from 24.4, this backport will have to wait
> until after 24.5 is released, sorry.

If it's an "obviously safe" (yeah, right) fix for a regression w.r.t
24.3, we could consider it for 24.5.


        Stefan

Re: Bug #18834 needs backporting

[Jordan Wilson]

[-- Attachment #1: Type: text/plain, Size: 142 bytes --]

It's just two lines that have to be changed. The patch contributed by
Ivan Shmakov (which was applied to master back in October) is attached.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: eww.patch --]
[-- Type: text/x-diff, Size: 565 bytes --]

--- eww.el
+++ eww.el
@@ -443,7 +443,7 @@
 
     (easy-menu-define nil map ""
       '("Eww"
-	["Exit" eww-quit t]
+	["Exit" quit-window t]
 	["Close browser" quit-window t]
 	["Reload" eww-reload t]
 	["Back to previous page" eww-back-url
@@ -463,7 +463,7 @@
 (defvar eww-tool-bar-map
   (let ((map (make-sparse-keymap)))
     (dolist (tool-bar-item
-             '((eww-quit . "close")
+             '((quit-window . "close")
                (eww-reload . "refresh")
                (eww-back-url . "left-arrow")
                (eww-forward-url . "right-arrow")

[-- Attachment #3: Type: text/plain, Size: 56 bytes --]

-- 
Jordan Wilson
Sent from Gnus v5.13, Emacs 24.4.90.1

Re: Bug #18834 needs backporting

[Eli Zaretskii]

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Jordan Wilson <inopem@gmail.com>,  emacs-devel@gnu.org
> Date: Sat, 21 Feb 2015 15:26:36 -0500
> 
> >> Bug #18834's patch needs backporting to emacs24. It's eww's "Exit"
> >> tool-bar button not working.
> > Unless this is a regression from 24.4, this backport will have to wait
> > until after 24.5 is released, sorry.
> 
> If it's an "obviously safe" (yeah, right) fix for a regression w.r.t
> 24.3, we could consider it for 24.5.

Its criticality (or lack thereof) is also a factor, I think.

Re: Bug #18834 needs backporting

[Stefan Monnier]

> Its criticality (or lack thereof) is also a factor, I think.

Agreed.


        Stefan "who didn't bother to look at the bug under discussion"