From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 1fcc552: lisp/gnus/registry.el (registry-prune): Allow registry to reach full size before pruning Date: Sat, 21 Mar 2015 09:32:27 +0800 Message-ID: <87d243nnis.fsf@ericabrahamsen.net> References: <20150320104953.20367.194@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1426901603 11570 80.91.229.3 (21 Mar 2015 01:33:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 21 Mar 2015 01:33:23 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 21 02:33:08 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YZ8Hk-0004g2-Cj for ged-emacs-devel@m.gmane.org; Sat, 21 Mar 2015 02:33:08 +0100 Original-Received: from localhost ([::1]:46286 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZ8He-0004Gs-Bw for ged-emacs-devel@m.gmane.org; Fri, 20 Mar 2015 21:33:02 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56915) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZ8Hb-0004Gm-68 for emacs-devel@gnu.org; Fri, 20 Mar 2015 21:32:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YZ8HX-0005uF-Mz for emacs-devel@gnu.org; Fri, 20 Mar 2015 21:32:58 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:40149) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZ8HX-0005u7-GJ for emacs-devel@gnu.org; Fri, 20 Mar 2015 21:32:55 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1YZ8HT-0004VL-Vt for emacs-devel@gnu.org; Sat, 21 Mar 2015 02:32:52 +0100 Original-Received: from 123.123.17.56 ([123.123.17.56]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 21 Mar 2015 02:32:51 +0100 Original-Received: from eric by 123.123.17.56 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 21 Mar 2015 02:32:51 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 15 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 123.123.17.56 User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux) Cancel-Lock: sha1:s2j7AFjAOPSC1Gk7bBDZ2VIPPig= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:184067 Archived-At: Stefan Monnier writes: >> + (if (> size (oref db :max-size)) > > Why do people use the :initarg rather than the slot name? > > (oref db max-size) > > works as well (actually better: it's implemented more efficiently). Because we didn't know any better! For some value of "us"... I saw your recent patch to the registry files, but you only changed *some* of the calls to oref/oset to use slot names. That was confusing. I can change the rest of them over, if that's desirable.