From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 1fcc552: lisp/gnus/registry.el (registry-prune): Allow registry to reach full size before pruning
Date: Sat, 21 Mar 2015 09:32:27 +0800 [thread overview]
Message-ID: <87d243nnis.fsf@ericabrahamsen.net> (raw)
In-Reply-To: jwvwq2bwxdm.fsf-monnier+emacsdiffs@gnu.org
Stefan Monnier <monnier@IRO.UMontreal.CA> writes:
>> + (if (> size (oref db :max-size))
>
> Why do people use the :initarg rather than the slot name?
>
> (oref db max-size)
>
> works as well (actually better: it's implemented more efficiently).
Because we didn't know any better! For some value of "us"...
I saw your recent patch to the registry files, but you only changed
*some* of the calls to oref/oset to use slot names. That was confusing.
I can change the rest of them over, if that's desirable.
next prev parent reply other threads:[~2015-03-21 1:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150320104953.20367.194@vcs.savannah.gnu.org>
[not found] ` <E1YYuUz-0005J8-GO@vcs.savannah.gnu.org>
2015-03-20 14:35 ` [Emacs-diffs] master 1fcc552: lisp/gnus/registry.el (registry-prune): Allow registry to reach full size before pruning Stefan Monnier
2015-03-21 1:32 ` Eric Abrahamsen [this message]
2015-03-21 2:46 ` Stefan Monnier
2015-03-21 14:12 ` Eric Abrahamsen
2015-04-18 10:51 ` Ted Zlatanov
2015-04-18 14:20 ` Stefan Monnier
2015-04-18 14:34 ` Ted Zlatanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d243nnis.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.