From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Oleh Krehel Newsgroups: gmane.emacs.devel Subject: Re: [elpa] master 6a098c6 15/19: Add ivy-mode Date: Thu, 16 Apr 2015 15:34:39 +0200 Message-ID: <87d234kxhs.fsf@gmail.com> References: <20150416121807.21266.28456@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1429191631 25987 80.91.229.3 (16 Apr 2015 13:40:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 16 Apr 2015 13:40:31 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Apr 16 15:40:26 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Yik1q-0007Z3-Cc for ged-emacs-devel@m.gmane.org; Thu, 16 Apr 2015 15:40:26 +0200 Original-Received: from localhost ([::1]:36938 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yik1p-0008LD-Ic for ged-emacs-devel@m.gmane.org; Thu, 16 Apr 2015 09:40:25 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41332) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yik1d-0008L7-1y for emacs-devel@gnu.org; Thu, 16 Apr 2015 09:40:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yik1Z-0001Zu-7d for emacs-devel@gnu.org; Thu, 16 Apr 2015 09:40:13 -0400 Original-Received: from mail-wg0-x22d.google.com ([2a00:1450:400c:c00::22d]:33359) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yik1Z-0001Zn-0a for emacs-devel@gnu.org; Thu, 16 Apr 2015 09:40:09 -0400 Original-Received: by wgin8 with SMTP id n8so81060527wgi.0 for ; Thu, 16 Apr 2015 06:40:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=PRmezr3UQ+IHjIhzK7T3wAIy+q1u0X69HVB2RSkxSwg=; b=UeKuQOfZiacYYUowNQO1gg076rogpos9zMHg1g6fxuU9m53g9zikpOxPfhdkBGdlk9 JM1NXgYWWfU0Vu/skU187tLkeU0TuXw3vpVSHJXlatRX/oChY2yw0UsrdrlKjgQOm1tU H7YYjr22z4XYAhbjg8nM70zaGoYYhFiJyQFHYNSdbY8khEwp906FZpjpWOgeL1eUjV9z Au7OnT1hL6zfHq6C8y9TWkg8wADcpm/SUOYAAIRLK+vobHX1ZlcVAJaq6ZbjTdYOCNxw byvYAcXlzZJD3fPnDWJoePENOZ/zOd26sRmD1Q8j2vhI+2vLroZKLKm86tE4pM2QmyVf xipQ== X-Received: by 10.180.78.136 with SMTP id b8mr5299335wix.76.1429191608179; Thu, 16 Apr 2015 06:40:08 -0700 (PDT) Original-Received: from firefly (dyn069045.nbw.tue.nl. [131.155.69.45]) by mx.google.com with ESMTPSA id ch6sm10487960wjc.3.2015.04.16.06.40.06 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 16 Apr 2015 06:40:07 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Thu, 16 Apr 2015 09:37:28 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c00::22d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:185498 Archived-At: Stefan Monnier writes: >> + (cond ((functionp collection) >> + (error "Function as a collection unsupported")) >> + ((hash-table-p collection) >> + (error "Hash table as a collection unsupported")) >> + ((listp (car collection)) >> + (setq collection (mapcar #'car collection)))) > [...] >> + (setq completing-read-function 'ivy-completing-read) > > Since completion-tables in the form of a function are pretty common > nowadays (and becoming every time more frequent), this is a real > problem: > > emacs -Q -l .../swiper/swiper-autoloads.el > M-x ivy-mode RET > C-x C-f > C-x b > > Notice how both C-x C-f and C-x b signal errors. Yeah, that feature isn't completely ready yet. I just have to read up on what to do if `collection' is a function. Oleh