From: Krzysztof Jurewicz <krzysztof.jurewicz@gmail.com>
To: 20541@debbugs.gnu.org
Subject: bug#20541: ERC password fetching using Secret Service API is broken
Date: Sun, 10 May 2015 16:13:56 +0200 [thread overview]
Message-ID: <87d228lduj.fsf@gmail.com> (raw)
When trying to store ERC passwords using Secret Service API (i.e. when
using GNOME Keyring), ERC breaks when trying to join a channel.
Steps to reproduce:
⒈ Run emacs -Q.
⒉ Eval (require 'auth-source).
⒊ Eval (setq auth-sources '("secrets:FOO")), where FOO is an existing
keyring name.
⒋ Open ERC.
⒌ Try to connect to Freenode using the default settings.
What happens:
The following error is displayed:
auth-source-secrets-listify-pattern: Wrong type argument: sequencep, 6667
What should happen:
I should connect to Freenode.
One possible patch is attached below. This is the simplest solution; I
have not thought much about whether it may be more desirable to convert
numbers to strings inside the secrets.el package.
From 25f798b3b86a34bd6b262c59c3733d72eec50c13 Mon Sep 17 00:00:00 2001
From: Krzysztof Jurewicz <krzysztof.jurewicz@gmail.com>
Date: Thu, 7 May 2015 13:01:24 +0200
Subject: [PATCH] * lisp/erc/erc.el (erc-open): Fix password fetching
ERC used to pass the port number as a number, however when using
Secret Service API, only strings can be used.
Copyright-paperwork-exempt: yes
---
lisp/erc/erc.el | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el
index cf422f1..a8f1478 100644
--- a/lisp/erc/erc.el
+++ b/lisp/erc/erc.el
@@ -2010,7 +2010,8 @@ Returns the buffer for the given server or channel."
(auth-source-search :host server
:max 1
:user nick
- :port port
+ ;; secrets.el wouldn’t accept a number
+ :port (if (numberp port) (number-to-string port) port)
:require '(:secret)))
:secret)))
(if (functionp secret)
--
2.4.0
next reply other threads:[~2015-05-10 14:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-10 14:13 Krzysztof Jurewicz [this message]
2015-06-01 9:20 ` bug#20541: ERC password fetching using Secret Service API is broken Michael Albinus
2015-06-30 2:28 ` Ted Zlatanov
2015-12-27 8:05 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d228lduj.fsf@gmail.com \
--to=krzysztof.jurewicz@gmail.com \
--cc=20541@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.