From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: fgallina@gnu.org (=?utf-8?Q?Fabi=C3=A1n?= Ezequiel Gallina) Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 8867296 2/2: ; python.el: Replace `eval-when-compile` with `eval-and-compile` Date: Mon, 06 Jul 2015 20:23:45 -0300 Message-ID: <87d204an0e.fsf@gnu.org> References: <20150706050244.10112.84425@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1436225065 31344 80.91.229.3 (6 Jul 2015 23:24:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 6 Jul 2015 23:24:25 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 07 01:24:20 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZCFkI-0004Gx-F8 for ged-emacs-devel@m.gmane.org; Tue, 07 Jul 2015 01:24:18 +0200 Original-Received: from localhost ([::1]:53310 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCFkH-0004nC-UI for ged-emacs-devel@m.gmane.org; Mon, 06 Jul 2015 19:24:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54859) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCFjt-0004k4-OX for emacs-devel@gnu.org; Mon, 06 Jul 2015 19:23:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZCFjs-0006GJ-Tm for emacs-devel@gnu.org; Mon, 06 Jul 2015 19:23:53 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40029) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCFjn-0006EP-B7; Mon, 06 Jul 2015 19:23:47 -0400 Original-Received: from [190.246.172.180] (port=43620 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1ZCFjm-0006Wr-JP; Mon, 06 Jul 2015 19:23:47 -0400 In-Reply-To: (Stefan Monnier's message of "Mon, 06 Jul 2015 09:47:53 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:187754 Archived-At: Stefan Monnier writes: >> -(eval-when-compile >> +(eval-and-compile >> (defconst python-rx-constituents > > Could you explain why it's needed both at run-time and compile-time? > >> -(eval-when-compile >> +(eval-and-compile >> (defun python-syntax--context-compiler-macro (form type &optional syn= tax-ppss) > > Why is this needed at run-time? > Often I would instrument things when debugging and get errors related to definitions not available at run-time, which is really annoying, and I have to go and eval missing definitions by hand. This is mainly an attempt to leave things in a development friendly state. Is there any obvious harm in this change? Thanks, Fabi=C3=A1n.