all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: David Kastrup <dak@gnu.org>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 8ba156f: Attempt to avoid crashes in plist-member
Date: Tue, 13 Oct 2015 15:41:29 +0200	[thread overview]
Message-ID: <87d1wi9986.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <jwvfv1e7vjw.fsf-monnier+emacsdiffs@gnu.org> (Stefan Monnier's message of "Tue, 13 Oct 2015 09:23:37 -0400")

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

>>> QUIT could call some Lisp.
>> Sure, but it would not return.
>
> Actually, QUIT can run Elisp and return (the `quit' signal is the only
> signal that can do that).

I have my doubt this could be the cause of the problem: between CONSP
and XCDR the value has to be kept somewhere: in a register or on the
stack.  If Lisp code were running garbage collection in between, this
cons cell would be protected due to its presence in the stack frame.

The only plausible explanation I'd have is that CONSP happens to be true
(due to the set bits in the value) but the value is garbage anyway and
points nowhere sane.  In that case, any intermittent QUIT call would be
a red herring: the XCDR would bork on the value anyway.

-- 
David Kastrup



  reply	other threads:[~2015-10-13 13:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20151012170324.17966.77@vcs.savannah.gnu.org>
     [not found] ` <E1ZlgVQ-0004gO-Em@vcs.savannah.gnu.org>
2015-10-13  1:07   ` [Emacs-diffs] master 8ba156f: Attempt to avoid crashes in plist-member Stefan Monnier
2015-10-13  2:42     ` Eli Zaretskii
2015-10-13  3:36       ` Paul Eggert
2015-10-13 14:58         ` Eli Zaretskii
2015-10-13 15:08           ` David Kastrup
2015-10-13 15:32             ` Eli Zaretskii
2015-10-13 15:50               ` David Kastrup
2015-10-13 15:21           ` Paul Eggert
2015-10-13 15:34             ` Eli Zaretskii
2015-10-13 19:05           ` Stefan Monnier
2015-10-13  8:00       ` Andreas Schwab
2015-10-13 15:01         ` Eli Zaretskii
2015-10-13 10:26       ` David Kastrup
2015-10-13 13:23         ` Stefan Monnier
2015-10-13 13:41           ` David Kastrup [this message]
2015-10-13 15:16         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d1wi9986.fsf@fencepost.gnu.org \
    --to=dak@gnu.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@IRO.UMontreal.CA \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.