From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?UTF-8?Q?=C3=93scar?= Fuentes Newsgroups: gmane.emacs.bugs Subject: bug#23075: 24.5; vc-git-command should use coding-system-for-read Date: Mon, 21 Mar 2016 17:54:28 +0100 Message-ID: <87d1qng4aj.fsf@wanadoo.es> References: <56EFD97C.3080805@gmail.com> <83wpov6c35.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1458579325 10759 80.91.229.3 (21 Mar 2016 16:55:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 21 Mar 2016 16:55:25 +0000 (UTC) Cc: 23075@debbugs.gnu.org, Nikolay Kudryavtsev To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Mar 21 17:55:13 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ai36l-0005OZ-Bk for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Mar 2016 17:55:11 +0100 Original-Received: from localhost ([::1]:59048 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ai36k-0000mA-Sl for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Mar 2016 12:55:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40116) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ai36h-0000lC-9D for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2016 12:55:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ai36c-0000DR-67 for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2016 12:55:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60050) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ai36c-0000DN-2Q for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2016 12:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ai36b-0001QB-L8 for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2016 12:55:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?=C3=93scar?= Fuentes Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Mar 2016 16:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23075 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23075-submit@debbugs.gnu.org id=B23075.14585792785423 (code B ref 23075); Mon, 21 Mar 2016 16:55:01 +0000 Original-Received: (at 23075) by debbugs.gnu.org; 21 Mar 2016 16:54:38 +0000 Original-Received: from localhost ([127.0.0.1]:57177 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ai36E-0001PP-Iz for submit@debbugs.gnu.org; Mon, 21 Mar 2016 12:54:38 -0400 Original-Received: from smtp10.acens.net ([86.109.99.134]:41426 helo=smtp.movistar.es) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ai36C-0001PA-LP for 23075@debbugs.gnu.org; Mon, 21 Mar 2016 12:54:37 -0400 X-CTCH-RefID: str=0001.0A0B0203.56F02745.0132, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown Original-Received: from qcore (79.153.146.151) by smtp.movistar.es (8.6.122.03) (authenticated as 981711563$telefonica.net) id 56E759CD0076B085; Mon, 21 Mar 2016 16:54:29 +0000 In-Reply-To: <83wpov6c35.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 21 Mar 2016 18:16:14 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.92 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:115245 Archived-At: Eli Zaretskii writes: >> If you have files in your repositories, that are in different coding >> system from vc-git-commits-coding-system, vc-diff would still show diffs >> for them in vc-git-commits-coding-system. >> >> This is unnecessary, since vc-diff-internal already decides what coding >> system to use based on the first file and then sets >> coding-system-for-read accordingly. >> >> The fix is to change vc-git-command to use coding-system-for-read >> whenever it's bound. > > Please show a recipe for reproducing this problem with a recent Git > version and preferably with the latest pretest of Emacs 25.1. Please > include any files necessary for the reproduction. Before we dive into > this tricky issue, I'd like to be sure the problem still exists (since > more than a year has passed since your original reports). > > Also, this is specific to MS-Windows, right? Maybe this is related: on a Kubuntu 15.08 box with a 2 week old emacs 25.0.92.2 and git 2.5.0, if I visit etc/HELLO (on a Emacs checkout) and do `C-x v l' and then, on the *vc-change-log* buffer, put the cursor on the last commit (etc/HELLO: Add Armenian and Mongolian greetings.) and press `d', the ensuing *vc-diff* buffer contains mostly garbage.