From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#23092: 25.0.92; Minibuffer completion fails to resize completion window if reused during same command Date: Fri, 25 Mar 2016 00:14:41 +0200 Organization: LINKOV.NET Message-ID: <87d1qj8qwe.fsf@mail.linkov.net> References: <87fuviigpw.fsf@gmail.com> <83k2ku4bb5.fsf@gnu.org> <8737riibq2.fsf@gmail.com> <837fgu49m1.fsf@gnu.org> <56F24F21.4040107@gmx.at> <878u19gn38.fsf@gmail.com> <56F2E647.7040400@gmx.at> <878u18x4um.fsf@mail.linkov.net> <56F39A89.5010608@gmx.at> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1458857783 31861 80.91.229.3 (24 Mar 2016 22:16:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 24 Mar 2016 22:16:23 +0000 (UTC) Cc: "N. Jackson" , 23092-done@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 24 23:16:12 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ajDY2-0003VV-0V for geb-bug-gnu-emacs@m.gmane.org; Thu, 24 Mar 2016 23:16:10 +0100 Original-Received: from localhost ([::1]:53059 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ajDY1-00066J-5A for geb-bug-gnu-emacs@m.gmane.org; Thu, 24 Mar 2016 18:16:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47909) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ajDXx-00064h-Qk for bug-gnu-emacs@gnu.org; Thu, 24 Mar 2016 18:16:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ajDXu-0003PM-Lu for bug-gnu-emacs@gnu.org; Thu, 24 Mar 2016 18:16:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39479) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ajDXu-0003PH-IC for bug-gnu-emacs@gnu.org; Thu, 24 Mar 2016 18:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ajDXu-0006N1-EN for bug-gnu-emacs@gnu.org; Thu, 24 Mar 2016 18:16:02 -0400 Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Mar 2016 22:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 23092 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 23092@debbugs.gnu.org, juri@jurta.org, nljlistbox2@gmail.com Original-Received: via spool by 23092-done@debbugs.gnu.org id=D23092.145885771224412 (code D ref 23092); Thu, 24 Mar 2016 22:16:02 +0000 Original-Received: (at 23092-done) by debbugs.gnu.org; 24 Mar 2016 22:15:12 +0000 Original-Received: from localhost ([127.0.0.1]:36604 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ajDX6-0006Lg-Id for submit@debbugs.gnu.org; Thu, 24 Mar 2016 18:15:12 -0400 Original-Received: from sub3.mail.dreamhost.com ([69.163.253.7]:53744 helo=homiemail-a23.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ajDX5-0006LY-5R for 23092-done@debbugs.gnu.org; Thu, 24 Mar 2016 18:15:11 -0400 Original-Received: from homiemail-a23.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a23.g.dreamhost.com (Postfix) with ESMTP id 304624B006D; Thu, 24 Mar 2016 15:15:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=jurta.org; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=jurta.org; bh=1eCxhEs VTl1Low3YbLl4DBRLF6s=; b=FyK39e0/SQQxtirqYj1D5MO+gAP9aeEvEwMAFOn UkyS9X5VDP89J3dqqjaGauejayyIdr2dl1hoCW29KY9p0r00tnoa7B34GtQLH+jV PmpYCQh+bpYvhjfVb/d9xJZCnPM0UZXojQWBqBoAA5aU4Xlv7G9CbCCVE9xzK3Jq WEo4= Original-Received: from localhost.linkov.net (85.253.170.210.cable.starman.ee [85.253.170.210]) (Authenticated sender: jurta@jurta.org) by homiemail-a23.g.dreamhost.com (Postfix) with ESMTPA id 06A354B0063; Thu, 24 Mar 2016 15:15:07 -0700 (PDT) In-Reply-To: <56F39A89.5010608@gmx.at> (martin rudalics's message of "Thu, 24 Mar 2016 08:43:05 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.91 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:115457 Archived-At: >> However, after I looked at this again now, it looks natural to just >> replace =E2=80=98shrink-window-if-larger-than-buffer=E2=80=99 with =E2= =80=98fit-window-to-buffer=E2=80=99. >> But I'd leave it to you to decide how good this change is and what >> consequences it might entail. > > It should have two consequences: (1) When there are many completions, > the *Completions* window might be larger initially. This doesn't look like a bad consequence since more currently active data on screen is better. > (2) The *Completions* window will mostly behave as if =E2=80=98temp-buf= fer-resize-mode=E2=80=99 > were enabled by default. I think the OP's scenario is much more > embarrassing so I think we can live with the consequences of your fix. > > Please install it and I'll fix the manual accordingly. Fixed minibuffer-completion-help now. > Thanks, martin > >> diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el >> index ecac0ae..6540059 100644 >> --- a/lisp/minibuffer.el >> +++ b/lisp/minibuffer.el >> @@ -1835,7 +1835,7 @@ minibuffer-completion-help >> 'display-buffer-below-selected)) >> ,(if temp-buffer-resize-mode >> '(window-height . resize-temp-buffer-window) >> - '(window-height . shrink-window-if-larger-than-buffer)) >> + '(window-height . fit-window-to-buffer)) >> ,(when temp-buffer-resize-mode >> '(preserve-size . (nil . t)))) >> nil