From: npostavs@users.sourceforge.net
To: David Shepherd <davidshepherd7@gmail.com>
Cc: 24778@debbugs.gnu.org
Subject: bug#24778: 25.1; cl-assert always calls the default debugger on assertion failures
Date: Fri, 04 Nov 2016 21:58:18 -0400 [thread overview]
Message-ID: <87d1iapu11.fsf@users.sourceforge.net> (raw)
In-Reply-To: <87mvhnqsg2.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net's message of "Sat, 29 Oct 2016 07:56:45 -0400")
tags 24778 fixed
close 24778 25.2
quit
>>
>> Removing the lines
>>
>> (if debug-on-error
>> (apply debugger `(cl-assertion-failed ,form ,string ,@sargs))
>>
>> from cl--assertion-failed seems to solve the problem, but I don't know
>> if that would break other things.
>
> This debug-on-error clause is new in 25.1 (specifically, it was added by
> 61b4c22c "* lisp/emacs-lisp/cl*.el: Use define-inline and move some
> code..."), so this looks like a regression to me (and it looks
> accidental, at least the commit message says nothing about it). I'd
> like to remove it for 25.2. Any objections?
I removed that clause in db436e93 "Don't call debug on failed cl-assert"
prev parent reply other threads:[~2016-11-05 1:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-23 19:00 bug#24778: 25.1; cl-assert always calls the default debugger on assertion failures David Shepherd
2016-10-29 11:56 ` npostavs
2016-11-05 1:58 ` npostavs [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1iapu11.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=24778@debbugs.gnu.org \
--cc=davidshepherd7@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.