From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#24873: 26.0.50; isearch-query-replace from regexp isearch doesn't add to replace-regexp history list Date: Sat, 12 Nov 2016 21:42:26 -0500 Message-ID: <87d1i0m771.fsf@users.sourceforge.net> References: <831syrld8g.fsf@gnu.org> <20161104193513.GA22185@holos.localdomain> <87lgwzc8y8.fsf@gmx.net> <20161104205329.GA24042@holos.localdomain> <20161104233540.GA26298@holos.localdomain> <20161105003402.GA30846@holos.localdomain> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1479004956 17985 195.159.176.226 (13 Nov 2016 02:42:36 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 13 Nov 2016 02:42:36 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Cc: Richard Copley , 24873@debbugs.gnu.org, Stephen Berman To: Mark Oteiza Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 13 03:42:31 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c5kkD-0001Tq-6r for geb-bug-gnu-emacs@m.gmane.org; Sun, 13 Nov 2016 03:42:09 +0100 Original-Received: from localhost ([::1]:60393 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c5kkG-00064z-FV for geb-bug-gnu-emacs@m.gmane.org; Sat, 12 Nov 2016 21:42:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36947) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c5kkA-00061k-Bc for bug-gnu-emacs@gnu.org; Sat, 12 Nov 2016 21:42:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c5kk6-0006Wx-FS for bug-gnu-emacs@gnu.org; Sat, 12 Nov 2016 21:42:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39904) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c5kk6-0006Wk-Ax for bug-gnu-emacs@gnu.org; Sat, 12 Nov 2016 21:42:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1c5kk5-0005ws-U3 for bug-gnu-emacs@gnu.org; Sat, 12 Nov 2016 21:42:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Nov 2016 02:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24873 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24873-submit@debbugs.gnu.org id=B24873.147900490722830 (code B ref 24873); Sun, 13 Nov 2016 02:42:01 +0000 Original-Received: (at 24873) by debbugs.gnu.org; 13 Nov 2016 02:41:47 +0000 Original-Received: from localhost ([127.0.0.1]:55303 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c5kjq-0005w5-VK for submit@debbugs.gnu.org; Sat, 12 Nov 2016 21:41:47 -0500 Original-Received: from mail-it0-f51.google.com ([209.85.214.51]:35974) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c5kjp-0005vj-5p; Sat, 12 Nov 2016 21:41:46 -0500 Original-Received: by mail-it0-f51.google.com with SMTP id q124so41650018itd.1; Sat, 12 Nov 2016 18:41:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=eOeo+6tfLZnGpxx38iqxtu4VQhUTjg/CCMHhvycQT+g=; b=QLGelQD5S3xWmYS3bQFH7Y1f7TBtjjXImk5LDCwCDAz8MTyiqnk7OekSsCCfgS4YS+ peMZGyuZA8bJwCq4H/Zihc3HMu73+0WqveaHC7tmurZ0tR8EcKO/aB6LxVe7E4h9tvKV tvX9Nhmgv2OePAsZyoEg5own3QzY0YdA00XE2H8jRefYW9RxzrblUPDk4kRBlZ7ZeHGc R2n15zD5q0SA5b3wUN85pWMU/xPGZfLs2QJi16MU/q5cwvcJSQNTCumA4s/LhYK8/8Fb qtH3fu/Lwv/2IurAAbYKHNokwbSeUV8WUcpP+b0eVw5uzP9bFyXGWCVgoNCskkl6bet2 dR2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=eOeo+6tfLZnGpxx38iqxtu4VQhUTjg/CCMHhvycQT+g=; b=KdwVe/Nil4lRlNNbTGg5cujFHtrtUiDOVipOZp/YZNNM75krBgP3PX/yWLpfWeUZ5G tBUBU+pIz1zyzMwvtMXDUrN53TVTMO9gXihRfdq7tyf7A8Qal0jzMlI5+c85Kakfxh0j Sn5iKdQxOddrgVITezCTUQ6z9QjA/8FNxXufXGYotMhPZ2nv5smu7S/42tYx4tshKvKg DiK6inlmuWjznm8DstdrXhlqrzWku/NwvR8xYSk5wYMAQuIT7sukgcv6sVS7bwssUtKh zIcE8EOUIyy3A8Ya+Kk1wW1AiXaEl9shzwa4DsZj8uZqiC2Z7PNqyucK2ck4rPqkoGdJ e0dg== X-Gm-Message-State: ABUngvfhf+GJc1mmknhV8XXFl5DTTQJVe82GVsxGagH254W9r6G1ly5RD43n8iM38um0ww== X-Received: by 10.107.58.195 with SMTP id h186mr21234567ioa.117.1479004899353; Sat, 12 Nov 2016 18:41:39 -0800 (PST) Original-Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id r3sm6744622iod.24.2016.11.12.18.41.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 12 Nov 2016 18:41:38 -0800 (PST) In-Reply-To: (Noam Postavsky's message of "Fri, 4 Nov 2016 20:58:27 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:125651 Archived-At: tags 24873 fixed close 24873 quit Noam Postavsky writes: > On Fri, Nov 4, 2016 at 8:34 PM, Mark Oteiza wrote: >> Does the following fix it for you? >> >> diff --git a/lisp/replace.el b/lisp/replace.el >> index 4fc48d4..60948ef 100644 >> --- a/lisp/replace.el >> +++ b/lisp/replace.el >> @@ -198,7 +198,7 @@ query-replace-read-from >> (setq-local text-property-default-nonsticky >> (cons '(separator . t) text-property-default-nonsticky))) >> (if regexp-flag >> - (read-regexp prompt) >> + (read-regexp prompt nil 'minibuffer-history) > > I think you need make minibuffer-history into a dynamic variable for > this to work. Ah, minibuffer-history is defined in simple.el, so it's fine.