From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.bugs Subject: bug#25049: ibuffer bug when saving existing filter, with patches Date: Wed, 30 Nov 2016 16:02:53 +0900 Message-ID: <87d1hd8n6q.fsf@gmail.com> References: <8737ianx4s.fsf@gmail.com> <8737i9etj1.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1480489457 22943 195.159.176.226 (30 Nov 2016 07:04:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 30 Nov 2016 07:04:17 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: 25049@debbugs.gnu.org, tino.calancha@gmail.com To: Christopher Genovese Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 30 08:04:10 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cByw4-0004bZ-KG for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Nov 2016 08:04:08 +0100 Original-Received: from localhost ([::1]:41652 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cByw8-00017R-Ee for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Nov 2016 02:04:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58708) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cByw1-00017A-Q8 for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2016 02:04:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cByvy-0002uM-FB for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2016 02:04:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59702) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cByvy-0002uA-Cb for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2016 02:04:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cByvx-0000Wc-Vr for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2016 02:04:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Nov 2016 07:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25049 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25049-submit@debbugs.gnu.org id=B25049.14804893871951 (code B ref 25049); Wed, 30 Nov 2016 07:04:01 +0000 Original-Received: (at 25049) by debbugs.gnu.org; 30 Nov 2016 07:03:07 +0000 Original-Received: from localhost ([127.0.0.1]:46868 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cByv4-0000VP-SY for submit@debbugs.gnu.org; Wed, 30 Nov 2016 02:03:07 -0500 Original-Received: from mail-pg0-f46.google.com ([74.125.83.46]:33993) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cByv2-0000Uv-Vd for 25049@debbugs.gnu.org; Wed, 30 Nov 2016 02:03:05 -0500 Original-Received: by mail-pg0-f46.google.com with SMTP id x23so78937606pgx.1 for <25049@debbugs.gnu.org>; Tue, 29 Nov 2016 23:03:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=cta0RWx04r1lx4MxIRglMdhHCxRrV8HNkWsggS/eBR4=; b=BzArurPClUyc3RwhTNqL63OMBB6Og2Ung7mrIIVbaB6QLFNBI5Tpz/8xQfzWotq5lA NHtfTRSrx3ntBrDCGptlYjexa624lOgmqZd8U1x3ByFmYAxXnZZw/kIu8IpD214Hoojo 3mAdvdZHZRDJ2aouYml6uX04Hj4Psv1MonP++9N5kg6tHziiyG9qHrYtlUaZC5ifxpBo bu/ct6BYPklSr+9lWbtRQOWfP9SRc6hWr7puQF6NDC6L2nqcVQ78x3xcub/0gl19Ptv5 ioWpP/ctf8E6Q+QQWid8MXb++Vuf8YxxQ2iD7147As+LruNzNwzq40i213fpCvUV5U0U YPgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=cta0RWx04r1lx4MxIRglMdhHCxRrV8HNkWsggS/eBR4=; b=iCOaIqIouddsC87GMfmd/65NDP0bbuivkboDUx383DPpizq4OcvmeAnqg9TPHFfySO rphy/U0hAmZUT8jHzTSCZdlE9Agf4PgsT8XT2v+Lq3vIfPeRe+0VsoR9SLnMKFZCdBCw pErrsz/W4kMIZDxmpQTZqeRLmUg86ng97LSJLvz83FUhZJn4ZkG4YZ4Bsa7pl4W2GHDU qfiQjOdwv6n3FOoZEsW+CXljoTWH2Q0arCfTFh+DB5RF83XBQqVmRsA7LiXRVg7fJ5J2 0CjnqWxlbOfGXw/9LMJkgLv/zb46e6zKwUOUT+lMR9YoEF962n/xqdZTB8sOUb46x5qN UTyg== X-Gm-Message-State: AKaTC02n1g65Eu8Fw19JOfUUS0HJaPQgZgY/xHF7NUV75GqDms/EvoTAZL0Kc3DuW9RQ1Q== X-Received: by 10.98.80.9 with SMTP id e9mr31469476pfb.13.1480489378844; Tue, 29 Nov 2016 23:02:58 -0800 (PST) Original-Received: from calancha-pc (MAR89-125.kek.jp. [130.87.89.125]) by smtp.gmail.com with ESMTPSA id t184sm81978712pgt.36.2016.11.29.23.02.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 29 Nov 2016 23:02:58 -0800 (PST) In-Reply-To: (Christopher Genovese's message of "Wed, 30 Nov 2016 00:14:03 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:126290 Archived-At: Christopher Genovese writes: > I've attached a modified patch file that includes > all your suggested changes. I did some squashing > and editing, so this patch has the same three parts > as before, with properly formatted Change Logs in > each. Thank you very much fr your prompt replay! I) + 'follow-link t + 'help-echo "Click or RET: save new value in customize" + 'action (lambda (b) + (if (not (fboundp 'customize-save-variable)) + (message "Customize not available; value not saved") + (customize-save-variable 'ibuffer-saved-filters + ibuffer-saved-filters) + (message "Saved updated ibuffer-saved-filters.")))) The lambda form above doesn't use its 'b' argument, so i have dropped it. II) I see you define `ibuffer-update-saved-filters-format' right before than `ibuffer-saved-filters', because this defcustom use that function to set its default. In the other hand `ibuffer-repair-saved-filters' isn't used by any defcustom so i moved out after the variable definitions. If we don't get further comments to address in 1 week, then let's push this fix to the master branch. Thank you Tino