From: Matthew Woodcraft <matthew@woodcraft.me.uk>
To: 22661@debbugs.gnu.org, Hong Xu <hong@topbug.net>
Subject: bug#22661: 25.0.91; python.el electric-indent misbehaviour with 'else:' and nested 'if:'
Date: Sat, 21 Jan 2017 17:34:57 +0000 [thread overview]
Message-ID: <87d1fgiaf2.fsf@golux.woodcraft.me.uk> (raw)
In-Reply-To: <878trky4d9.fsf@topbug.net>
Hong Xu <hong@topbug.net> writes:
>> If I have the following code and add the colon after the 'else',
>> python.el's electric-indent moves the 'else' to align with the inner
>> 'if'.
>> def foo()
>> if aaa:
>> if bbb:
>> x = 1
>> y = 1
>> else
> I've attached a patch to fix this issue: It is caused by incorrect
> detection of opening blocks.
>
> From: Hong Xu <hong@topbug.net>
> Date: Mon, 12 Dec 2016 17:55:25 -0800
> Subject: [PATCH] python-mode: Fix detection for opening blocks (bug# 22661).
>
> * python.el (python-info-dedenter-opening-block-positions): There
> can't be any back-indented lines between an opening block and the
> current line.
I have tested this patch and it does fix the case I posted.
But it misbehaves if I add a blank line before the 'else':
def foo()
if aaa:
if bbb:
x = 1
y = 1
else
Now when I add the colon after the 'else', electric-indent moves the
'else' to align with the 'def'.
I agree that python-info-dedenter-opening-block-positions is the right
thing to fix.
I think it's sufficient to look at the last nonblank line above the
current line, rather than all lines between the candidate opening block
and the current line.
-M-
next prev parent reply other threads:[~2017-01-21 17:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-14 17:09 bug#22661: 25.0.91; python.el electric-indent misbehaviour with 'else:' and nested 'if:' Matthew Woodcraft
2016-12-13 2:01 ` Hong Xu
2017-01-21 17:34 ` Matthew Woodcraft [this message]
2017-01-22 2:08 ` Hong Xu
2017-01-22 22:34 ` Matthew Woodcraft
2017-01-22 23:08 ` npostavs
2017-01-23 0:50 ` Hong Xu
2017-01-24 1:24 ` npostavs
2017-01-27 1:20 ` npostavs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1fgiaf2.fsf@golux.woodcraft.me.uk \
--to=matthew@woodcraft.me.uk \
--cc=22661@debbugs.gnu.org \
--cc=hong@topbug.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.