* bug#26177: pcase spams me with useless and cryptic messages intended for internal use
@ 2017-03-19 21:54 Paul Pogonyshev
2017-03-25 22:47 ` bug#26177: Paul Pogonyshev
0 siblings, 1 reply; 3+ messages in thread
From: Paul Pogonyshev @ 2017-03-19 21:54 UTC (permalink / raw)
To: 26177
[-- Attachment #1: Type: text/plain, Size: 336 bytes --]
To reproduce, evaluate this:
(defmacro kek (&rest more-cases)
`(pcase it
(`foo 1)
,@more-cases))
(defun lol (x)
(--each x
(kek))
(--each x
(kek (`baz 3))))
Observe that there is "pcase-memoize: equal first branch, yet
different" gibberish in *Messages* buffer.
Attached patch comments out this debug output.
[-- Attachment #2: silence-pcase.diff --]
[-- Type: text/plain, Size: 783 bytes --]
diff --git a/lisp/emacs-lisp/pcase.el b/lisp/emacs-lisp/pcase.el
index 289265abf2..fc5474ecc4 100644
--- a/lisp/emacs-lisp/pcase.el
+++ b/lisp/emacs-lisp/pcase.el
@@ -175,8 +175,8 @@ Emacs Lisp manual for more information and examples."
;; (when (gethash (car cases) pcase--memoize-2)
;; (message "pcase-memoize failed because of eq test on %S"
;; (car cases)))
- (when data
- (message "pcase-memoize: equal first branch, yet different"))
+ ;; (when data
+ ;; (message "pcase-memoize: equal first branch, yet different"))
(let ((expansion (pcase--expand exp cases)))
(puthash (car cases) `(,exp ,cases ,@expansion) pcase--memoize)
;; (puthash (car cases) `(,exp ,cases ,@expansion) pcase--memoize-1)
^ permalink raw reply related [flat|nested] 3+ messages in thread
* bug#26177:
2017-03-19 21:54 bug#26177: pcase spams me with useless and cryptic messages intended for internal use Paul Pogonyshev
@ 2017-03-25 22:47 ` Paul Pogonyshev
2017-03-25 23:31 ` bug#26177: npostavs
0 siblings, 1 reply; 3+ messages in thread
From: Paul Pogonyshev @ 2017-03-25 22:47 UTC (permalink / raw)
To: 26177
tags: patch
thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#26177:
2017-03-25 22:47 ` bug#26177: Paul Pogonyshev
@ 2017-03-25 23:31 ` npostavs
0 siblings, 0 replies; 3+ messages in thread
From: npostavs @ 2017-03-25 23:31 UTC (permalink / raw)
To: Paul Pogonyshev; +Cc: 26177
tags 26177 fixed
close 26177 26.1
quit
Pushed to master [1: 9278d904af].
1: 2017-03-25 19:28:22 -0400 9278d904af13c3c083defdcbf5fa21260d4457c3
* lisp/emacs-lisp/pcase.el (pcase): Comment debug message (Bug#26177).
Paul Pogonyshev <pogonyshev@gmail.com> writes:
> tags: patch
>
> thanks
You need to send to control@debbugs.gnu.org and the format is a bit
different. See https://debbugs.gnu.org/server-control.html.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-25 23:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-19 21:54 bug#26177: pcase spams me with useless and cryptic messages intended for internal use Paul Pogonyshev
2017-03-25 22:47 ` bug#26177: Paul Pogonyshev
2017-03-25 23:31 ` bug#26177: npostavs
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.