From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#25936: Fix for whitespace.el to make it read tab-width and indent-tabs-mode correctly Date: Tue, 18 Apr 2017 08:06:23 -0400 Message-ID: <87d1c9syww.fsf@users.sourceforge.net> References: <874lyj4jxg.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1492517176 24248 195.159.176.226 (18 Apr 2017 12:06:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 18 Apr 2017 12:06:16 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) Cc: 25936@debbugs.gnu.org, Stephen Deasey To: Reuben Thomas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 18 14:06:08 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d0RtY-000698-Ad for geb-bug-gnu-emacs@m.gmane.org; Tue, 18 Apr 2017 14:06:08 +0200 Original-Received: from localhost ([::1]:41562 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d0Rte-0000Ij-8l for geb-bug-gnu-emacs@m.gmane.org; Tue, 18 Apr 2017 08:06:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48542) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d0RtY-0000Ic-L7 for bug-gnu-emacs@gnu.org; Tue, 18 Apr 2017 08:06:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d0RtT-000803-MC for bug-gnu-emacs@gnu.org; Tue, 18 Apr 2017 08:06:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55316) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d0RtT-0007zm-IS for bug-gnu-emacs@gnu.org; Tue, 18 Apr 2017 08:06:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d0RtS-0002oX-0b for bug-gnu-emacs@gnu.org; Tue, 18 Apr 2017 08:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Apr 2017 12:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25936 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 25936-submit@debbugs.gnu.org id=B25936.149251710310745 (code B ref 25936); Tue, 18 Apr 2017 12:06:01 +0000 Original-Received: (at 25936) by debbugs.gnu.org; 18 Apr 2017 12:05:03 +0000 Original-Received: from localhost ([127.0.0.1]:53515 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d0RsV-0002nF-3x for submit@debbugs.gnu.org; Tue, 18 Apr 2017 08:05:03 -0400 Original-Received: from mail-io0-f171.google.com ([209.85.223.171]:35661) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d0RsU-0002mj-0a for 25936@debbugs.gnu.org; Tue, 18 Apr 2017 08:05:02 -0400 Original-Received: by mail-io0-f171.google.com with SMTP id r16so184439586ioi.2 for <25936@debbugs.gnu.org>; Tue, 18 Apr 2017 05:05:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=uGPGyEuPnTz8umIPXnLzUTmynSAsS5k3t/pQX12vdQo=; b=KAijItMLTv1a0U2eEKjMdBban2sD0qDPg/EBTGOtjRWc0DcJqOJYgZgcPLvMxi9gwq M12IxpgSq9cRh6z/ZfijdAuYr8YmXlgnOo6rClkmpTjt3XkIY3CS9Lbfh88hhodibr4W 5WHWunY2r8LTKBJkgGAHRfZb+NP/hqgsjTIpU1qIBOltV0H5H0uB653vai1eYTU83e5/ SHBzXprGEwLEorDv/f5UXWNyXVNSaCWIwVLLHilDmmGJxCQCuYbm2CCCcMR65+Cw3ZEt R1MiHHbAKdBX8u52nH/FA6enFR8hln6GkZElTLybQ+5qpqBxgY4r1D1jyZ2bTlljfPQE 58Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=uGPGyEuPnTz8umIPXnLzUTmynSAsS5k3t/pQX12vdQo=; b=WatTlHZmKtYzJSs8l8qan3dm12IdHk453pICqDbgl+4NT+izbA54FSwy4M+xftsUvN Y7Zw6hepBQY9BNMk+gPxSJZ0kh/SArVrLUUpofrKu74ijf366OxeE+q71FawGfWi3ELp eWTeKuMTS3A21cwWk1EYpyj7WQhhiQDyYcQKfelFxIC0G5joSsJfxVqsWesFkJD4W4aq XafaOlFufYCBWeq22fqme5pMsHYExgQI4APwYYs7QoRxnx7v7zXJy97gAtkoWE8Mj0lC FY8ldsr1vR72dSJ9M3hFFHyeI0wsf1iQjyZWSmVpoNxw+mHRqrqiKNu9cXQV/59p/v4J BEvA== X-Gm-Message-State: AN3rC/7+W3H4j70swYed1psiYIz/OnHs39H09dmSd3cTxcIb5KBEADxn Jv/gsfc3F0LihA== X-Received: by 10.107.197.129 with SMTP id v123mr15209455iof.175.1492517096274; Tue, 18 Apr 2017 05:04:56 -0700 (PDT) Original-Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id 141sm6332264ioe.47.2017.04.18.05.04.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 18 Apr 2017 05:04:55 -0700 (PDT) In-Reply-To: <874lyj4jxg.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net's message of "Thu, 23 Mar 2017 20:06:51 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:131725 Archived-At: npostavs@users.sourceforge.net writes: > Reuben Thomas writes: > >> However, on further investigation, I can't see why these local variables >> are needed. Currently, whitespace-mode makes buffer-local copies of >> indent-tabs-mode and tab-width, with names prefixed by "whitespace-". But >> these variables are buffer-local if necessary already, and whitespace-mo= de >> never tries to change them. > > These variables seem to have been introduced in [1: 55d1cfe870]. I > agree that it looks like there is no need for them, but I'll wait > another couple weeks in case someone else has some insights. Adding > author of that commit (and the person mentioned as "suggesting" it) on > CC in case they might remember anything about it. > > 1: 2008-04-16 03:41:17 +0000 55d1cfe8703c5829bacc8d129277f1f9b33950f6 > Honor the indent-tabs-mode and tab-width setting from user. I guess they won't answer. The compiler is telling me you missed a reference of whitespace-tab-width though. whitespace.el:2095:45:Warning: reference to free variable =E2=80=98whitespace-tab-width=E2=80=99