all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ted Zlatanov <tzz@lifelogs.com>
To: emacs-devel@gnu.org
Subject: Re: [PATCH] json: Add support for encoding structs
Date: Tue, 25 Apr 2017 10:26:28 -0400	[thread overview]
Message-ID: <87d1c0pnqj.fsf@lifelogs.com> (raw)
In-Reply-To: jwvvapteb82.fsf-monnier+gmane.emacs.devel@gnu.org

On Tue, 25 Apr 2017 18:10:59 +0530 Vibhav Pant <vibhavp@gmail.com> wrote: 

VP> On Tue, Apr 25, 2017 at 4:22 AM, Davis Herring <herring@lanl.gov> wrote:
>> You could use :json "" or :json 'ignore as the special value.

VP> IIRC, the empty string is a valid JSON key (`JSON.parse(`{"":1}`)`
VP> works in JS).
VP> Symbols are also considered a valid type according to
VP> `json-encode-key'.

Maybe one way is to distinguish '(:serialize-field nil) from '() by
checking with memq for the key?

On Tue, 25 Apr 2017 17:57:22 +0530 Vibhav Pant <vibhavp@gmail.com> wrote: 

>> Finally, maybe we could also consider using the existing facility
>> :print-function (the manual says that's currently unused). But I don't
>> know the full implications of that, so maybe it's a bad suggestion.

VP> Wouldn't that restrict encoding only to JSON?, I think passing all
VP> (json) encoding through json.el would be a better design.

Yeah, it's not a great suggestion :)

Thanks for all the work.

Ted




  reply	other threads:[~2017-04-25 14:26 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-23 10:16 [PATCH] json: Add support for encoding structs Vibhav Pant
2017-04-24 13:25 ` Ted Zlatanov
2017-04-24 17:54   ` Vibhav Pant
2017-04-24 19:17     ` Ted Zlatanov
2017-04-24 21:00       ` Ted Zlatanov
2017-04-24 21:43       ` Stefan Monnier
2017-04-25 14:26         ` Ted Zlatanov [this message]
2017-04-25 16:26           ` Vibhav Pant
2017-04-25 18:12             ` Ted Zlatanov
2017-04-26 12:13           ` Stefan Monnier
2017-04-27  6:50             ` Vibhav Pant
2017-04-27 12:31               ` Stefan Monnier
2017-04-25 12:27       ` Vibhav Pant
2017-04-24 22:52     ` Davis Herring
2017-04-25 12:40       ` Vibhav Pant
2017-04-24 13:45 ` Clément Pit-Claudel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d1c0pnqj.fsf@lifelogs.com \
    --to=tzz@lifelogs.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.