all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Michael Heerdegen <michael_heerdegen@web.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 26650@debbugs.gnu.org, npostavs@users.sourceforge.net,
	tino.calancha@gmail.com
Subject: bug#26650: 26.0.50; Protect *Backtrace* from accidental killing
Date: Wed, 26 Apr 2017 12:49:11 +0200	[thread overview]
Message-ID: <87d1bz4f6g.fsf@drachen> (raw)
In-Reply-To: <838tmnpjly.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 26 Apr 2017 13:07:53 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

> > From: npostavs@users.sourceforge.net
> > Date: Tue, 25 Apr 2017 08:50:00 -0400
> > Cc: 26650@debbugs.gnu.org
> > 
> > diff --git a/lisp/emacs-lisp/debug.el b/lisp/emacs-lisp/debug.el
> > index 94b683dcb9..0aef94f1d2 100644
> > --- a/lisp/emacs-lisp/debug.el
> > +++ b/lisp/emacs-lisp/debug.el
> > @@ -753,6 +753,8 @@ debugger-mode
> >  \\{debugger-mode-map}"
> >    (setq truncate-lines t)
> >    (set-syntax-table emacs-lisp-mode-syntax-table)
> > +  (add-hook 'kill-buffer-hook
> > +            (lambda () (if (> (recursion-depth) 0) (top-level))) nil t)
>
> This will throw to top-level when _any_ buffer is killed, as long as
> we are in recursive-edit, no?  Is that a good idea?  Shouldn't this
> hook do that only for *Backtrace*?

Did you notice that the lambda is added to the buffer-local binding of
the hook?  If you did, I don't understand why this would happen.  If you
didn't, maybe a line break should be added after the lambda expression?

Michael.





      parent reply	other threads:[~2017-04-26 10:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-25 12:02 bug#26650: 26.0.50; Protect *Backtrace* from accidental killing Tino Calancha
2017-04-25 12:13 ` npostavs
2017-04-25 12:18   ` Tino Calancha
2017-04-25 12:50     ` npostavs
2017-04-25 13:02       ` Tino Calancha
2017-04-26 10:07       ` Eli Zaretskii
2017-04-26 10:36         ` Tino Calancha
2017-04-26 11:03           ` Eli Zaretskii
2017-04-26 12:52             ` npostavs
2017-04-26 13:57               ` Tino Calancha
2017-04-26 15:33               ` Eli Zaretskii
2017-05-24  0:18                 ` npostavs
2017-04-26 10:49         ` Michael Heerdegen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d1bz4f6g.fsf@drachen \
    --to=michael_heerdegen@web.de \
    --cc=26650@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=npostavs@users.sourceforge.net \
    --cc=tino.calancha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.