Segfault with make bootrap on master

Segfault with make bootrap on master

[Stephen Berman]

I just pulled from master at commit
c3ac93bb9ff8b1fe1fc32f99c725e6cc209aa6ca
and executed `make boostrap' and it segfaulted:

Dumping under the name emacs
22386272 of 33554432 static heap bytes used
96702 pure bytes used
mv -f emacs bootstrap-emacs
make -C ../lisp compile-first EMACS="../src/bootstrap-emacs"
make[3]: Entering directory '/mnt/data/steve/lib/emacs/lfs/lisp'
  ELC      /home/steve/git/emacs-master/lisp/emacs-lisp/macroexp.elc
  ELC      /home/steve/git/emacs-master/lisp/emacs-lisp/cconv.elc
  ELC      /home/steve/git/emacs-master/lisp/emacs-lisp/byte-opt.elc
  ELC      /home/steve/git/emacs-master/lisp/emacs-lisp/bytecomp.elc
  ELC      /home/steve/git/emacs-master/lisp/emacs-lisp/autoload.elc
make[3]: Leaving directory '/mnt/data/steve/lib/emacs/lfs/lisp'
make -C ../lisp autoloads EMACS="../src/bootstrap-emacs"
make[3]: Entering directory '/mnt/data/steve/lib/emacs/lfs/lisp'
make -C ../leim all EMACS="../src/bootstrap-emacs"
make[4]: Entering directory '/mnt/data/steve/lib/emacs/lfs/leim'
  GEN      /home/steve/git/emacs-master/leim/../lisp/leim/quail/CCDOSPY.el
Converting /home/steve/git/emacs-master/leim/CXTERM-DIC/CCDOSPY.tit to quail-package...
Decoding with coding system euc-china...
Processing header part...
Formatting translation rules...
  GEN      /home/steve/git/emacs-master/leim/../lisp/leim/quail/Punct.el
Converting /home/steve/git/emacs-master/leim/CXTERM-DIC/Punct.tit to quail-package...
Decoding with coding system euc-china...
Processing header part...
Fatal error 11: Segmentation fault
Backtrace:
../src/bootstrap-emacs[0x50a10d]
../src/bootstrap-emacs[0x4f046e]
../src/bootstrap-emacs[0x508259]
../src/bootstrap-emacs[0x5082c7]
../src/bootstrap-emacs[0x5082e2]
../src/bootstrap-emacs[0x5083ab]
/lib/libpthread.so.0(+0x121c0)[0x7fed5d8e91c0]
../src/bootstrap-emacs[0x47ce1f]
../src/bootstrap-emacs[0x47d07e]
../src/bootstrap-emacs[0x480739]
../src/bootstrap-emacs[0x48139e]
../src/bootstrap-emacs[0x481b2e]
../src/bootstrap-emacs[0x562db4]
../src/bootstrap-emacs[0x5658f7]
../src/bootstrap-emacs[0x562b96]
../src/bootstrap-emacs[0x5630b0]
../src/bootstrap-emacs[0x56547b]
../src/bootstrap-emacs[0x562b96]
../src/bootstrap-emacs[0x5630b0]
../src/bootstrap-emacs[0x56547b]
../src/bootstrap-emacs[0x562b96]
../src/bootstrap-emacs[0x5630b0]
../src/bootstrap-emacs[0x565c26]
../src/bootstrap-emacs[0x562b96]
../src/bootstrap-emacs[0x5630b0]
../src/bootstrap-emacs[0x5630cb]
../src/bootstrap-emacs[0x565c77]
../src/bootstrap-emacs[0x562b96]
../src/bootstrap-emacs[0x5630b0]
../src/bootstrap-emacs[0x565c26]
../src/bootstrap-emacs[0x562b96]
../src/bootstrap-emacs[0x5630b0]
../src/bootstrap-emacs[0x563496]
../src/bootstrap-emacs[0x562836]
../src/bootstrap-emacs[0x562f51]
../src/bootstrap-emacs[0x5630b0]
../src/bootstrap-emacs[0x562b96]
../src/bootstrap-emacs[0x565ced]
../src/bootstrap-emacs[0x562b96]
../src/bootstrap-emacs[0x5630b0]
../src/bootstrap-emacs[0x55722e]
...
/bin/sh: line 1: 22677 Segmentation fault      EMACSLOADPATH= '../src/bootstrap-emacs' -batch --no-site-file --no-site-lisp -l titdic-cnv -f batch-titdic-convert -dir /home/steve/git/emacs-master/leim/../lisp/leim/quail /home/steve/git/emacs-master/leim/CXTERM-DIC/Punct.tit
make[4]: *** [Makefile:106: /home/steve/git/emacs-master/leim/../lisp/leim/quail/Punct.el] Error 139
make[4]: Leaving directory '/mnt/data/steve/lib/emacs/lfs/leim'
make[3]: *** [Makefile:350: leim] Error 2
make[3]: Leaving directory '/mnt/data/steve/lib/emacs/lfs/lisp'
make[2]: *** [Makefile:730: /home/steve/git/emacs-master/lisp/loaddefs.el] Error 2
make[2]: Leaving directory '/mnt/data/steve/lib/emacs/lfs/src'
make[1]: *** [Makefile:416: src] Error 2
make[1]: Leaving directory '/mnt/data/steve/lib/emacs/lfs'
make: *** [Makefile:1099: bootstrap] Error 2

Any idea what the problem is?

Steve Berman

Re: Segfault with make bootrap on master

[Noam Postavsky]

Stephen Berman <stephen.berman@gmx.net> wrote:

>   GEN      /home/steve/git/emacs-master/leim/../lisp/leim/quail/Punct.el
> Converting /home/steve/git/emacs-master/leim/CXTERM-DIC/Punct.tit to
> quail-package...
> Decoding with coding system euc-china...
> Processing header part...
> Fatal error 11: Segmentation fault

> /bin/sh: line 1: 22677 Segmentation fault      EMACSLOADPATH=
> '../src/bootstrap-emacs' -batch --no-site-file --no-site-lisp -l titdic-cnv
> -f batch-titdic-convert -dir
> /home/steve/git/emacs-master/leim/../lisp/leim/quail
> /home/steve/git/emacs-master/leim/CXTERM-DIC/Punct.tit

I can reproduce this (use 'rm lisp/leim/quail/Punct.el' to avoid
needing a whole bootstrap).

I get:

lisp.h:1399: Emacs fatal error: assertion failed: VECTORLIKEP (a)
Fatal error 6: Aborted

Re: Segfault with make bootrap on master

[Eli Zaretskii]

> From: Noam Postavsky <npostavs@users.sourceforge.net>
> Date: Sat, 5 Aug 2017 09:11:44 -0400
> Cc: Emacs developers <emacs-devel@gnu.org>
> 
> lisp.h:1399: Emacs fatal error: assertion failed: VECTORLIKEP (a)
> Fatal error 6: Aborted

Can you show a backtrace and tell what object is 'a' in that case?

Re: Segfault with make bootrap on master

[Eli Zaretskii]

> From: Noam Postavsky <npostavs@users.sourceforge.net>
> Date: Sat, 5 Aug 2017 09:11:44 -0400
> Cc: Emacs developers <emacs-devel@gnu.org>
> 
> Stephen Berman <stephen.berman@gmx.net> wrote:
> 
> >   GEN      /home/steve/git/emacs-master/leim/../lisp/leim/quail/Punct.el
> > Converting /home/steve/git/emacs-master/leim/CXTERM-DIC/Punct.tit to
> > quail-package...
> > Decoding with coding system euc-china...
> > Processing header part...
> > Fatal error 11: Segmentation fault
> 
> > /bin/sh: line 1: 22677 Segmentation fault      EMACSLOADPATH=
> > '../src/bootstrap-emacs' -batch --no-site-file --no-site-lisp -l titdic-cnv
> > -f batch-titdic-convert -dir
> > /home/steve/git/emacs-master/leim/../lisp/leim/quail
> > /home/steve/git/emacs-master/leim/CXTERM-DIC/Punct.tit
> 
> I can reproduce this (use 'rm lisp/leim/quail/Punct.el' to avoid
> needing a whole bootstrap).
> 
> I get:
> 
> lisp.h:1399: Emacs fatal error: assertion failed: VECTORLIKEP (a)
> Fatal error 6: Aborted

Should be fixed now.

Re: Segfault with make bootrap on master

[Noam Postavsky]

[-- Attachment #1: Type: text/plain, Size: 279 bytes --]

On Sat, Aug 5, 2017 at 9:29 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>>
>> lisp.h:1399: Emacs fatal error: assertion failed: VECTORLIKEP (a)
>> Fatal error 6: Aborted
>
> Should be fixed now.

Yeah, that avoids the segfault. Attached is the backtrace from
earlier, for reference.

[-- Attachment #2: bad-charset.txt --]
[-- Type: text/plain, Size: 6677 bytes --]

lisp.h:1399: Emacs fatal error: assertion failed: VECTORLIKEP (a)

Thread 1 "emacs" hit Breakpoint 1, terminate_due_to_signal (sig=6, backtrace_limit=2147483647) at emacs.c:364
364	  signal (sig, SIG_DFL);
(gdb) bt
#0  0x000000000057d7c0 in terminate_due_to_signal (sig=6, backtrace_limit=2147483647) at emacs.c:364
#1  0x0000000000613568 in die (msg=0x74ca3c "VECTORLIKEP (a)", file=0x74c8e0 "lisp.h", line=1399) at alloc.c:7348
#2  0x0000000000577ec3 in XVECTOR (a=XIL(0)) at lisp.h:1399
#3  0x0000000000577ee5 in ASIZE (array=XIL(0)) at lisp.h:1406
#4  0x00000000004caba7 in load_charset_map_from_vector (charset=0xd8d968 <charset_table_init+54120>, vec=XIL(0), control_flag=2)
    at charset.c:561
#5  0x00000000004cb042 in load_charset (charset=0xd8d968 <charset_table_init+54120>, control_flag=2) at charset.c:645
#6  0x00000000004d04ef in encode_char (charset=0xd8d968 <charset_table_init+54120>, c=4194208) at charset.c:1758
#7  0x00000000004d1eac in char_charset (c=4194208, charset_list=XIL(0x1215493), code_return=0x0) at charset.c:1987
#8  0x00000000004d21f8 in Fsplit_char (ch=make_number(4194208)) at charset.c:2022
#9  0x000000000063a791 in funcall_subr (subr=0x9c4710 <Ssplit_char>, numargs=1, args=0x7fffffffa600) at eval.c:2815
#10 0x000000000063a2e8 in Ffuncall (nargs=2, args=0x7fffffffa5f8) at eval.c:2740
#11 0x000000000068a59f in exec_byte_code (bytestr=XIL(0x2e8dd04), vector=XIL(0x15e2c35), maxdepth=make_number(10), args_template=XIL(0), nargs=0, args=0x0) at bytecode.c:629
#12 0x000000000063b3d2 in funcall_lambda (fun=XIL(0x15e2f6d), nargs=1, arg_vector=0x15e2c35 <bss_sbrk_buffer+8208373>)
    at eval.c:3023
#13 0x000000000063a32c in Ffuncall (nargs=2, args=0x7fffffffb018) at eval.c:2742
#14 0x000000000068a59f in exec_byte_code (bytestr=XIL(0x2ee3284), vector=XIL(0x15e3c35), maxdepth=make_number(8), args_template=XIL(0), nargs=0, args=0x0) at bytecode.c:629
#15 0x000000000063b3d2 in funcall_lambda (fun=XIL(0x15dee95), nargs=2, arg_vector=0x15e3c35 <bss_sbrk_buffer+8212469>)
    at eval.c:3023
#16 0x000000000063a32c in Ffuncall (nargs=3, args=0x7fffffffb828) at eval.c:2742
#17 0x000000000068a59f in exec_byte_code (bytestr=XIL(0x2ee5564), vector=XIL(0x15e6ed5), maxdepth=make_number(6), args_template=XIL(0), nargs=0, args=0x0) at bytecode.c:629
#18 0x000000000063b3d2 in funcall_lambda (fun=XIL(0x15d4fcd), nargs=0, arg_vector=0x15e6ed5 <bss_sbrk_buffer+8225429>)
    at eval.c:3023
#19 0x000000000063a32c in Ffuncall (nargs=1, args=0x7fffffffc040) at eval.c:2742
#20 0x000000000068a59f in exec_byte_code (bytestr=XIL(0xad12ac), vector=XIL(0xad12cd), maxdepth=make_number(23), args_template=make_number(257), nargs=1, args=0x7fffffffcc28) at bytecode.c:629
#21 0x000000000063aefa in funcall_lambda (fun=XIL(0xad127d), nargs=1, arg_vector=0x7fffffffcc20) at eval.c:2941
#22 0x000000000063a32c in Ffuncall (nargs=2, args=0x7fffffffcc18) at eval.c:2742
#23 0x000000000068a59f in exec_byte_code (bytestr=XIL(0xacbbfc), vector=XIL(0xacbc1d), maxdepth=make_number(21), args_template=make_number(0), nargs=0, args=0x7fffffffda98) at bytecode.c:629
#24 0x000000000063aefa in funcall_lambda (fun=XIL(0xacbbcd), nargs=0, arg_vector=0x7fffffffda98) at eval.c:2941
#25 0x000000000063a32c in Ffuncall (nargs=1, args=0x7fffffffda90) at eval.c:2742
#26 0x000000000068a59f in exec_byte_code (bytestr=XIL(0xacae0c), vector=XIL(0xacae2d), maxdepth=make_number(12), args_template=make_number(0), nargs=0, args=0x7fffffffe310) at bytecode.c:629
#27 0x000000000063aefa in funcall_lambda (fun=XIL(0xacaddd), nargs=0, arg_vector=0x7fffffffe310) at eval.c:2941
#28 0x000000000063ab36 in apply_lambda (fun=XIL(0xacaddd), args=XIL(0), count=4) at eval.c:2877
#29 0x0000000000638dd8 in eval_sub (form=XIL(0x1491e43)) at eval.c:2261
#30 0x00000000006381f6 in Feval (form=XIL(0x1491e43), lexical=XIL(0)) at eval.c:2038
#31 0x00000000005821bd in top_level_2 () at keyboard.c:1123
#32 0x00000000006365dd in internal_condition_case (bfun=0x5821a0 <top_level_2>, handlers=XIL(0x51f0), hfun=0x581bce <cmd_error>)
    at eval.c:1319
#33 0x00000000005821fe in top_level_1 (ignore=XIL(0)) at keyboard.c:1131
#34 0x0000000000635b1a in internal_catch (tag=XIL(0xc4e0), func=0x5821bf <top_level_1>, arg=XIL(0)) at eval.c:1084
#35 0x00000000005820f8 in command_loop () at keyboard.c:1092
#36 0x00000000005816e3 in recursive_edit_1 () at keyboard.c:699
#37 0x00000000005818c2 in Frecursive_edit () at keyboard.c:770
#38 0x000000000057f54f in main (argc=11, argv=0x7fffffffe8c8) at emacs.c:1706

Lisp Backtrace:
"split-char" (0xffffa600)
"tit-process-header" (0xffffb020)
"titdic-convert" (0xffffb830)
"batch-titdic-convert" (0xffffc048)
"command-line-1" (0xffffcc20)
"command-line" (0xffffda98)
"normal-top-level" (0xffffe310)
(gdb) up 4
#4  0x00000000004caba7 in load_charset_map_from_vector (charset=0xd8d968 <charset_table_init+54120>, vec=XIL(0), control_flag=2)
    at charset.c:561
561	  int len = ASIZE (vec);
(gdb) p vec
$1 = XIL(0)
(gdb) xpr
Lisp_Symbol
$2 = (struct Lisp_Symbol *) 0xdeb240 <lispsym>
"nil"
(gdb) up 
#5  0x00000000004cb042 in load_charset (charset=0xd8d968 <charset_table_init+54120>, control_flag=2) at charset.c:645
645	    load_charset_map_from_vector (charset, map, control_flag);
(gdb) p charset
$3 = (struct charset *) 0xd8d968 <charset_table_init+54120>
(gdb) p *charset
$4 = {
  id = 165, 
  hash_index = 187, 
  dimension = 2, 
  code_space = {33, 126, 94, 94, 33, 126, 94, 8836, 0, 0, 1, 8836, 0, 0, 1}, 
  code_space_mask = 0x128f400 <bss_sbrk_buffer+4720576> "\f", 
  code_linear_p = false, 
  iso_chars_96 = false, 
  ascii_compatible_p = false, 
  supplementary_p = false, 
  compact_codes_p = true, 
  unified_p = true, 
  iso_final = -1, 
  iso_revision = -1, 
  emacs_mule_id = -1, 
  method = CHARSET_METHOD_OFFSET, 
  min_code = 8481, 
  max_code = 32382, 
  char_index_offset = 0, 
  min_char = 2596864, 
  max_char = 2605699, 
  invalid_code = 0, 
  fast_map = '\000' <repeats 141 times>, "\034", '\000' <repeats 47 times>, 
  code_offset = 2596864
}
(gdb) p map
$5 = XIL(0)
(gdb) p CHARSET_METHOD (charset)
$6 = CHARSET_METHOD_OFFSET
(gdb) info macro CHARSET_UNIFY_MAP 
Defined at /home/npostavs/src/emacs/emacs-bootstrapping/src/charset.h:326
  included at /home/npostavs/src/emacs/emacs-bootstrapping/src/charset.c:38
#define CHARSET_UNIFY_MAP(charset) (CHARSET_ATTR_UNIFY_MAP (CHARSET_ATTRIBUTES (charset)))
(gdb) p CHARSET_UNIFY_MAP (charset)
$7 = XIL(0)
(gdb) p CHARSET_ATTRIBUTES (charset)
$8 = XIL(0x129850d)
(gdb) xpr
Lisp_Vectorlike
PVEC_NORMAL_VECTOR
$9 = (struct Lisp_Vector *) 0x1298508 <bss_sbrk_buffer+4757704>
{make_number(165), XIL(0x460580), XIL(0x1294a63), XIL(0), XIL(0), XIL(0), XIL(0), XIL(0), XIL(0), XIL(0)}

Re: Segfault with make bootrap on master

[Eli Zaretskii]

> From: Noam Postavsky <npostavs@users.sourceforge.net>
> Date: Sat, 5 Aug 2017 09:33:43 -0400
> Cc: Stephen Berman <stephen.berman@gmx.net>,
> 	Emacs developers <emacs-devel@gnu.org>
> 
> Attached is the backtrace from earlier, for reference.

Thanks.

Re: Segfault with make bootrap on master

[Eli Zaretskii]

> From: Noam Postavsky <npostavs@users.sourceforge.net>
> Date: Sat, 5 Aug 2017 09:33:43 -0400
> Cc: Stephen Berman <stephen.berman@gmx.net>,
> 	Emacs developers <emacs-devel@gnu.org>
> 
> On Sat, Aug 5, 2017 at 9:29 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> >>
> >> lisp.h:1399: Emacs fatal error: assertion failed: VECTORLIKEP (a)
> >> Fatal error 6: Aborted
> >
> > Should be fixed now.
> 
> Yeah, that avoids the segfault.

OK, I found the reason why it segfaulted, and fixed it for real (I
hope).

Re: Segfault with make bootrap on master

[Noam Postavsky]

On Sat, Aug 5, 2017 at 9:48 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>
> OK, I found the reason why it segfaulted, and fixed it for real (I
> hope).

Works here.

Re: Segfault with make bootrap on master

[Eli Zaretskii]

> From: Noam Postavsky <npostavs@users.sourceforge.net>
> Date: Sat, 5 Aug 2017 09:54:11 -0400
> Cc: Stephen Berman <stephen.berman@gmx.net>,
> 	Emacs developers <emacs-devel@gnu.org>
> 
> On Sat, Aug 5, 2017 at 9:48 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> >
> > OK, I found the reason why it segfaulted, and fixed it for real (I
> > hope).
> 
> Works here.

Thanks for testing.

Re: Segfault with make bootrap on master

[Stephen Berman]

On Sat, 05 Aug 2017 17:02:11 +0300 Eli Zaretskii <eliz@gnu.org> wrote:

>> From: Noam Postavsky <npostavs@users.sourceforge.net>
>> Date: Sat, 5 Aug 2017 09:54:11 -0400
>> Cc: Stephen Berman <stephen.berman@gmx.net>,
>> 	Emacs developers <emacs-devel@gnu.org>
>> 
>> On Sat, Aug 5, 2017 at 9:48 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>> >
>> > OK, I found the reason why it segfaulted, and fixed it for real (I
>> > hope).
>> 
>> Works here.
>
> Thanks for testing.

FTR, works for me too; thanks for fixing it.

Steve Berman