From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.bugs Subject: bug#28008: 25.2; Resume kmacro definition errors C-u C-u Date: Tue, 08 Aug 2017 14:26:54 +0900 Message-ID: <87d1867hpd.fsf@calancha-pc> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1502170108 405 195.159.176.226 (8 Aug 2017 05:28:28 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 8 Aug 2017 05:28:28 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: 28008@debbugs.gnu.org To: Allen Li Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Aug 08 07:28:13 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dex3s-0007sQ-N6 for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Aug 2017 07:28:12 +0200 Original-Received: from localhost ([::1]:40832 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dex3y-0002H6-JN for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Aug 2017 01:28:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40998) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dex3n-0002Gn-DZ for bug-gnu-emacs@gnu.org; Tue, 08 Aug 2017 01:28:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dex3i-0008KJ-GP for bug-gnu-emacs@gnu.org; Tue, 08 Aug 2017 01:28:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42307) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dex3i-0008Jk-CC for bug-gnu-emacs@gnu.org; Tue, 08 Aug 2017 01:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dex3i-0000VE-1l for bug-gnu-emacs@gnu.org; Tue, 08 Aug 2017 01:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Aug 2017 05:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28008 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28008-submit@debbugs.gnu.org id=B28008.15021700281874 (code B ref 28008); Tue, 08 Aug 2017 05:28:02 +0000 Original-Received: (at 28008) by debbugs.gnu.org; 8 Aug 2017 05:27:08 +0000 Original-Received: from localhost ([127.0.0.1]:50988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dex2q-0000UA-GN for submit@debbugs.gnu.org; Tue, 08 Aug 2017 01:27:08 -0400 Original-Received: from mail-oi0-f65.google.com ([209.85.218.65]:37127) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dex2o-0000Tf-VH for 28008@debbugs.gnu.org; Tue, 08 Aug 2017 01:27:07 -0400 Original-Received: by mail-oi0-f65.google.com with SMTP id j194so2281309oib.4 for <28008@debbugs.gnu.org>; Mon, 07 Aug 2017 22:27:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=w8OwH6pbVdo3UGQc2V9eU7kflzNwel71ecyN0+cLToA=; b=gvVpz0QXbM31vN0wYH4huZUTmkFZphFr/257TeReEZYJTe2hfUA1EPgJ2EHG+Tt91t jbTK5dB79YgN3CFEsRpVH4yY9bFING7UP95jIfwdN+dUww5wA/17rVLwx/RHKrgNBQa1 vwnU7wei86Bcr2sENBi1IcqbycLsCkgxtd9nz8kXsRsQrGvu55q3oFl2Mn1jt4CDimaO KpBX5+5MN/iDIz7r/txeljG2wjxeCZFfPAm27LMZPKUBuSg7wsn8xAFpVqMyszk0s/3q ZEprKIxy3/4slgCkGGdnCcwlbIG5EpwYaGg/PPKRwtzItEi3QHqRtwydihfYXfWe/Wpf qmhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=w8OwH6pbVdo3UGQc2V9eU7kflzNwel71ecyN0+cLToA=; b=Q1brX2bC2WSNHk9xSmHCDsGBvw66i6mPMnHcN/jWHz6HwPFZiDbONeot5joEsmM0n2 QvMuC42DKMVNq9TFC5eFklq1FH32tdraWeK1YrnpbBSZ931sGL5uo73AMlLrYnaJZXAY HEu0VZAHEwyi7k1CKsCyurcVzqV5dISkbO//6J2xDdAuhD+Mdx+0sbOo3OGBkES8Rtn6 uUh8eLMxq7ycHauotTbgZ4c3Zpx+735B3UY5Vkb1oA7J0iEwi4fWnlWHP1xzUQTSBRxg TC7ZSf/YUz1QqdcEK4awLp8tdeTIJLTGB1CoszZe0MDcL1CgUOUuQZb5MAXS/04c7j5y XXfg== X-Gm-Message-State: AHYfb5ha8EuTlgPxgdc8ADN4pKkjwyz0F+hin40XVV/N41UGEDQsxQdw ILc8bTbXjm+TKg== X-Received: by 10.84.232.205 with SMTP id x13mr3382201plm.432.1502170020887; Mon, 07 Aug 2017 22:27:00 -0700 (PDT) Original-Received: from calancha-pc (170.224.128.101.dy.bbexcite.jp. [101.128.224.170]) by smtp.gmail.com with ESMTPSA id v9sm682157pgo.39.2017.08.07.22.26.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 07 Aug 2017 22:27:00 -0700 (PDT) In-Reply-To: (Allen Li's message of "Mon, 7 Aug 2017 21:10:50 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135569 Archived-At: Allen Li writes: > Reproduction: > > 1. emacs -Q > 2. F3 > 3. Type some stuff (asdfasdf) > 4. C-g > 5. C-u C-u F3 > > Expected: kmacro definition resumes > > Actual: error > > Debugger entered--Lisp error: (wrong-type-argument arrayp nil) > start-kbd-macro(t t) Thank you for the report. I) Isn't it this behavior expected? C-g ends `start-kbd-macro' before any macro has being saved; i.e., `last-kbd-macro' is nil, so we cannot append to it. You must have a saved macro to append: emacs -Q F3 (insert "a") RET F4 ; save it in `last-kbd-macro' C-u C-u F3 ; Apped to it. (insert "b") RET F4 ; Save it. F4 ; This insert "ab" in the current buffer. 2) Expected or not, i think `kmacro-start-macro' might throw an error when the user wants to append and `start-kbd-macro' is nil. --8<-----------------------------cut here---------------start------------->8--- commit 9c86eed0b015950a4ae06243c5807d9b864eb69f Author: Tino Calancha Date: Tue Aug 8 14:14:55 2017 +0900 Append kbd macro only if last-kbd-macro is non-nil * lisp/kmacro.el (kmacro-start-macro): Append only if last-kbd-macro is non-nil (Bug#28008). diff --git a/lisp/kmacro.el b/lisp/kmacro.el index 2db8061fa4..8eff7e5c2e 100644 --- a/lisp/kmacro.el +++ b/lisp/kmacro.el @@ -584,7 +584,8 @@ kmacro-start-macro kmacro-last-counter kmacro-counter kmacro-counter-format kmacro-default-counter-format kmacro-counter-format-start kmacro-default-counter-format)) - + (when (and append (null last-kbd-macro)) + (user-error "No kbd macro has been defined")) (start-kbd-macro append (and append (if kmacro-execute-before-append --8<-----------------------------cut here---------------end--------------->8--- In GNU Emacs 26.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.11) of 2017-08-08 Repository revision: c3445aed51944becb3e58f5dace8121c0021f6c7