From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Stig Brautaset <stig@brautaset.org>
Cc: emacs-org list <emacs-orgmode@gnu.org>
Subject: Re: Conditional summing in column-mode?
Date: Fri, 01 Sep 2017 23:29:11 +0200 [thread overview]
Message-ID: <87d17a2jmg.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <m2efrrjn84.fsf@brautaset.org> (Stig Brautaset's message of "Fri, 01 Sep 2017 01:07:07 +0100")
Hello,
Stig Brautaset <stig@brautaset.org> writes:
> I think I like it. So I could then do something like:
>
> (defun sb/org-collect-confirmed-days ()
> "Return `DAYS' for `CONFIRMED' entries, otherwise return 0"
> (let ((days (org-entry-get nil "DAYS"))
> (confirmed (org-entry-get nil "CONFIRMED")))
> (if (and days (string= "[X]" confirmed))
> days
> "0")))
>
> (setq org-columns-summary-types
> '(("X+" org-columns--summary-sum
> sb/org-collect-confirmed-days)))
That's the idea, expect it should take one argument, the property being
summarized.
> That seems quite elegant! I guess the COLLECT function would be called
> in `org-agenda-colview-summarize' such that the existing summary
> functions would not need to change?
No, it wouldn't. It would be called in `org-columns--compute-spec' where
`value' is bound. Actually, we could write a getter,
`org-columns--collect', which would return COLLECT, as defined in the
summary, or
(lambda (p) (org-entry-get (point) p))
Note that COLLECT function is called on a headline. Returning an empty
string means the property has no value (per `value-set' in the function
`org-columns--compute-spec').
> Though, there will then be a tight coupling between the "X+" label and
> the column name, which is not ideal. Perhaps the COLLECT function could
> (optionally?) take the column name
Indeed.
> I don't mind having a go at adding support for this,
Great. Implementation-wise, I think there is not much to do. But it
needs to be documented and tested in "test-org-colview.el".
Thank you!
Regards,
--
Nicolas Goaziou
prev parent reply other threads:[~2017-09-01 21:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-24 15:49 Conditional summing in column-mode? Stig Brautaset
2017-08-25 7:55 ` Nicolas Goaziou
2017-08-25 17:10 ` Stig Brautaset
2017-08-25 19:55 ` Nicolas Goaziou
2017-08-28 10:41 ` Stig Brautaset
2017-08-29 7:11 ` Nicolas Goaziou
2017-09-01 0:07 ` Stig Brautaset
2017-09-01 21:29 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d17a2jmg.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=stig@brautaset.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.