From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#28402: 25.2; shr.el uses shr-tag-img despite set shr-external-rendering-functions Date: Thu, 05 Oct 2017 15:52:23 +0200 Message-ID: <87d161u2g8.fsf@mouse.gnus.org> References: <83poaxrzl1.fsf@gnu.org> <20170913172232.7jwwomyfmy567nrx@odonien.localdomain> <83lglio36q.fsf@gnu.org> <20170924131050.6erv6sshvz23dlbu@odonien.localdomain> <838tgy9d18.fsf@gnu.org> <877ew9vqwv.fsf@mouse.gnus.org> <83vajtx3hu.fsf@gnu.org> <87wp49u9ki.fsf@mouse.gnus.org> <83shexwxce.fsf@gnu.org> <87lgkpu3tl.fsf@mouse.gnus.org> <83poa1wvxi.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1507213028 20779 195.159.176.226 (5 Oct 2017 14:17:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 5 Oct 2017 14:17:08 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: v.schneidermann@gmail.com, 28402@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 05 16:16:56 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e06xH-0003Sz-KC for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Oct 2017 16:16:51 +0200 Original-Received: from localhost ([::1]:40049 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e06xL-0004Cd-KC for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Oct 2017 10:16:55 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53539) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e06aH-0000MZ-IL for bug-gnu-emacs@gnu.org; Thu, 05 Oct 2017 09:53:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e06aE-0001Ng-Fh for bug-gnu-emacs@gnu.org; Thu, 05 Oct 2017 09:53:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41257) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e06aE-0001NI-Bo for bug-gnu-emacs@gnu.org; Thu, 05 Oct 2017 09:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e06aD-0000Cj-Ql for bug-gnu-emacs@gnu.org; Thu, 05 Oct 2017 09:53:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Oct 2017 13:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28402 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28402-submit@debbugs.gnu.org id=B28402.1507211563754 (code B ref 28402); Thu, 05 Oct 2017 13:53:01 +0000 Original-Received: (at 28402) by debbugs.gnu.org; 5 Oct 2017 13:52:43 +0000 Original-Received: from localhost ([127.0.0.1]:49938 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e06Zv-0000C6-EX for submit@debbugs.gnu.org; Thu, 05 Oct 2017 09:52:43 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]:42235) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e06Zt-0000By-D3 for 28402@debbugs.gnu.org; Thu, 05 Oct 2017 09:52:41 -0400 Original-Received: from cm-84.209.243.26.getinternet.no ([84.209.243.26] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1e06Zb-0002uD-Ds; Thu, 05 Oct 2017 15:52:40 +0200 In-Reply-To: <83poa1wvxi.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 05 Oct 2017 16:44:57 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:137974 Archived-At: Eli Zaretskii writes: > Yes, but is that really that significant? You sound like saying that > any non-trivial change in shr-descend should be rejected for these > reasons. Is that really so? Do we have measurements that would back > up such extreme care? No, I'm just saying that any additional features added to that function should be considered carefully (to see whether that added feature is worth the performance degradation). And I don't think we should do anything to "pretty it up" just because, if that has any performance impact at all. In a thing like shr, it's really the case of a death by a thousand cuts: Each single improvement adds a slight performance hit, and then after a couple of years you end up with something that's pretty, but completely unusable. (It's already too slow as it is.) So I protect `shr-descend' fiercely. :-) (But late, as always... Sorry for not saying this before you applied the patch; it would have been less work for all of us.) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no