From: Noam Postavsky <npostavs@users.sourceforge.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 28797@debbugs.gnu.org, kaushal.modi@gmail.com, tino.calancha@gmail.com
Subject: bug#28797: 26.0.90; Improve printing of error on catching file-error in dired
Date: Sun, 05 Nov 2017 12:20:02 -0500 [thread overview]
Message-ID: <87d14w7id9.fsf@users.sourceforge.net> (raw)
In-Reply-To: <83o9pbjh8b.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 13 Oct 2017 16:43:33 +0300")
tags 28797 fixed
close 28797 26.1
quit
Eli Zaretskii <eliz@gnu.org> writes:
>> The resulting error will look like
>>
>> file-error: Non-regular file: Is a directory, /home/kmodi/.emacs.d/foo
>>
>> It's not quite the perfect sentence envisioned on the OP, but it gets
>> all the information across, with punctuation separating the parts.
>
> OK, close enough for me.
>
>> >> condition-case-unless-debug for #2.
>> >
>> > This is quite a radical change in very old behavior, so if it is
>> > deemed a good idea, it should go to master.
>>
>> Hmm, it doesn't seem that radical to me, but I don't have a problem
>> putting it only to master, or even not doing that at all and just saying
>> the user should use debug-on-signal.
>
> It's radical because we never produce backtrace in similar cases
> anywhere else in Emacs.
>
> Let's wait to hear what others think about this part.
I've pushed just the error-message-string part to emacs-26. Setting
debug-on-signal is the documented way of getting a backtrace in this
sort of case, so I think it's good enough to just leave as is.
I think Tino's patch is probably a good idea, but it's not related to
this bug, so I'm closing it now.
[1: efd0371c23]: 2017-11-05 11:38:38 -0500
Improve dired deletion error handling (Bug#28797)
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=efd0371c23c5dd04d73980b42d7cf64bbceccb9a
prev parent reply other threads:[~2017-11-05 17:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 14:56 bug#28797: 26.0.90; Improve printing of error on catching file-error in dired Kaushal Modi
2017-10-12 15:08 ` Noam Postavsky
2017-10-13 3:16 ` Noam Postavsky
2017-10-13 8:58 ` Eli Zaretskii
2017-10-13 13:15 ` Noam Postavsky
2017-10-13 13:43 ` Eli Zaretskii
2017-10-22 16:28 ` Noam Postavsky
2017-10-24 15:41 ` Tino Calancha
2017-10-24 23:33 ` Noam Postavsky
2017-11-05 17:20 ` Noam Postavsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d14w7id9.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=28797@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=kaushal.modi@gmail.com \
--cc=tino.calancha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.