From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#29220: 26.0.90; eieio-persistent-read fail to restore saved object. Date: Tue, 28 Nov 2017 20:09:39 -0500 Message-ID: <87d141nb58.fsf@users.sourceforge.net> References: <87y3nga0lv.fsf@killashandra.ballybran.fr> <87po8s8k02.fsf@ericabrahamsen.net> <87zi7udorn.fsf@killashandra.ballybran.fr> <8760aim2a5.fsf@ericabrahamsen.net> <87375j2tzd.fsf@users.sourceforge.net> <87inecwl1v.fsf@killashandra.ballybran.fr> <87y3n81eq7.fsf@users.sourceforge.net> <87h8ts1cfp.fsf@users.sourceforge.net> <87zi7kyzcf.fsf@ericabrahamsen.net> <87efov1zzn.fsf@users.sourceforge.net> <87h8trzc6e.fsf@ericabrahamsen.net> <87bmjz0xez.fsf@users.sourceforge.net> <87zi7cpooo.fsf@killashandra.ballybran.fr> <87h8tkzgef.fsf@users.sourceforge.net> <87zi76f5hj.fsf@killashandra.ballybran.fr> <87tvxef3ne.fsf@killashandra.ballybran.fr> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1511917815 29890 195.159.176.226 (29 Nov 2017 01:10:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 29 Nov 2017 01:10:15 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: Eric Abrahamsen , 29220@debbugs.gnu.org, Stefan Monnier To: pierre.techoueyres@free.fr (Pierre =?UTF-8?Q?T=C3=A9choueyres?=) Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 29 02:10:09 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJqt6-0007En-CK for geb-bug-gnu-emacs@m.gmane.org; Wed, 29 Nov 2017 02:10:08 +0100 Original-Received: from localhost ([::1]:40768 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJqtD-0006nD-8Q for geb-bug-gnu-emacs@m.gmane.org; Tue, 28 Nov 2017 20:10:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50566) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJqt5-0006lc-Pn for bug-gnu-emacs@gnu.org; Tue, 28 Nov 2017 20:10:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eJqt0-0003c3-Qh for bug-gnu-emacs@gnu.org; Tue, 28 Nov 2017 20:10:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54910) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eJqt0-0003bl-LT for bug-gnu-emacs@gnu.org; Tue, 28 Nov 2017 20:10:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eJqt0-0002Mk-9N for bug-gnu-emacs@gnu.org; Tue, 28 Nov 2017 20:10:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Nov 2017 01:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29220 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29220-submit@debbugs.gnu.org id=B29220.15119177899068 (code B ref 29220); Wed, 29 Nov 2017 01:10:02 +0000 Original-Received: (at 29220) by debbugs.gnu.org; 29 Nov 2017 01:09:49 +0000 Original-Received: from localhost ([127.0.0.1]:35358 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJqsn-0002M9-6D for submit@debbugs.gnu.org; Tue, 28 Nov 2017 20:09:49 -0500 Original-Received: from mail-io0-f180.google.com ([209.85.223.180]:34935) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJqsl-0002Lv-DW for 29220@debbugs.gnu.org; Tue, 28 Nov 2017 20:09:47 -0500 Original-Received: by mail-io0-f180.google.com with SMTP id q15so1989609ioh.2 for <29220@debbugs.gnu.org>; Tue, 28 Nov 2017 17:09:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=ryxptad+SKUTYx0bD64fCy/OIXjH9GoDeND/HJ8ssGE=; b=DVhdshr/LQPDxOBc6tCJreBZHEWS5rS3N9MMxgRK21rnXWdZkUaRi/pszTUnJReRS2 54hzgWzdid9FOa+uZd0+8fsyH0Fzk/UsWuuREjVuLLzPdVe2BHrlM0l3tNB4d3FSfSkg eiiM9/3fIKRBLWPIvkzg/axbWP4qFzd3UgjyM0YpwFBE7ld40s91Q0o0IaB5GlwUx3GO 2cLCpWD+5IMiePigjmHMpdbQaTXo/1bJs8oosj7klhjSH22pDSK4N3D+lFbgBam226nz jd5Cw0aP0TDOa/M4013q/Ye16Muja0q+Rx18P91O+mPlF9oQWR+/63vPU9ObbTh8cTNm h55w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=ryxptad+SKUTYx0bD64fCy/OIXjH9GoDeND/HJ8ssGE=; b=lglzeuBdJh4HW8wFeRCRSrfvME5Q8faFIw2kYG2GxSZNt8QShfxMyGxq7gZ8NC9YlV J84YLN6jrinRgmBP1EjCjnKm+INw5hhx+LJxZY0N69S5r5kJS17cI5ZWi+CMpaVKcgi9 TeWH2YE2Q/cECJTsY5F7kPHS2kq7IiQCX/Jr0oaYpgdr+CQBg5zVq/rxh+qSIe00moCK +Bn009X8QK+3VnWPR0D4aLMLyGuhVxjBOOe5ZApecRs8JwTj0P/eoveFr/5UMCVYtHC3 eKXATI/NNGn6j017MDdCqU4okSHPyaaWhXu5+mxi2OFrS6XRAVavWmpNvQn9rmr1ZJnD lJkg== X-Gm-Message-State: AJaThX6OImV1zAGNho2+rjezMJQD2dx7doJeMSMxM48OXkIG45IECH6R 5xCufkxdx02xxELOIBPc3N0= X-Google-Smtp-Source: AGs4zMaCiXmhMu3qMT72KbQb69bE5J4FtFvGw1exvg1MvhzYHkDFq4pG1XSJ5oTjEc2/TWnzrN/UUg== X-Received: by 10.107.144.195 with SMTP id s186mr1553295iod.64.1511917781771; Tue, 28 Nov 2017 17:09:41 -0800 (PST) Original-Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id z19sm259600iof.53.2017.11.28.17.09.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 28 Nov 2017 17:09:40 -0800 (PST) In-Reply-To: <87tvxef3ne.fsf@killashandra.ballybran.fr> ("Pierre \=\?utf-8\?Q\?T\=C3\=A9choueyres\=22's\?\= message of "Tue, 28 Nov 2017 23:18:45 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:140516 Archived-At: pierre.techoueyres@free.fr (Pierre T=C3=A9choueyres) writes: > I try to understand how, from print_object, objects in the hash table > are print. > I expected something like > > prin1 -> print -> print_object -> something in lisp or C The sequence is prin1 -> print -> print_object -> print_vectorlike print_vectorlike calls print_object on all of the keys and values of the hashtable (see 'case PVEC_HASH_TABLE'). > I'm trying to make pcache work correctly with emacs 26. > Now I understand that eieio--class and eieio--class-tag have changed, > but I don't know if I can or how to correct the printing of objects in > order to read them back with eieio-persistent-read. I see 3 possibilities: 1. Make eieio persistent save stuff use cl-print to print the whole thing readably (this requires major additions to cl-print, currently it doesn't preserve readability except by just punting to prin1). 2. Change the class tag to something that will be easily readable, and round-trip as eq (i.e., some kind of symbol, like in Emacs 25 and earlier). 3. Change child-of-class-p to use `equal'ness instead of `eq'ness for classes. I think would require an `equal' that can handle circular objects. Looks like #2 would be the easiest to implement.