From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#30324: 26.0.91; cd-absolute to tramp directory fails Date: Fri, 02 Feb 2018 23:24:30 +0100 Message-ID: <87d11nxc69.fsf@gmx.de> References: <87o9l7mp3s.fsf@hm.sivalik.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1517610220 755 195.159.176.226 (2 Feb 2018 22:23:40 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 2 Feb 2018 22:23:40 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 30324@debbugs.gnu.org To: Rajeev Narang Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Feb 02 23:23:36 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ehjjn-00070P-J6 for geb-bug-gnu-emacs@m.gmane.org; Fri, 02 Feb 2018 23:23:15 +0100 Original-Received: from localhost ([::1]:37368 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ehjlo-00041A-Ck for geb-bug-gnu-emacs@m.gmane.org; Fri, 02 Feb 2018 17:25:20 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46178) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ehjlc-0003w0-WD for bug-gnu-emacs@gnu.org; Fri, 02 Feb 2018 17:25:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ehjlW-0003rc-RB for bug-gnu-emacs@gnu.org; Fri, 02 Feb 2018 17:25:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46769) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ehjlW-0003rP-MW for bug-gnu-emacs@gnu.org; Fri, 02 Feb 2018 17:25:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ehjlW-0000Vh-E9 for bug-gnu-emacs@gnu.org; Fri, 02 Feb 2018 17:25:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Feb 2018 22:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30324 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30324-submit@debbugs.gnu.org id=B30324.15176102891939 (code B ref 30324); Fri, 02 Feb 2018 22:25:02 +0000 Original-Received: (at 30324) by debbugs.gnu.org; 2 Feb 2018 22:24:49 +0000 Original-Received: from localhost ([127.0.0.1]:54666 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ehjlI-0000VD-QZ for submit@debbugs.gnu.org; Fri, 02 Feb 2018 17:24:48 -0500 Original-Received: from mout.gmx.net ([212.227.17.20]:39637) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ehjlH-0000V1-6L for 30324@debbugs.gnu.org; Fri, 02 Feb 2018 17:24:47 -0500 Original-Received: from detlef.gmx.de ([212.86.43.48]) by mail.gmx.com (mrgmx101 [212.227.17.168]) with ESMTPSA (Nemesis) id 0Lg5kl-1f6cFX062d-00pa2M; Fri, 02 Feb 2018 23:24:32 +0100 In-Reply-To: <87o9l7mp3s.fsf@hm.sivalik.com> (Rajeev Narang's message of "Fri, 02 Feb 2018 09:40:39 -0500") X-Provags-ID: V03:K0:7n0+oMOOw2Oix+olfUrc0y437vnfGNjk2aIfi2DVGztEN/cr6RH lRH37KVTu6QXCN6MQTaB920wUR5ZNZyolv3ME29oni7jqG4WJnW2nRqadr5IPch1FrwQ1Ky yzvwJo01xsypFnfjXcgCz3Qq1UFYHN/xpAG/qrJK6Ns9vXQ5ivV0WGGC3ghc2gvZO/4VVtW 4ZskvQmXnlLOfPsn6feAw== X-UI-Out-Filterresults: notjunk:1;V01:K0:RtTrYRlwfo8=:0ynfztBOMHz82wbaz+9S03 qvpMjJiqzdUmkfRIcvSN0KE/D7u82+nfbIFEUJVMwXOoAyDz+pBiIATxw+Z8UhYGAA3UpxRo6 X9QA83Ww/1g29/zpp/yuCQqB2z66+M94CLc1J6DN4iwSDvDkaI1mUP4joZ+R/tVxQMnnqAr/k H1ov1lhbKTXqXBFkMp0I2L7WjYlMW68EtapyvJGIZxL4bBseXPqyQXd774m/V7U7JksnGVYoT 55hr1MIMU1lKROHEqitMMysB3KpdC2QoIB/JP3UzqXWEtJDxPp1rYyQEzMLJp2dN5qkTm5/gW Oc+2YGMtRy9CY3xV0h7CrpJfT6tqc28PKYZe0xIWC+fSsWAawIuTqdSxHrC2kVmoap7NZru2i N6KEdRdNOmgReW2ZX919uKX7kzPHQ3NasCsZ5I5rdxkxYfEpYIl7FKLsh5fAMxymnuJSqglhB 5SRZdxpD/70bZGnSA7V4S509Lg4FTcQo5Cu7BcvYHaG8Dt3YxREwhzph0iW3CKONQLGgCm+Jz WPRtSUAB1tgGsYoFg7G22CRdcxbtwQq+lFS/lx18ekxlbOm31mvq2huvltvb+lgQVRt1rYAS8 jX0Jta1/ZLScQ5VS0D0wcGe8Sjeqfbt/N03LeHFkHKkhvR+I9EKLOCJoHnWj2+woQyanZxOjL AjbdJC0ei9b7sfmV4AbRLOqzoz48JwvDmMlEWIcqF7RhDhFTB0s+OJ2YY/V1rAgrZlzx1fzlV NGjBfGHAnt4uwMI7atufHakbRj7Y0/IZGBQ0gyeo3PUweH9OcruUl5auWFmjqb5UNpB+pVsB X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142822 Archived-At: --=-=-= Content-Type: text/plain Rajeev Narang writes: Hi Rajeev, > When rlogin-directory-tracking-mode is set to t, rlogin directory tracking fails. > > This is because (cd-absolute "/USER@HOST:") fails in emacs-26. The same call succeeds in emacs-25. rlogin.el still speaks about FTP access. This has worked until Emacs 25, because ange-ftp.el and tramp.el have used the same file name syntax. While ange.ftp.el uses ftp to access, Tramp has a variety of connection methods. In case of absence, the default connection method is used, often "ssh". With Emacs 26, Tramp's file name syntax has changed. A method name is mandatory now, at least "-" as indicator for the default method. The obvious simple fix is --=-=-= Content-Type: text/plain Content-Disposition: inline diff --git a/lisp/net/rlogin.el b/lisp/net/rlogin.el index 646adef2f0..3bfc4d7f35 100644 --- a/lisp/net/rlogin.el +++ b/lisp/net/rlogin.el @@ -219,7 +219,7 @@ rlogin ;; function, to avoid a gratuitous resync check; the default ;; should be the user's home directory, be it local or remote. (setq comint-file-name-prefix - (concat "/" rlogin-remote-user "@" rlogin-host ":")) + (concat "/-:" rlogin-remote-user "@" rlogin-host ":")) (cd-absolute comint-file-name-prefix)) ((null rlogin-directory-tracking-mode)) (t @@ -253,7 +253,7 @@ rlogin-directory-tracking-mode (setq rlogin-directory-tracking-mode t) (setq shell-dirtrackp t) (setq comint-file-name-prefix - (concat "/" rlogin-remote-user "@" rlogin-host ":"))) + (concat "/-:" rlogin-remote-user "@" rlogin-host ":"))) ((< prefix 0) (setq rlogin-directory-tracking-mode nil) (setq shell-dirtrackp nil)) --=-=-= Content-Type: text/plain Could you pls test it? If it works, I propose to push it to the emacs-26 branch, because the patch is very simple (we know what we're doing, don't we?), and it cures a regression from Emacs 25. Eli? Best regards, Michael. --=-=-=--