From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#30342: 25.3; xfont_draw in xfont.c does the same thing in both branches of an if statement Date: Sat, 03 Feb 2018 21:14:41 -0500 Message-ID: <87d11lfqlq.fsf@users.sourceforge.net> References: <87zi4ph7zp.fsf@erebor.i-did-not-set--mail-host-address--so-tickle-me> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1517710409 30043 195.159.176.226 (4 Feb 2018 02:13:29 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 4 Feb 2018 02:13:29 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: 30342@debbugs.gnu.org To: Daniel Brooks Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Feb 04 03:13:25 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ei9nq-0006bq-8C for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Feb 2018 03:13:10 +0100 Original-Received: from localhost ([::1]:47840 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ei9pp-0000cl-JJ for geb-bug-gnu-emacs@m.gmane.org; Sat, 03 Feb 2018 21:15:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60340) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ei9pi-0000bk-Q7 for bug-gnu-emacs@gnu.org; Sat, 03 Feb 2018 21:15:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ei9pf-0004rd-M5 for bug-gnu-emacs@gnu.org; Sat, 03 Feb 2018 21:15:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48224) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ei9pf-0004rX-II for bug-gnu-emacs@gnu.org; Sat, 03 Feb 2018 21:15:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ei9pe-0003JT-D0 for bug-gnu-emacs@gnu.org; Sat, 03 Feb 2018 21:15:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Feb 2018 02:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30342 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30342-submit@debbugs.gnu.org id=B30342.151771049212702 (code B ref 30342); Sun, 04 Feb 2018 02:15:02 +0000 Original-Received: (at 30342) by debbugs.gnu.org; 4 Feb 2018 02:14:52 +0000 Original-Received: from localhost ([127.0.0.1]:56121 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ei9pT-0003In-Jy for submit@debbugs.gnu.org; Sat, 03 Feb 2018 21:14:52 -0500 Original-Received: from mail-io0-f176.google.com ([209.85.223.176]:34959) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ei9pR-0003Ib-Tm for 30342@debbugs.gnu.org; Sat, 03 Feb 2018 21:14:50 -0500 Original-Received: by mail-io0-f176.google.com with SMTP id m11so26872791iob.2 for <30342@debbugs.gnu.org>; Sat, 03 Feb 2018 18:14:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=pV8jz1hvuqXctEAVf5e0LbnJTmMTcn92wgQkXiF4sQY=; b=AwSWHZJIssiCBH5AszqQvJVhZ2H6Aa6pYEPUJt2unrTrJJubcF54fGtMtcJQPFWcjQ R9GA4rv80da0aefj2ehSdFxKeDx8mY22PvYLlPgcH6cl6ggZSkfcmsLpMqVUjXskDdc9 Vp9rkO5bkb2d1xaCJRQ2/0nwHwF/Jsbxn4fWgqQW2jOq+1pCEWleUxOGeNYMCPDMx4eJ aNQmlgdGXZ8+1LhoH3s+nybp+tqzKHD329q1e0CjyiCaxJvONe8r0uYmZhowFgpk/1En 9v8jpAAHRdrv+lpvEdw9JIihjXF0Wgtup4a+0gNujF0IGFAwbza4lIjlUCzWVcnNyiPQ ORuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=pV8jz1hvuqXctEAVf5e0LbnJTmMTcn92wgQkXiF4sQY=; b=Q4/aSc/JY7mXSFCeU2Zm8lnIHKSgEtoWljSJr/c+2pvhPcNdkpPjMHCtYxBTn+lKug EYjutVem85mwveQw3JoP5/vwaEob3R5TYFCn5QW3sjDdXppD+aEQU4D+JkNf8Roi+NXz z8waEGjrbI+HpzdrtR1kXRKLvzqM5aZAyGhzCC7wRNkalxWxvbpXJARrBat661I0G9Ub qmEReObZYlO1SRK/v8h5G+lrDLdlS/f3vlDkr+u04Iv9Tt955QSrH+kyvc+dlHF9I1TX VUINSDyV7pza84Xg5Hyyvx/2cIDezqZAC0nY+eFhhCES18bSIreHJ2bVkwtP32zVdCi0 zcHg== X-Gm-Message-State: AKwxyteZ/CWfr4JCsCcxeRdOB5SiAYP0RH3rtSxuxweKmsQGANcpWkmN 2FKDpCM3Ynom3PjP8cl8KzzlKg== X-Google-Smtp-Source: AH8x225ByNss9BHcLsPjKNGdjZ3t7S4P6DcERZTj0/4ishpinIx+K2eRnKwU1yu63vVHHSX+IylSVQ== X-Received: by 10.107.182.67 with SMTP id g64mr42833594iof.150.1517710484132; Sat, 03 Feb 2018 18:14:44 -0800 (PST) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id l69sm3345182ioi.11.2018.02.03.18.14.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 03 Feb 2018 18:14:43 -0800 (PST) In-Reply-To: <87zi4ph7zp.fsf@erebor.i-did-not-set--mail-host-address--so-tickle-me> (Daniel Brooks's message of "Sat, 03 Feb 2018 17:13:46 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142871 Archived-At: Daniel Brooks writes: > I happened to be looking at this function and noticed that both sides of > the with_background condition do exactly the same thing; I'm sure it > gradually got so. > > http://git.savannah.gnu.org/cgit/emacs.git/tree/src/xfont.c#n1046 They don't do *exactly* the same thing, one calls XDrawString and the other XDrawImageString.