From: John Shahid <jvshahid@gmail.com>
To: 30610@debbugs.gnu.org
Subject: bug#30610: clarify linux-mode usage from Lisp
Date: Sun, 25 Feb 2018 14:55:53 -0500 [thread overview]
Message-ID: <87d10skfna.fsf@gmail.com> (raw)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0001-clarifies-linum-mode-usage-from-Lisp.patch --]
[-- Type: text/x-diff, Size: 1071 bytes --]
From 04d261f836e5b000e8f6ed9e343417feaa8bc273 Mon Sep 17 00:00:00 2001
From: John Shahid <jvshahid@gmail.com>
Date: Sun, 25 Feb 2018 14:33:00 -0500
Subject: [PATCH] clarifies linum-mode usage from Lisp
---
lisp/linum.el | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/lisp/linum.el b/lisp/linum.el
index 9df0c5d023..fa66d62bfe 100644
--- a/lisp/linum.el
+++ b/lisp/linum.el
@@ -76,8 +76,12 @@ linum-delay
(define-minor-mode linum-mode
"Toggle display of line numbers in the left margin (Linum mode).
With a prefix argument ARG, enable Linum mode if ARG is positive,
-and disable it otherwise. If called from Lisp, enable the mode
-if ARG is omitted or nil.
+and disable it otherwise.
+
+When called from Lisp, toggles the mode if the argument is
+`toggle', disables the mode if the argument is a non-positive
+integer, and enables the mode otherwise (including if the
+argument is omitted or nil or a positive integer).
Linum mode is a buffer-local minor mode."
:lighter "" ; for desktop.el
--
2.16.2
[-- Attachment #2: Type: text/plain, Size: 348 bytes --]
The attached patch fixes a bug in the docstring of linum-mode regarding
calling it from Lisp. It incorrectly state that calling the function
with no args or nil will enable the mode; this gives the impression that
any other value disables the mode, which isn't the case. The patches
copies the relevant section from define-minor-mode
cheers,
-js
next reply other threads:[~2018-02-25 19:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-25 19:55 John Shahid [this message]
2018-02-25 20:12 ` bug#30610: clarify linux-mode usage from Lisp John Shahid
2018-03-02 3:26 ` Noam Postavsky
2018-03-03 23:17 ` John Shahid
2018-03-03 23:24 ` John Shahid
2018-03-04 1:49 ` Glenn Morris
2018-03-04 2:14 ` John Shahid
2018-03-04 2:22 ` Glenn Morris
2018-03-04 17:40 ` John Shahid
2019-08-20 12:22 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d10skfna.fsf@gmail.com \
--to=jvshahid@gmail.com \
--cc=30610@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.