From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#30908: woman2-roff-buffer fails to restore set-text-properties, etc. on error Date: Thu, 26 Apr 2018 08:01:32 -0400 Message-ID: <87d0ymqiqr.fsf@gmail.com> References: <87o9jg568u.fsf@violet.siamics.net> <87bmffsjf2.fsf@gmail.com> <87fu4r5va6.fsf@violet.siamics.net> <874ll7rt2u.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1524744017 23767 195.159.176.226 (26 Apr 2018 12:00:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 26 Apr 2018 12:00:17 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: 30908@debbugs.gnu.org To: Ivan Shmakov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Apr 26 14:00:13 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fBfZM-00064d-L8 for geb-bug-gnu-emacs@m.gmane.org; Thu, 26 Apr 2018 14:00:12 +0200 Original-Received: from localhost ([::1]:41978 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fBfbT-00025L-8q for geb-bug-gnu-emacs@m.gmane.org; Thu, 26 Apr 2018 08:02:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57186) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fBfbC-00021s-JB for bug-gnu-emacs@gnu.org; Thu, 26 Apr 2018 08:02:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fBfb8-0004nk-Qe for bug-gnu-emacs@gnu.org; Thu, 26 Apr 2018 08:02:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60380) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fBfb8-0004ne-N9 for bug-gnu-emacs@gnu.org; Thu, 26 Apr 2018 08:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fBfb8-0007hA-ES for bug-gnu-emacs@gnu.org; Thu, 26 Apr 2018 08:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Apr 2018 12:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30908 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 30908-submit@debbugs.gnu.org id=B30908.152474410229552 (code B ref 30908); Thu, 26 Apr 2018 12:02:02 +0000 Original-Received: (at 30908) by debbugs.gnu.org; 26 Apr 2018 12:01:42 +0000 Original-Received: from localhost ([127.0.0.1]:40044 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fBfao-0007gV-GJ for submit@debbugs.gnu.org; Thu, 26 Apr 2018 08:01:42 -0400 Original-Received: from mail-it0-f44.google.com ([209.85.214.44]:50306) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fBfam-0007gB-HC; Thu, 26 Apr 2018 08:01:40 -0400 Original-Received: by mail-it0-f44.google.com with SMTP id p3-v6so23539408itc.0; Thu, 26 Apr 2018 05:01:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=fQFkLDOaDb9JbtEQzlrO/P0qVZI8jggQoZWrYLTA/6E=; b=EbXcDlgvc2H9hgz0xvvqTXCS+jjVh30VZNUToV6OWrcMxtVWASWBxbssiynjfaqafo yBJRcVAqZ6JYU9xlprBWCffFX0GjA9yLWwsiz7PRoPH7Zew8pHUi9/GpQ5lIDSz7dAyD AScN6ipfUbe0VfAPflfN1ltX6RcqLCNbHKLvipzR8n1t14sVGcMMBD0B/8TDaObSQiBi 6DoGQ8rjMrFhoHcc9ohIHyGT/H/A2WQNfejmxz/6bFuGRXPebixHo1S32TfC9rgVjo4J FHIqn0Pbgt1xWynMJ5SA7fQsHSliWR9+vebWciRA1HefvF1tjIdmyi3HtKTJz/kZRMdw Auqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=fQFkLDOaDb9JbtEQzlrO/P0qVZI8jggQoZWrYLTA/6E=; b=HWSPU+VndfEA77RHdmt/wDUWhdvApJisXqp0jsf8/hGZ8FvcIHCS3wtBlQQ5qsBU8C af6Ak/qg8d0kvn5OUBEA3KZi0at1Br9wk4SQmfQmUPCCqJL3WzbmkMU5nSHLXaOHzRS+ MfuPw+wElaTcctPlGASopvcy2TDUb537IDvUuCzrAEO8wtI+6s98SwQmZVrcz99uh9Mn b4QjmAdkwHTIjRBl0Y2JxUmzy6uCdyU9PL9g8U7nWgQ/ryD/qos7e8Zt5eDpIjcv7C1Q cNppKxkYafyNxTUsWSzvQKCzH4nB2CRn+tkXtNzFfe5qnZGerlm34VTrAmgAeiBmET6e qPHw== X-Gm-Message-State: ALQs6tAFGpXN0JVEJGnLKv/zljR2/RgWabqxX8xIFxsk1UPfgJdBHLfk 092s/WhXspMATyypyXYlS1nXVg== X-Google-Smtp-Source: AB8JxZqcKRxwDutNnwiwqAaEsd4U3cTOldXveT+BlqM5EiAlZ15QwpB/oMBHnFyfdQ9AfHVldelbJA== X-Received: by 2002:a24:478b:: with SMTP id t133-v6mr568350itb.145.1524744094704; Thu, 26 Apr 2018 05:01:34 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id i12-v6sm3523349iod.85.2018.04.26.05.01.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 26 Apr 2018 05:01:33 -0700 (PDT) In-Reply-To: <874ll7rt2u.fsf@gmail.com> (Noam Postavsky's message of "Fri, 23 Mar 2018 06:20:57 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:145760 Archived-At: tags 30908 fixed close 30908 27.1 quit Noam Postavsky writes: > Ivan Shmakov writes: > >> > Shouldn=E2=80=99t this rather be combined into the existing unwind-pr= otect >> > around the while? >> >> Due to the (not (eobp)) guard, I=E2=80=99ve assumed that the >> woman2-format-paragraphs call in the =E2=80=98unwind=E2=80=99 branch is= for some >> sort of fallback processing (in the case the while loop fails.) > > Hmm, looking at this again, I'm not sure. That is, it's clearly > fallback processing in case the loop ends before going through the whole > buffer. But does it also make sense as fallback processing when some > kind of error was signaled in the loop? I don't know. I've decided that it doesn't make sense to do any further processing once we've hit an error. [1: 66dbb787a2]: 2018-04-26 07:37:48 -0400 Ensure woman2-roff-buffer restores functions on error (Bug#30908) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3D66dbb787a22d4ae1= d513a3ee27e22eed395f5676