From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#31289: madx mode for emacs Date: Thu, 21 Jun 2018 20:50:52 -0400 Message-ID: <87d0wjr6dv.fsf@gmail.com> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1529628673 3394 195.159.176.226 (22 Jun 2018 00:51:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 22 Jun 2018 00:51:13 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: 31289@debbugs.gnu.org To: Oscar Blanco Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 22 02:51:09 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fWAI8-0000of-Ul for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 Jun 2018 02:51:09 +0200 Original-Received: from localhost ([::1]:58208 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWAKG-0000sn-4j for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Jun 2018 20:53:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35362) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWAJ3-0000Jg-IM for bug-gnu-emacs@gnu.org; Thu, 21 Jun 2018 20:52:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fWAJ0-0003fT-F0 for bug-gnu-emacs@gnu.org; Thu, 21 Jun 2018 20:52:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51640) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fWAJ0-0003fJ-BZ for bug-gnu-emacs@gnu.org; Thu, 21 Jun 2018 20:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fWAJ0-0002pg-2f for bug-gnu-emacs@gnu.org; Thu, 21 Jun 2018 20:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Jun 2018 00:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31289 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 31289-submit@debbugs.gnu.org id=B31289.152962866210822 (code B ref 31289); Fri, 22 Jun 2018 00:52:02 +0000 Original-Received: (at 31289) by debbugs.gnu.org; 22 Jun 2018 00:51:02 +0000 Original-Received: from localhost ([127.0.0.1]:59537 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fWAI2-0002oR-Ig for submit@debbugs.gnu.org; Thu, 21 Jun 2018 20:51:02 -0400 Original-Received: from mail-io0-f169.google.com ([209.85.223.169]:35957) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fWAI0-0002nx-Dz for 31289@debbugs.gnu.org; Thu, 21 Jun 2018 20:51:00 -0400 Original-Received: by mail-io0-f169.google.com with SMTP id k3-v6so4681488iog.3 for <31289@debbugs.gnu.org>; Thu, 21 Jun 2018 17:51:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=hEttNUVzbkLcRO0+IfWR2radcdrfb70uIgE8Pm2xCuo=; b=R+BXS2jYl1Mr14k5AXmsGRM5+rAPxYTRxrkZ9jTwl8NJBeV5fdLhxj3HSOBZXGRfVf bCjXgS49Pdg78Da3FDrislWTG2VpSX4tPbUsMXTQ6gF7eBko0+UIeH1WdTVjPGdy5i+r gEfchMc4bSUM68MFuPNpFXIbxyFwDXfBtqxxIl+cBbey+/4CH5JzCIETjkjNYjBWT4Nv ZFpb+XMmHLmOceKjJwWSsW2/kW1WFCD/tZFKjR7TBMXQnUOk4hcjmOcHU+pz4x+FE5Za G0F6xDPWqjubZsuwoIJ+OG4qV9puaD37BABLPZEgOI/lZS8BsDzvQcyIlpd0jX7JFrt7 YwUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=hEttNUVzbkLcRO0+IfWR2radcdrfb70uIgE8Pm2xCuo=; b=B0Tt0uEF9lSFlxPEO7PV641CTQyApt82i4NL9odOikFAHuHsZ/a4WBm5c2H8d6Ctk1 l2W4oVNBq98vsh0tmj/tEKReRREurjFlCWhtv4nu5DcM/rJLzHRS9kFHNNr94nYwmyPa WbYzRCa/RQ8GlWYneSM/3gvQvly4duu4SFf46FpfUEPE4I6trIecOGihvupBpmXQaWXy xuwXYyME0j/wSbwlQZwZ2QsZD8BkKu8wG1muxfZx1S/xlcw1MIgoJXc7IQM4TiaDutdA bEiDeRz1u3mTpz2LsGklc4EsKGPjUuQB9ZuJRSPKhhGAoEjEnUoGiM8mdlixBsnhqoer xEng== X-Gm-Message-State: APt69E042hh7lG9/tlAGc6XBv2cJzKEuI5Mx0hNkvXuuSzsdwzERGC6g zvHJfPapgch+0Kcvn4GZFQ9r6w== X-Google-Smtp-Source: ADUXVKJ3BV8SU0Rtk7jBIiSWpnvC/VdflLcksPD40qji3/2zMGYX6vV7kngyPfnQqiMw3koGy/gDkQ== X-Received: by 2002:a6b:2286:: with SMTP id i128-v6mr22801820ioi.289.1529628654734; Thu, 21 Jun 2018 17:50:54 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id m81-v6sm235143itm.13.2018.06.21.17.50.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Jun 2018 17:50:53 -0700 (PDT) In-Reply-To: (Oscar Blanco's message of "Fri, 27 Apr 2018 13:00:11 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147720 Archived-At: Oscar Blanco writes: > Dear emacs group, > > I attach a script that I would like you to consider for the ELPA > repository. > This script defines the mad-x mode that highlights buffers with the > "Methodical Accelerator Design" syntax, by default loaded if the file name > ends it ".madx". > ;;; madx.el --- Major mode for editing MAD-X files in Emacs > > ;; Copyright (C) 2013, 2016 Oscar BLANCO > ;; 2017, 2018 Oscar BLANCO, Istituto Nazionale di Fisica Nucleare > ;; Licensed under the EUPL, Version 1.1 This would have to be changed. I believe GNU ELPA packages must have copyright assigned to the FSF and be under GPLv3+. > ;(add-to-list 'auto-mode-alist '("\\.madx\\'" . madx-mode)) This should be uncommented and ;;;###autoloaded I guess. > (defconst madx-font-lock-warning-face-all > ;; madx-font-lock-keywords-errordef > (list > '("\\<\\(E\\(?:ALIGN\\|FCOMP\\|RROR\\)\\|SETERR\\)\\>" > . font-lock-warning-face)) > "Highlighting expressions for MAD-X mode (warning-all).") It looks like this regexp and several others are the result of regexp-opt; it's better to have the original expression in the source, e.g., `((,(regexp-opt '("EALIGN" "EFCOMP" "ERROR" "SETERR") 'words) . font-lock-builtin-face)) > ;;;###autoload > (defun madx-mode () > "Major mode for editing MAD-X script files." > (interactive) > (kill-all-local-variables) > (setq mode-name "MAD-X") > (setq major-mode 'madx-mode) I think if you use `define-derived-mode', it would reduce the need for some of the boilerplate. > ;; Set up search > (add-hook 'madx-mode-hook > (lambda () (setq case-fold-search t))) > (run-hooks 'madx-mode-hook)) Why not just plain (setq case-fold-search t) here?