From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#31951: 27.0.50; [PATCH] server-save-buffers-kill-terminal should respect save-some-buffers-default-predicate Date: Mon, 25 Jun 2018 21:53:45 -0400 Message-ID: <87d0wepb2u.fsf@gmail.com> References: <87y3f5mq07.fsf@gmail.com> <87vaa8pap5.fsf@gmail.com> <87muvklysn.fsf@gmail.com> <87r2kvq5f9.fsf@gmail.com> <8736xbm8ep.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1529977955 28930 195.159.176.226 (26 Jun 2018 01:52:35 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 26 Jun 2018 01:52:35 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: 31951@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 26 03:52:31 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXd9i-0007S8-HZ for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 Jun 2018 03:52:30 +0200 Original-Received: from localhost ([::1]:50055 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fXdBp-0003cT-Us for geb-bug-gnu-emacs@m.gmane.org; Mon, 25 Jun 2018 21:54:41 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56946) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fXdBH-0003Nw-6H for bug-gnu-emacs@gnu.org; Mon, 25 Jun 2018 21:54:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fXdBC-0007ie-98 for bug-gnu-emacs@gnu.org; Mon, 25 Jun 2018 21:54:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55836) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fXdBC-0007iW-4w for bug-gnu-emacs@gnu.org; Mon, 25 Jun 2018 21:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fXdBB-0003W0-Q1 for bug-gnu-emacs@gnu.org; Mon, 25 Jun 2018 21:54:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Jun 2018 01:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31951 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 31951-submit@debbugs.gnu.org id=B31951.152997803513500 (code B ref 31951); Tue, 26 Jun 2018 01:54:01 +0000 Original-Received: (at 31951) by debbugs.gnu.org; 26 Jun 2018 01:53:55 +0000 Original-Received: from localhost ([127.0.0.1]:35500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXdB5-0003Vf-EY for submit@debbugs.gnu.org; Mon, 25 Jun 2018 21:53:55 -0400 Original-Received: from mail-it0-f47.google.com ([209.85.214.47]:54138) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXdB3-0003VT-JZ for 31951@debbugs.gnu.org; Mon, 25 Jun 2018 21:53:53 -0400 Original-Received: by mail-it0-f47.google.com with SMTP id a195-v6so15327972itd.3 for <31951@debbugs.gnu.org>; Mon, 25 Jun 2018 18:53:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=rpLicB+bS+yVvBQPBFkj+HnV2d7WMmbbcQbxyrIlPnU=; b=q4ycEBTOHBdZrC7ZOjpvIrQ/uy6m5c21YkSFCfv8g65ElbZw9DHCxXwTKjhB3UYX0P ayHZDXpx3e3ImGA3cs/bEgd7U8qz5WJAHg2ugPpjgXEYYu4v2ruUR9eUIWthGfIilJl1 Li1Bt1kjM5+IL3A/isoeuNvjtXofRlzf5rvmRnIK5nMzv0PkQQWz10OKALoccXzQaXV7 rWld7AOUkcw0tNHMZwOpLi1xxxOIxolYFq/RhyJf4rDWklCazjSZ3zEP+FAYpmv5/E3N N5clV6blka15sFJtU7Vbj08A20XZyFGQg3cYQAZ/yQnZEse2wOoh6r73uraaUTAdweQW PN7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=rpLicB+bS+yVvBQPBFkj+HnV2d7WMmbbcQbxyrIlPnU=; b=iPdcwIU/+rJ9yjS+3ixnR3EBbwzJISWiDjgxG179mqBspfMlzWujaiQBREPjMrpL1H ox+Qwg8gNBStDUEKwIUEu0lYizH/f0oI6ukR0Ft+3LOpQnX9+xJbi20Hr+HpepJkFE8V OCBrr9J0tc9YJ6tR4pYZmup0ATCviUzv0H+x6jEJKoP8+PaooCtoVoAj6NbSMb5dYhIl FgyE8v3zyNrqpUfUJ3nbt116048oGsnVyLam4WvFgWG0uPvehwYbLGjak6m4LVpKl1h0 SCNr2kaKjdLv5Gge7OKSIfuE2z6jf8PIAXSgk9z1bFvYsEO+jTkrTSJ4qjLfzSsjWhmB cn1A== X-Gm-Message-State: APt69E2aXTqeaE4efNq0TRfsoIl05JowfYyE/xq3vfh7lEQl15KECalb GynSBrM4kGGKOyRz2kZUHErpNA== X-Google-Smtp-Source: ADUXVKJ7U8Rh1RApyuy4sQrvmozqHLGsF55s7KfL+0iLl4PawuLZ2RJ3bPmw+zGYz9woVjg7yPW8WQ== X-Received: by 2002:a24:cb83:: with SMTP id u125-v6mr2932632itg.76.1529978027942; Mon, 25 Jun 2018 18:53:47 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id k71-v6sm434410itk.2.2018.06.25.18.53.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 25 Jun 2018 18:53:47 -0700 (PDT) In-Reply-To: <8736xbm8ep.fsf@gmail.com> ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Mon, 25 Jun 2018 12:07:26 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147827 Archived-At: Jo=C3=A3o T=C3=A1vora writes: > I tried to make it terser, but couldn't. Hmm, maybe just concentrate on the save-some-buffers-default-predicate thing. I think the original comment pretty much redundantly repeats what the doc string (and the code itself) say. --- i/lisp/server.el +++ w/lisp/server.el @@ -1639,13 +1639,15 @@ server-save-buffers-kill-terminal (save-buffers-kill-emacs arg))) ((processp proc) (let ((buffers (process-get proc 'buffers))) - ;; If client is bufferless, emulate a normal Emacs exit - ;; and offer to save all buffers. Otherwise, offer to - ;; save only the buffers belonging to the client. (save-some-buffers arg (if buffers - (lambda () (memq (current-buffer) buffers)) - t)) + ;; Only files from emacsclient file list. + (lambda () (memq (current-buffer) buffers)) + ;; No emacsclient file list: don't override + ;; `save-some-buffers-default-predicate' (unless + ;; ARGS is non-nil), since we're not killing + ;; Emacs (unlike `save-buffers-kill-emacs'). + (and arg t))) (server-delete-client proc))) (t (error "Invalid client frame"))))) =20