all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: Tom Tromey <tom@tromey.com>
Cc: emacs-devel@gnu.org
Subject: Re: Return value of finished threads
Date: Sun, 22 Jul 2018 12:02:19 +0200	[thread overview]
Message-ID: <87d0vf1tck.fsf@gmx.de> (raw)
In-Reply-To: <874lgs46bn.fsf@tromey.com> (Tom Tromey's message of "Sat, 21 Jul 2018 15:39:08 -0600")

Tom Tromey <tom@tromey.com> writes:

Hi Tom,

> Michael> I'm still lost. Will you provide a respective patch, or does
> Michael> it mean I could push my patch as-it-is?
>
> I think it's already fine.

I've pushed this to master, including documentation and NEWS.

I've also added some code for signal propagation of the finished thread
to the current one. This works OK for the quit signal (see changed
threads-mutex-signal test), but this does not work for ordinary errors
(see new test threads-join-error, I've marked it as :unstable for the
time being). I guess that the handlers catch the error somehow; maybe
you could have a look on this.

For this reason, I haven't documented signal propagation yet.

I'm also uncertain whether it is desired to propagate signals via
thread-join in all use cases. Maybe we add an optional NOSIGNAL argument
to this function?

> Tom

Best regards, Michael.



  reply	other threads:[~2018-07-22 10:02 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-20 14:56 Return value of finished threads Michael Albinus
2018-07-20 15:08 ` Eli Zaretskii
2018-07-20 15:15   ` Michael Albinus
2018-07-20 16:17     ` Clément Pit-Claudel
2018-07-20 17:25       ` Eli Zaretskii
2018-07-20 16:17 ` Noam Postavsky
2018-07-20 17:31   ` Eli Zaretskii
2018-07-21  9:28     ` Michael Albinus
2018-07-20 18:14 ` Tom Tromey
2018-07-21  9:39   ` Michael Albinus
2018-07-21 13:07     ` Tom Tromey
2018-07-21 13:16       ` Michael Albinus
2018-07-21 14:19         ` Tom Tromey
2018-07-21 14:33           ` Michael Albinus
2018-07-21 18:16             ` Tom Tromey
2018-07-21 19:33               ` Michael Albinus
2018-07-21 21:39                 ` Tom Tromey
2018-07-22 10:02                   ` Michael Albinus [this message]
2018-07-21 22:49         ` Brett Gilio
2018-07-22  2:18           ` Tom Tromey
2018-07-23 18:02             ` Brett Gilio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d0vf1tck.fsf@gmx.de \
    --to=michael.albinus@gmx.de \
    --cc=emacs-devel@gnu.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.