From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alex Branham Newsgroups: gmane.emacs.bugs Subject: bug#33975: [PATCH] inhibit read-only text properties in comint-interrupt-subjob Date: Fri, 04 Jan 2019 10:35:05 -0600 Message-ID: <87d0pcfkjq.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Trace: blaine.gmane.org 1546619663 15655 195.159.176.226 (4 Jan 2019 16:34:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 4 Jan 2019 16:34:23 +0000 (UTC) User-Agent: mu4e 1.1.0; emacs 27.0.50 To: 33975@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jan 04 17:34:19 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gfSQL-0003nO-OD for geb-bug-gnu-emacs@m.gmane.org; Fri, 04 Jan 2019 17:34:17 +0100 Original-Received: from localhost ([127.0.0.1]:36782 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gfSSN-0005Nu-AN for geb-bug-gnu-emacs@m.gmane.org; Fri, 04 Jan 2019 11:36:23 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:57237) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gfSSA-0005Lf-OU for bug-gnu-emacs@gnu.org; Fri, 04 Jan 2019 11:36:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gfSS5-0000dS-EI for bug-gnu-emacs@gnu.org; Fri, 04 Jan 2019 11:36:09 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55234) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gfSS2-0000cj-T6 for bug-gnu-emacs@gnu.org; Fri, 04 Jan 2019 11:36:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gfSS2-00039D-Lu for bug-gnu-emacs@gnu.org; Fri, 04 Jan 2019 11:36:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alex Branham Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Jan 2019 16:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 33975 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.154661971612043 (code B ref -1); Fri, 04 Jan 2019 16:36:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 4 Jan 2019 16:35:16 +0000 Original-Received: from localhost ([127.0.0.1]:47023 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gfSRI-00038B-Ax for submit@debbugs.gnu.org; Fri, 04 Jan 2019 11:35:16 -0500 Original-Received: from eggsout.gnu.org ([209.51.188.92]:52030) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gfSRG-000383-Kw for submit@debbugs.gnu.org; Fri, 04 Jan 2019 11:35:15 -0500 Original-Received: from lists.gnu.org ([208.118.235.17]:41756) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gfSRF-0000DB-DN for submit@debbugs.gnu.org; Fri, 04 Jan 2019 11:35:14 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:57006) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gfSRE-0004yn-DQ for bug-gnu-emacs@gnu.org; Fri, 04 Jan 2019 11:35:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gfSRB-0000BM-4F for bug-gnu-emacs@gnu.org; Fri, 04 Jan 2019 11:35:12 -0500 Original-Received: from mail-oi1-x241.google.com ([2607:f8b0:4864:20::241]:41791) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gfSRA-0000At-TP for bug-gnu-emacs@gnu.org; Fri, 04 Jan 2019 11:35:09 -0500 Original-Received: by mail-oi1-x241.google.com with SMTP id j21so30786231oii.8 for ; Fri, 04 Jan 2019 08:35:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=user-agent:from:to:subject:date:message-id:mime-version; bh=EYT1AeHS/4tw/JuRybyB3UK8lfNqexKDPNAwZY5MVMQ=; b=hN5bb3UD5u5dtFLqGORYESReX7FjQQtWEBQ9xWSszBWfH97sSmSbF1+oj8JBiYSdZM ZrR9ydlJkeP2AzOaYxltJGaqBrAiXdlu4K8sjhYBod4I1QK6tcgesnaYYXCbybOgl3NZ Nu71GRYB5EhddId9XqbvaR4ZzStl2a4+j0QsHO9xJD1cfC2sYNJToI1Sf9P0TGPUIY3X QFSu7L0T8GE25g44W1XNi4xm4jsUm0rVUw45trp7eIH8Mb/4P809QfaQbgQ/hsavgYJ9 5A5ywcZFv9HKPz2akC4zlhrPQfe/N5GBBPeFc5EfiOhzSTBLA5lIKw2j1i1qzmTqjE3/ aL7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:user-agent:from:to:subject:date:message-id :mime-version; bh=EYT1AeHS/4tw/JuRybyB3UK8lfNqexKDPNAwZY5MVMQ=; b=h6PhyHyd7VYFtFILDLuIwtcMEgxnBILC2gDv3qUGVJTJ6vGNDTYUb71plOWjI3JzCC lr7FbKvt8FL5oSKqmitSdYaLDrTq0bEvwN4a3VdfcChkuCg6XTymG/AwbMHyXZHN8PAN ny/6nUWito14JcggwzlDbMeBPiVflM0JA4ArxuKyn+9os/klOLQYImu9sh8e2PuLy3Qz 2nRr+h27bqVlVyAv/oX/kOJLjmRFRsHRFj8w4MmuJrpAioLv+6X7OoJq7roygjxgtXvE 9K2aIKgSBK6ZOmPguOfveqfjxusaLKVDojTpPkNZ/gYSGflKZDR22jsAqu+i3S/K2+o4 NXQg== X-Gm-Message-State: AA+aEWbqj0xNsbslHhFbtv16spoPy2UvEvQdLhzL1tLWjelTVVRrIskU v77hnvYOxUeQAGA5f8NOVJbPryMf X-Google-Smtp-Source: AFSGD/VjfXyggQ7RZc+Z5/fHds80yssDhbhWddJEm4VQBh7gOL3Wg64aMSeccyYS0zhJeTzyZ3YPrw== X-Received: by 2002:aca:3b83:: with SMTP id i125mr35912903oia.53.1546619707548; Fri, 04 Jan 2019 08:35:07 -0800 (PST) Original-Received: from earth (cpe-70-114-192-208.austin.res.rr.com. [70.114.192.208]) by smtp.gmail.com with ESMTPSA id j5sm57771903otc.54.2019.01.04.08.35.06 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 04 Jan 2019 08:35:06 -0800 (PST) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:154141 Archived-At: --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi - This patch inhibits read-only properties during comint-interrupt-subjob. I ran across this while using ESS and (setq comint-prompt-read-only t). There's a little more info (including a reproducible example) on ESS's bugtracker.[1] Thanks, Alex From=208e3885c5b9747987cacd3b17b9de29975e7691e3 Mon Sep 17 00:00:00 2001 From: Alex Branham Date: Fri, 4 Jan 2019 10:28:09 -0600 Subject: [PATCH] * lisp/comint.el (comint-interrupt-subjob): Inhibit read o= nly Otherwise with comint-prompt-read-only set to t users can be incapable of interrupting running busy processes. See ESS's issue tracker for details: https://github.com/emacs-ess/ESS/issues/792 =2D-- lisp/comint.el | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lisp/comint.el b/lisp/comint.el index 0a6aff2e73..2ed65c1c1c 100644 =2D-- a/lisp/comint.el +++ b/lisp/comint.el @@ -2500,8 +2500,9 @@ comint-clear-buffer (defun comint-interrupt-subjob () "Interrupt the current subjob." (interactive) =2D (comint-skip-input) =2D (interrupt-process nil comint-ptyp) + (let ((inhibit-read-only t)) + (comint-skip-input) + (interrupt-process nil comint-ptyp)) ;; (process-send-string nil "\n") ) =2D- 2.19.2 --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-lisp-comint.el-comint-interrupt-subjob-Inhibit-read-.patch Content-Transfer-Encoding: quoted-printable From=208e3885c5b9747987cacd3b17b9de29975e7691e3 Mon Sep 17 00:00:00 2001 From: Alex Branham Date: Fri, 4 Jan 2019 10:28:09 -0600 Subject: [PATCH] * lisp/comint.el (comint-interrupt-subjob): Inhibit read o= nly Otherwise with comint-prompt-read-only set to t users can be incapable of interrupting running busy processes. See ESS's issue tracker for details: https://github.com/emacs-ess/ESS/issues/792 =2D-- lisp/comint.el | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lisp/comint.el b/lisp/comint.el index 0a6aff2e73..2ed65c1c1c 100644 =2D-- a/lisp/comint.el +++ b/lisp/comint.el @@ -2500,8 +2500,9 @@ comint-clear-buffer (defun comint-interrupt-subjob () "Interrupt the current subjob." (interactive) =2D (comint-skip-input) =2D (interrupt-process nil comint-ptyp) + (let ((inhibit-read-only t)) + (comint-skip-input) + (interrupt-process nil comint-ptyp)) ;; (process-send-string nil "\n") ) =20 =2D-=20 2.19.2 --=-=-= Content-Type: text/plain Footnotes: [1] https://github.com/emacs-ess/ESS/issues/792 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEeEJ4XAMgliXNXicpHkInolPpmscFAlwvizkACgkQHkInolPp msdsxQgAhDOpfHbPa+4kR9JgPDvPHoR7mI8hLVFZ5Xd3hij6UJ1mCCUWAsaJxGJa Kg7J5mt7/xMfG568sDUpK7Bsg42Kf3ZpsjLVXJMWsnXwJU02l29b2/eWE/7eFa+2 ITK6ZstTguvYNFU3p9tJHBvT4zBbconGAgIiU6cNmo5KCz/Hsu7hz5ca16+nmDLu lLd7XZihyZ+PbcQmYBk4uaaP1arh0KOM56JyCPHRvtG5rZck6wbSy4DsbIzc0lIG Q2oxX6h8owYsle6qYe/htdAUqr6Xo0ocsFXLyg8qz9x502mhU5R7ejDOqZVITljB MQ382KhfOAAOhza1ud7A8qoBfjOZkw== =CFeP -----END PGP SIGNATURE----- --==-=-=--