From: Alex Branham <alex.branham@gmail.com>
To: 33975@debbugs.gnu.org
Subject: bug#33975: [PATCH] inhibit read-only text properties in comint-interrupt-subjob
Date: Fri, 04 Jan 2019 10:35:05 -0600 [thread overview]
Message-ID: <87d0pcfkjq.fsf@gmail.com> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 1266 bytes --]
Hi -
This patch inhibits read-only properties during comint-interrupt-subjob.
I ran across this while using ESS and (setq comint-prompt-read-only t).
There's a little more info (including a reproducible example) on ESS's
bugtracker.[1]
Thanks,
Alex
From 8e3885c5b9747987cacd3b17b9de29975e7691e3 Mon Sep 17 00:00:00 2001
From: Alex Branham <alex.branham@gmail.com>
Date: Fri, 4 Jan 2019 10:28:09 -0600
Subject: [PATCH] * lisp/comint.el (comint-interrupt-subjob): Inhibit read only
Otherwise with comint-prompt-read-only set to t users can be incapable
of interrupting running busy processes. See ESS's issue tracker for
details: https://github.com/emacs-ess/ESS/issues/792
---
lisp/comint.el | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lisp/comint.el b/lisp/comint.el
index 0a6aff2e73..2ed65c1c1c 100644
--- a/lisp/comint.el
+++ b/lisp/comint.el
@@ -2500,8 +2500,9 @@ comint-clear-buffer
(defun comint-interrupt-subjob ()
"Interrupt the current subjob."
(interactive)
- (comint-skip-input)
- (interrupt-process nil comint-ptyp)
+ (let ((inhibit-read-only t))
+ (comint-skip-input)
+ (interrupt-process nil comint-ptyp))
;; (process-send-string nil "\n")
)
--
2.19.2
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-lisp-comint.el-comint-interrupt-subjob-Inhibit-read-.patch --]
[-- Type: text/x-patch, Size: 1004 bytes --]
From 8e3885c5b9747987cacd3b17b9de29975e7691e3 Mon Sep 17 00:00:00 2001
From: Alex Branham <alex.branham@gmail.com>
Date: Fri, 4 Jan 2019 10:28:09 -0600
Subject: [PATCH] * lisp/comint.el (comint-interrupt-subjob): Inhibit read only
Otherwise with comint-prompt-read-only set to t users can be incapable
of interrupting running busy processes. See ESS's issue tracker for
details: https://github.com/emacs-ess/ESS/issues/792
---
lisp/comint.el | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lisp/comint.el b/lisp/comint.el
index 0a6aff2e73..2ed65c1c1c 100644
--- a/lisp/comint.el
+++ b/lisp/comint.el
@@ -2500,8 +2500,9 @@ comint-clear-buffer
(defun comint-interrupt-subjob ()
"Interrupt the current subjob."
(interactive)
- (comint-skip-input)
- (interrupt-process nil comint-ptyp)
+ (let ((inhibit-read-only t))
+ (comint-skip-input)
+ (interrupt-process nil comint-ptyp))
;; (process-send-string nil "\n")
)
--
2.19.2
[-- Attachment #1.3: Type: text/plain, Size: 61 bytes --]
Footnotes:
[1] https://github.com/emacs-ess/ESS/issues/792
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next reply other threads:[~2019-01-04 16:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-04 16:35 Alex Branham [this message]
2019-02-21 16:32 ` bug#33975: [PATCH] inhibit read-only text properties in comint-interrupt-subjob Alex Branham
2019-02-22 8:37 ` Eli Zaretskii
2019-02-22 21:26 ` Alex Branham
2019-02-23 8:51 ` Eli Zaretskii
2019-02-23 13:36 ` Alex Branham
2019-02-23 17:01 ` Eli Zaretskii
2019-02-24 14:47 ` Alex Branham
2019-02-25 1:11 ` Alex Branham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0pcfkjq.fsf@gmail.com \
--to=alex.branham@gmail.com \
--cc=33975@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.