From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#34671: 27.0.50; Outdated code listings in (elisp) Example Major Modes Date: Fri, 01 Mar 2019 19:46:31 +0000 Message-ID: <87d0naml7s.fsf@tcd.ie> References: <87bm2yqyhj.fsf@tcd.ie> <877edmqy19.fsf@tcd.ie> <83imx2j3xn.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="58696"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 34671@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 01 20:47:20 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gzo7r-000F9j-NU for geb-bug-gnu-emacs@m.gmane.org; Fri, 01 Mar 2019 20:47:19 +0100 Original-Received: from localhost ([127.0.0.1]:43222 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gzo7q-00012M-NN for geb-bug-gnu-emacs@m.gmane.org; Fri, 01 Mar 2019 14:47:18 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58393) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gzo7g-00010F-Di for bug-gnu-emacs@gnu.org; Fri, 01 Mar 2019 14:47:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gzo7c-0002wn-Pq for bug-gnu-emacs@gnu.org; Fri, 01 Mar 2019 14:47:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43262) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gzo7Z-0002to-VL for bug-gnu-emacs@gnu.org; Fri, 01 Mar 2019 14:47:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gzo7Z-0003qa-LD for bug-gnu-emacs@gnu.org; Fri, 01 Mar 2019 14:47:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 Mar 2019 19:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34671 X-GNU-PR-Package: emacs Original-Received: via spool by 34671-submit@debbugs.gnu.org id=B34671.155146960714765 (code B ref 34671); Fri, 01 Mar 2019 19:47:01 +0000 Original-Received: (at 34671) by debbugs.gnu.org; 1 Mar 2019 19:46:47 +0000 Original-Received: from localhost ([127.0.0.1]:56806 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gzo7K-0003q5-In for submit@debbugs.gnu.org; Fri, 01 Mar 2019 14:46:46 -0500 Original-Received: from mail-ed1-f47.google.com ([209.85.208.47]:39782) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gzo7I-0003pq-I2 for 34671@debbugs.gnu.org; Fri, 01 Mar 2019 14:46:45 -0500 Original-Received: by mail-ed1-f47.google.com with SMTP id p27so20988108edc.6 for <34671@debbugs.gnu.org>; Fri, 01 Mar 2019 11:46:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=robUdxRMU0RKeVYbiXBS7zuXjv6EagHER+gHSW9ffzg=; b=1CUioQcLo/z+yaru+bvchxLUrFcenbVm7wwKtRiMcfjvSqiqDdiQfhdg/Gjx4/A/qf kiQMsqfL8UNPbvumkQQFsb4FKrQ+F6W6kIM+lesbzfSmk8AVh4S41SsVwTMXinS/HaAb 6QxI+blaoRJMwwZf2z8nUhuLbWzZZZqjDiNUg0lne1NCNrPzdgIKnBggJmuJzr10ioxO COlVPUVW/WPif4QzDIugUf52FgtjLoegtTnMIMig47DOMMTgRmsgOz2Tm7S0oCPkd/G3 vZR444NPvtUe7fuVfnK2BMcYFlzdXPA/jCzY1G0TEdyqAP6E4aQCTpgbleBnLW9MxhrV 41fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=robUdxRMU0RKeVYbiXBS7zuXjv6EagHER+gHSW9ffzg=; b=J9uaK5xZR5L0GfZ2DgIydDBEO0S0LjcgKWMzHCys8c5y3EWHukXhCxakeT7HoZu9wB y1kbJG6S0X9CjcYOt3pAAjUocSzZiO5Dm7ERBSp15pJC0DYicj+7gAlz7voDkz0pYfl6 WNiJuL0/iT0diz9EGqnjVrbRr8oYNocPTWStEn4E4x0HoZnyOj+zkMYLctyQhs6LWR1h 6t5GTHhWUYq6xyihYiCs8C15aVzS4r3/C//ONSCYVqYEQGrBCiXVcctSAmbTWvu2xgh/ ISFileYC0wXTUs2AHO6n8gkGAZzDASHOsnxPyiCO0NvnB55CKmdW0TOu/ytEuOPfZVgb 6TXQ== X-Gm-Message-State: APjAAAXYcXfk4Z0ofldQkC2lYulLL16CARZcVV4NXiDFhU7uWZ/uX+0B fPfShZX/oR+61rHDU9mFKU+p1g== X-Google-Smtp-Source: APXvYqwHTWu9zEUyb3lsuePfv8UZJG7ixKDmxh3Ggf24bptriN/8l7VBzupgJs+mdoqYDgXa07D/pw== X-Received: by 2002:a50:9012:: with SMTP id b18mr5618179eda.30.1551469598559; Fri, 01 Mar 2019 11:46:38 -0800 (PST) Original-Received: from localhost ([134.226.214.253]) by smtp.gmail.com with ESMTPSA id q11sm3854771ejb.39.2019.03.01.11.46.37 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 01 Mar 2019 11:46:37 -0800 (PST) In-Reply-To: <83imx2j3xn.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 1 Mar 2019 12:15:48 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:155933 Archived-At: Eli Zaretskii writes: >> The first patch reconciles the code listings in the manual with the >> current state of the corresponding libraries. > > This part is definitely OK, please push to the emacs-26 branch. Sorry, I don't have write access, so someone else will have to do that. BTW, is one expected to be a package author before it is acceptable to request write access, or is it a matter of amassing enough flight hours? >> The second patch enables lexical-binding in text-mode.el along with some >> minor aesthetic changes. > > I don't see the need for parts of this patch. Enabling > lexical-binding is OK, but it should be a separate change unrelated to > this bug report. Should I submit a new bug report for that, or message emacs-devel? > And I'm not sure I see the reason for the other changes, nor even > agree with them. In particular, please modify whitespace only where > you actually make other non-trivial changes. (Oops, looking back I accidentally mangled some Texinfo escape characters by copy-pasting.) I agree with this principle, but simply thought that a file-wide change like enabling lexical-binding was sufficient excuse for minor "cleanups" along the way. I'm sorry the proposed changes weren't clean enough. I assume the parts of the patch you're least keen on are: * lisp/textmodes/text-mode.el (text-mode-syntax-table): Align comments to comment-column. (toggle-text-mode-auto-fill): Hoist save-current-buffer out of loop. (center-region): Tiny simplification. but that you're okay with the following: * lisp/textmodes/text-mode.el: Use lexical-binding. (text-mode-map, text-mode): Refill docstring. (text-mode, paragraph-indent-minor-mode, text-mode-hook-identify): Use setq-local. (center-line): Tiny simplification. Let me know and I will send updated patch(es) to a new ticket/thread. >> The last patch fulfils an old promise in the manual to eventually forgo >> setting indent-line-function in text-mode, which is considered >> redundant. > > What if the user customizes the default values, shouldn't text-mode > reset that in the buffer where it is turned on? I can think of two reasons for keeping the reset in text-mode: 0. If text-mode breaks when indent-line-function is set to anything other than indent-relative. I'm not sure, but I don't think this is the case, as I set the variable in text-mode-hook for a while without any noticeable fallout. 1. To avoid a user-visible change of behaviour with user configurations (like mine) which change the default global value of indent-line-function. The only reason (I can think of) to remove the reset is in order to fulfil the relevant promise in the manual. Keeping the reset is clearly less risky. I don't mind either way, so long as the side-note in the manual accurately reflects future intentions. Thanks, -- Basil