From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#35141: Add a default action to erc-desktop-notifications to switch to the originating buffer Date: Fri, 05 Apr 2019 12:22:41 +0100 Message-ID: <87d0m08zni.fsf@tcd.ie> References: <87wok919ox.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="2304"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 35141@debbugs.gnu.org To: Alex Murray Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 05 13:23:24 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hCMwO-0000SS-C1 for geb-bug-gnu-emacs@m.gmane.org; Fri, 05 Apr 2019 13:23:24 +0200 Original-Received: from localhost ([127.0.0.1]:40135 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hCMwN-0006AK-5t for geb-bug-gnu-emacs@m.gmane.org; Fri, 05 Apr 2019 07:23:23 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53912) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hCMwG-0006AC-VI for bug-gnu-emacs@gnu.org; Fri, 05 Apr 2019 07:23:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hCMwE-0005BI-ST for bug-gnu-emacs@gnu.org; Fri, 05 Apr 2019 07:23:16 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59792) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hCMw2-0004rl-Q7 for bug-gnu-emacs@gnu.org; Fri, 05 Apr 2019 07:23:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hCMw2-0004vC-B2 for bug-gnu-emacs@gnu.org; Fri, 05 Apr 2019 07:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Apr 2019 11:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35141 X-GNU-PR-Package: emacs Original-Received: via spool by 35141-submit@debbugs.gnu.org id=B35141.155446337218887 (code B ref 35141); Fri, 05 Apr 2019 11:23:02 +0000 Original-Received: (at 35141) by debbugs.gnu.org; 5 Apr 2019 11:22:52 +0000 Original-Received: from localhost ([127.0.0.1]:45103 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCMvr-0004uZ-Mx for submit@debbugs.gnu.org; Fri, 05 Apr 2019 07:22:51 -0400 Original-Received: from mail-ed1-f65.google.com ([209.85.208.65]:41139) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCMvp-0004uL-GC for 35141@debbugs.gnu.org; Fri, 05 Apr 2019 07:22:50 -0400 Original-Received: by mail-ed1-f65.google.com with SMTP id u2so750189eds.8 for <35141@debbugs.gnu.org>; Fri, 05 Apr 2019 04:22:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=CDGPaTQIuwgihIg2dEw57bV4OKlFLnEY3iekta3DhyA=; b=rufOncvyQdh2qXv5Oq3KQsn62+497cb79xrKV6dBHDuH5Tc/o5aDAoAIW5Mg4E8D5o tNwuSvspU6vGsMKGX5/KNnm6WDNaGrjS23uyB9H5PEfJ+ETN3qPZZXzq+tZsU5PSBZ1C 4Pshrdg8xH7C6u1GtHOhPEdZIeL0LBLRWa4iSkST9XAyPcQ08yvsfaqZYBLKCJ6x6qBR bmi6KeuXQZQAGkEnxtmfDICVeQVNhqTLHUpe6Y+mD+vrdm1sQ3MqT8tFEdrdll7jgKOu VE9d3jK+kOEry2prcQjL+WK5YAseZB2mY+/Hx/dEVf36Dx5iabKLJvnrm3G18phg8n3x 7MyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=CDGPaTQIuwgihIg2dEw57bV4OKlFLnEY3iekta3DhyA=; b=lF/uXchRYv8NBF4+Uliw8VkchouZYs6JMvI4xo8PTAv93BWBttTCGvrCqLHUiTPIzy O3Tiz0vMw5/z0wTvkSBpRTbJQeCCm1tosVtMBpaNhznkkoq8+LStIf+hKdW4triCW0V3 k8ZGvhfHxaWAw1Ea/vEUA21NtFabdluurxSpXs2Acfkzm6g3nsQgWqp9obhKjXPtKh2P G97VFftC6dcSU4dRCcn/mBJC63Q2NLGGuToT7AHUe2L1N0G1wuutSm9fwimFHY17vpAQ /wTxFDuGRd1Mds7oDFngrpXaS1GOMEhYSRStgbcOcwcf2ckgwSY+usaFoC/FOEQ7/sNE h2SA== X-Gm-Message-State: APjAAAWzaAnRQ+uTkauDVSr/1ooZPSt6wMXsUew93jO2pvllcxfHapSj fuYQ7SoogYYDzu/yNSvIab6Ugg== X-Google-Smtp-Source: APXvYqxmdhEqT0HAfy6bHQyyOhNAzN5jjeozA1K2SZ4YmGBIA9afO1U8W6jgP5Gsz0+siqNrgeYqOg== X-Received: by 2002:a17:906:c52:: with SMTP id t18mr6834038ejf.53.1554463363674; Fri, 05 Apr 2019 04:22:43 -0700 (PDT) Original-Received: from localhost (86-41-18-45-dynamic.agg3.crz.crz-crz.eircom.net. [86.41.18.45]) by smtp.gmail.com with ESMTPSA id m20sm3032532ejz.72.2019.04.05.04.22.42 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 05 Apr 2019 04:22:42 -0700 (PDT) In-Reply-To: (Alex Murray's message of "Fri, 5 Apr 2019 13:52:10 +1030") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157215 Archived-At: Alex Murray writes: > Thanks for the review - see attached for an updated version based on your= feedback. I just tried byte-compiling the patched file and got the following warning: ELC erc/erc-desktop-notifications.elc In toplevel form: erc/erc-desktop-notifications.el:74:1: Warning: Unused lexical argument =E2=80=98proc=E2=80=99 Since this arises because of lexical-binding, could you please also add an underscore to the name of the PROC argument in erc-notifications-PRIVMSG? Otherwise LGTM, but we'll have to wait a few days to give others a chance to comment. Thanks, --=20 Basil