From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Alex Murray <murray.alex@gmail.com>
Cc: 35141@debbugs.gnu.org
Subject: bug#35141: Add a default action to erc-desktop-notifications to switch to the originating buffer
Date: Fri, 05 Apr 2019 12:22:41 +0100 [thread overview]
Message-ID: <87d0m08zni.fsf@tcd.ie> (raw)
In-Reply-To: <CAA6Afg690fAdsHGqs18wwDkDcDTE68DS8fGYqQ7xMBnpwW9-ng@mail.gmail.com> (Alex Murray's message of "Fri, 5 Apr 2019 13:52:10 +1030")
Alex Murray <murray.alex@gmail.com> writes:
> Thanks for the review - see attached for an updated version based on your feedback.
I just tried byte-compiling the patched file and got the following
warning:
ELC erc/erc-desktop-notifications.elc
In toplevel form:
erc/erc-desktop-notifications.el:74:1:
Warning: Unused lexical argument ‘proc’
Since this arises because of lexical-binding, could you please also add
an underscore to the name of the PROC argument in
erc-notifications-PRIVMSG?
Otherwise LGTM, but we'll have to wait a few days to give others a
chance to comment.
Thanks,
--
Basil
next prev parent reply other threads:[~2019-04-05 11:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 6:32 bug#35141: Add a default action to erc-desktop-notifications to switch to the originating buffer Alex Murray
2019-04-05 2:13 ` Basil L. Contovounesios
2019-04-05 3:22 ` Alex Murray
2019-04-05 11:22 ` Basil L. Contovounesios [this message]
2019-04-06 9:52 ` Alex Murray
2019-04-12 12:16 ` Basil L. Contovounesios
2019-04-14 12:17 ` Alex Murray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0m08zni.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=35141@debbugs.gnu.org \
--cc=murray.alex@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.