all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: 35233@debbugs.gnu.org
Cc: Eric Abrahamsen <eric@ericabrahamsen.net>,
	Katsumi Yamaoka <yamaoka@jpl.org>
Subject: bug#35233: 27.0.50; Error in gnus-group-describe-all-groups
Date: Thu, 11 Apr 2019 17:54:25 +0100	[thread overview]
Message-ID: <87d0ls32ke.fsf@tcd.ie> (raw)

The recent move to hash-tables[1] introduced the following regression:

0. HOME=$(mktemp -d) emacs -Q
1. (setq gnus-select-method '(nntp "news.gwene.org")) C-j
2. M-x gnus RET s M-d
   Wrong number of arguments: #<subr sort>, 1

Passing string-lessp to sort further leads to the following:

3. Steps 0-2 as above.
   Wrong type argument: vectorp, #s(hash-table ...)

Replacing (intern group gnus-description-hashtb) with just group, and
repeating steps 0-2 as above, reveals that
gnus-group-describe-all-groups inserts the group name twice, rather than
the group name followed by its description.  This regression predates
the move to hash-tables[2].

[1: c1b63af445]: Change Gnus hash tables into real hash tables
  2019-03-22 10:23:30 -0700
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=c1b63af4458e92bad33da0def2b15c206656e2fa

[2: 3982245371]: Sort groups before inserting them into the group buffer
  2016-02-13 18:45:11 +1100
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3982245371c0b8e17b4d96d16ed4b1d87c0ffc25

Patch fixing these to follow.

-- 
Basil

Gnus v5.13
In GNU Emacs 27.0.50 (build 9, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2019-04-11 built on thunk
Repository revision: 0627a8d7bc6ffa29d7a503fd36e760778ecb9fa1
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12003000
System Description: Debian GNU/Linux buster/sid





             reply	other threads:[~2019-04-11 16:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-11 16:54 Basil L. Contovounesios [this message]
2019-04-11 16:59 ` bug#35233: 27.0.50; Error in gnus-group-describe-all-groups Basil L. Contovounesios
2019-04-11 17:57 ` Eric Abrahamsen
2019-04-11 20:02   ` Basil L. Contovounesios
2019-04-11 20:42     ` Eric Abrahamsen
2019-04-14  1:11       ` Basil L. Contovounesios

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d0ls32ke.fsf@tcd.ie \
    --to=contovob@tcd.ie \
    --cc=35233@debbugs.gnu.org \
    --cc=eric@ericabrahamsen.net \
    --cc=yamaoka@jpl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.