From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#35383: 27.0.50; Complete process of decoding Gnus group names Date: Sun, 28 Apr 2019 21:05:40 -0700 Message-ID: <87d0l5ihgr.fsf@ericabrahamsen.net> References: <878sw1995f.fsf@ericabrahamsen.net> <87sgu87ayo.fsf@ericabrahamsen.net> <87k1fj49o2.fsf@ericabrahamsen.net> <87bm0uhxqy.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="150570"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 35383@debbugs.gnu.org To: Katsumi Yamaoka Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 29 06:06:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hKxYQ-000d1f-VM for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 Apr 2019 06:06:11 +0200 Original-Received: from localhost ([127.0.0.1]:51679 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hKxYQ-000890-0H for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 Apr 2019 00:06:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33611) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hKxYJ-00088t-RU for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2019 00:06:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hKxYI-0002lr-Gh for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2019 00:06:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52889) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hKxYI-0002lU-CR for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2019 00:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hKxYI-0003RK-1g for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2019 00:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Apr 2019 04:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35383 X-GNU-PR-Package: emacs Original-Received: via spool by 35383-submit@debbugs.gnu.org id=B35383.155651075613211 (code B ref 35383); Mon, 29 Apr 2019 04:06:01 +0000 Original-Received: (at 35383) by debbugs.gnu.org; 29 Apr 2019 04:05:56 +0000 Original-Received: from localhost ([127.0.0.1]:38199 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hKxYC-0003R1-Ac for submit@debbugs.gnu.org; Mon, 29 Apr 2019 00:05:56 -0400 Original-Received: from ericabrahamsen.net ([52.70.2.18]:59124 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hKxY9-0003Qi-Cn for 35383@debbugs.gnu.org; Mon, 29 Apr 2019 00:05:54 -0400 Original-Received: from localhost (97-113-61-17.tukw.qwest.net [97.113.61.17]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id E5CEDFA027; Mon, 29 Apr 2019 04:05:46 +0000 (UTC) In-Reply-To: (Katsumi Yamaoka's message of "Fri, 26 Apr 2019 14:21:11 +0900") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158413 Archived-At: Katsumi Yamaoka writes: > On Thu, 25 Apr 2019 09:10:13 -0700, Eric Abrahamsen wrote: >> On 04/25/19 08:48 AM, Katsumi Yamaoka wrote: > >>> Warning: Warning - invalid active: > >>> for the nnnil method, that is my `gnus-select-method'. Here are >>> the contents of ~/News/agent/nnnil/agent.lib/active: > >>> --8<---------------cut here---------------start------------->8--- >>> ;; -*- encoding: utf-8-emacs; -*- > >>> --8<---------------cut here---------------end--------------->8--- > >>> Why the warning is issued is to run (read (current-buffer)) at >>> the beginning of the contents. This is actually an error but >>> `condition-case' conceals it. > >> Hmm, this is all done in a temp buffer, > > Yes. When launching Gnus, the whole contents of the active file > are read into the " *nntpd*" buffer, copied into the temp buffer, > and parsed (see the flow summary attatched in the bottom of this > message for how Gnus behaves when launching). > >> with >> `insert-buffer-substring' -- I wonder if the encoding cookie will even >> be honored in this case? > > No, it's useless of course. Moreover, --- I changed my idea > (patching the `gnus-active-to-gnus-format' function so as to > ignore the coding cookie) --- I come to think that the active > file should not contain the ones other than the active infos. > Gnus indeed ignores the coding cookie when parsing active, but > it is due to just a lucky side effect of `read': > > (read ";; coding cookie\n\nactive_info\n") => active_info > > I.e., `read' ignores comments in the ELisp style and whitespace. > However, in the first place, the active file is neither an ELisp > file nor there is no agreement for a comment style in it. So, I > think it is better to bind `coding-system-for-(read|write)' while > reading and writing the active file rather than adding a coding > cookie. Though binding `coding-system-for-(read|write)' would > probably be unnecessary since `gnus-write-active-file' binds > `coding-system-for-write' to `nnmail-active-file-coding-system', > and `gnus-agent-save-active' binds `coding-system-for-read' to > `gnus-agent-file-coding-system' that defaults to `utf-8-emacs'. > Therefore, adding a coding cookie was originally unnecessary, > wasn't it? > > Here are how Gnus reads the active file for the nnnil method > observed in my system. Note that `gnus-agent' is t (the default). > > (gnus 1) > [...] > (gnus-setup-news nil t nil) > (gnus-get-unread-articles 1 nil) > (require 'gnus-agent) > (with-current-buffer " *nntpd*" > (gnus-read-active-file-1 '(nnnil) nil) > (gnus-active-to-gnus-format '(nnnil) hashtb nil t) > (gnus-agent-save-active '(nnil)) > (gnus-agent-write-active "active-file" hashtb) > ;; Add a coding cookie. > (gnus-write-active-file "active-file" hashtb nil) > (erase-buffer) > (nnheader-insert-file-contents "active-file") > (_copy to_ " *nntpd*") > (_parse it_) Hang on, let me slow down here. The goal is to have Gnus default to writing its active files in 'utf-8-emacs, unless the user has specifically requested otherwise. `nnmail-active-file-coding-system' governs the "mail" type servers, and `gnus-agent-file-coding-system' governs the agent. Currently those two options default to 'raw-text, we'd like them to default to 'utf-8-emacs. But the active files have to be read correctly, as well, even by a user who is loading this new code for the first time. That was my original idea for the coding cookie, though obviously I was confused. Both those options are used as the value of `coding-system-for-read' when reading active files. So far I don't have a good solution for "upgrading" old active files to 'utf-8. I also realized that there's a `nnmbox-active-file-coding-system' that defaults to 'binary. What I find a little perplexing is that, testing with emacs 26, an nnml active file with multibyte group names gets written to a file that my terminal recognizes as utf-8, despite the fact that `nnmail-save-active' sets 'coding-system-for-write' to 'raw-text, and disables multibyte. But maybe, as Eli mentioned, that has to do with my locale...? > P.S. > I'll be not so active in the net for about ten days because of > the national holidays assoc with the era name changing in Japan. Hope it's a happy time in Japan! I'm in no rush over here. Eric