From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#35695: 27.0.50; Faces diff-added and diff-removed look the same in a 256 color terminal Date: Tue, 14 May 2019 23:06:18 +0300 Organization: LINKOV.NET Message-ID: <87d0kkzv4d.fsf@mail.linkov.net> References: <83woiwb58x.fsf@gnu.org> <83v9ygb4dm.fsf@gnu.org> <877eavwkin.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="183393"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 35695@debbugs.gnu.org To: Anders Lindgren Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 14 22:37:43 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hQeBD-000lRl-8N for geb-bug-gnu-emacs@m.gmane.org; Tue, 14 May 2019 22:37:43 +0200 Original-Received: from localhost ([127.0.0.1]:53859 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQeBC-0004lK-7E for geb-bug-gnu-emacs@m.gmane.org; Tue, 14 May 2019 16:37:42 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35879) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQeAa-0004Sk-F6 for bug-gnu-emacs@gnu.org; Tue, 14 May 2019 16:37:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hQeAZ-0002d3-GM for bug-gnu-emacs@gnu.org; Tue, 14 May 2019 16:37:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36438) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hQeAZ-0002bl-DD for bug-gnu-emacs@gnu.org; Tue, 14 May 2019 16:37:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hQeAZ-0004iY-9r for bug-gnu-emacs@gnu.org; Tue, 14 May 2019 16:37:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 May 2019 20:37:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35695 X-GNU-PR-Package: emacs Original-Received: via spool by 35695-submit@debbugs.gnu.org id=B35695.155786617118008 (code B ref 35695); Tue, 14 May 2019 20:37:03 +0000 Original-Received: (at 35695) by debbugs.gnu.org; 14 May 2019 20:36:11 +0000 Original-Received: from localhost ([127.0.0.1]:49970 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQe9j-0004gN-4G for submit@debbugs.gnu.org; Tue, 14 May 2019 16:36:11 -0400 Original-Received: from catfish.maple.relay.mailchannels.net ([23.83.214.32]:31357) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQe9f-0004gB-4r for 35695@debbugs.gnu.org; Tue, 14 May 2019 16:36:09 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 7BF21142608; Tue, 14 May 2019 20:36:05 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a88.g.dreamhost.com (100-96-6-25.trex.outbound.svc.cluster.local [100.96.6.25]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 951C41423DD; Tue, 14 May 2019 20:36:01 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a88.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Tue, 14 May 2019 20:36:05 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Attack-Relation: 14e19d62256cad5c_1557866165313_3475148093 X-MC-Loop-Signature: 1557866165313:426172065 X-MC-Ingress-Time: 1557866165312 Original-Received: from pdx1-sub0-mail-a88.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a88.g.dreamhost.com (Postfix) with ESMTP id B46F0806C0; Tue, 14 May 2019 13:36:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=FRPpFIPxCwagpxmEs1fMlWD20VA=; b= QSvf7GSgcm2RnuzXHUAl9/9IldyILrIckwJxzMhyPSsUQlGPbbVN3YyeIaOd05W5 cesiIPw4U23LWyuWilcSDsNtsaR9/fFxeOr2EWZokFWUTt9QakN939N3LF9al3XG 1XfHIB/Sqn9K3SW69AxKVgku1VTe+gyDFJSVW3E1KWE= Original-Received: from mail.jurta.org (m91-129-96-230.cust.tele2.ee [91.129.96.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a88.g.dreamhost.com (Postfix) with ESMTPSA id BF4B7806BC; Tue, 14 May 2019 13:35:58 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a88 In-Reply-To: (Anders Lindgren's message of "Mon, 13 May 2019 22:45:59 +0200") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduuddrleeigdduhedvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrdeliedrvdeftdenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrdeliedrvdeftddprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegrnhgulhhinhgusehgmhgrihhlrdgtohhmnecuvehluhhsthgvrhfuihiivgeptd X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159290 Archived-At: >> Thanks, diff-refine-added needs old values for 288 colors as well. > > I didn't include it since the output looked good with the new value. > However, for consistency, we should probably add one for it as well. > > Should I include a comment describing why we need to treat 256 color > displays differently? Yes, comments are preferable because we don't have deffaces with more than 88 min-colors anywhere else.