From: Juri Linkov <juri@linkov.net>
To: Anders Lindgren <andlind@gmail.com>
Cc: 35695@debbugs.gnu.org
Subject: bug#35695: 27.0.50; Faces diff-added and diff-removed look the same in a 256 color terminal
Date: Tue, 14 May 2019 23:06:18 +0300 [thread overview]
Message-ID: <87d0kkzv4d.fsf@mail.linkov.net> (raw)
In-Reply-To: <CABr8ebaUaKytBeWO3txkyc-88r1cAHRQRVDJ=-obXFxviUh53w@mail.gmail.com> (Anders Lindgren's message of "Mon, 13 May 2019 22:45:59 +0200")
>> Thanks, diff-refine-added needs old values for 288 colors as well.
>
> I didn't include it since the output looked good with the new value.
> However, for consistency, we should probably add one for it as well.
>
> Should I include a comment describing why we need to treat 256 color
> displays differently?
Yes, comments are preferable because we don't have deffaces
with more than 88 min-colors anywhere else.
next prev parent reply other threads:[~2019-05-14 20:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-12 5:03 bug#35695: 27.0.50; Faces diff-added and diff-removed look the same in a 256 color terminal Anders Lindgren
2019-05-12 5:39 ` Eli Zaretskii
2019-05-12 5:58 ` Eli Zaretskii
2019-05-12 18:48 ` Anders Lindgren
2019-05-12 19:24 ` Juri Linkov
2019-05-13 20:45 ` Anders Lindgren
2019-05-14 20:06 ` Juri Linkov [this message]
2019-05-15 19:10 ` Anders Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0kkzv4d.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=35695@debbugs.gnu.org \
--cc=andlind@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.