From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Simplify Gnus buffer liveness checking and killing Date: Mon, 20 May 2019 12:51:04 +0100 Message-ID: <87d0kdl4yf.fsf@tcd.ie> References: <87ef4uq92p.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="173478"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 20 13:51:21 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hSgp4-000iwh-Sw for ged-emacs-devel@m.gmane.org; Mon, 20 May 2019 13:51:19 +0200 Original-Received: from localhost ([127.0.0.1]:33982 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSgp3-00077f-6v for ged-emacs-devel@m.gmane.org; Mon, 20 May 2019 07:51:17 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:56296) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSgow-00077N-1w for emacs-devel@gnu.org; Mon, 20 May 2019 07:51:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hSgou-0006Sq-Hf for emacs-devel@gnu.org; Mon, 20 May 2019 07:51:10 -0400 Original-Received: from mail-ed1-x542.google.com ([2a00:1450:4864:20::542]:42925) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hSgou-0006SB-2Q for emacs-devel@gnu.org; Mon, 20 May 2019 07:51:08 -0400 Original-Received: by mail-ed1-x542.google.com with SMTP id l25so23394115eda.9 for ; Mon, 20 May 2019 04:51:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=GMWQxNVxSthY+lt8D3H/jID7cdKKn2MjZygUjEYmvpA=; b=ygwG0J/RW3wLJ12Ne/m6lMAgnODErpqjkYF6NFfeA+I9C0SnnPeTuXqBmg5HPDEGPG dPIxyb4nmo9FdqR56SWgaPrDEPtgotsnwO7YsyzYAJQV5ZQI+Dd/eWKDXSzY1irCwiK8 gNl+GOqYPVo9TzXjwwYcmcCcMiCNhtBqB/1gcgcQ76SwFBllGMpQPz5y34eV/gMRQi+B 95GRP3TawBLaaGrCzUletRut6dRdxdubGHAuaIaGokpCFk+Ld3nrmR0m0GSPC0STGkAb t0c8OgxK2g3CEj9ko893BM4sZ04Owcb3miYZqFgXH0uGT6H/64e3aVo8kivIzE4xcRVu cvsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=GMWQxNVxSthY+lt8D3H/jID7cdKKn2MjZygUjEYmvpA=; b=bDK3zbbb9nyR0u7CJ3REJd0wKyQI7GTZJUqJPIBchXDeLhs+5ztNJynQssLvFG+Y4E lQ4pYfwn+n3f+7Qt6TyXuVOyGU1QfbxyFszhLXPgwTmCS7qasWQvybg+Lj1o3mrMW5Lk p/0ELxdpFFXpWPSkCySc6fAhHPgwo/67O8EBng1K7M5rlkg5RTNkHFWJpEDoga3RKoxh 2q+6pkOCD8f/AVUDIyTCHjhibYL7XXrxV9EbxW2EbdVH/9YbonwoRXgfsFW8HHNA2lk+ KjIPYoWPnRhIvJVTaNXhse74ttWJsKrajz0F031BaNW9in0tG1Fd6jbfFiWVbVCQN4YF Xl+g== X-Gm-Message-State: APjAAAXxg+yR5xLPOiVs95noBJkkq7NBvC9FdP89TU3c+LJawiPwPJqL +sAdPY+CMR8/El5SyvYEDSibyAl0xnM= X-Google-Smtp-Source: APXvYqyKaJya5P4mawGnwLkmzGBQfGjLkWlEt13g8fydyLlReQmgwhfIp2uP0NjiEkArad2poShsrg== X-Received: by 2002:a50:9858:: with SMTP id h24mr27550333edb.147.1558353066685; Mon, 20 May 2019 04:51:06 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:6fa:38d6:1fce:ddb3]) by smtp.gmail.com with ESMTPSA id p17sm5437101edr.94.2019.05.20.04.51.05 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 20 May 2019 04:51:05 -0700 (PDT) In-Reply-To: (Lars Ingebrigtsen's message of "Mon, 20 May 2019 12:51:46 +0200") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::542 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236783 Archived-At: Lars Ingebrigtsen writes: > "Basil L. Contovounesios" writes: > >> The attached patch removes gnus-buffer-exists-p in favour of a modified >> gnus-buffer-live-p, aliases gnus-prune-buffers to a simplified >> gnus-buffers, and simplifies several call sites pertaining to buffer >> liveness checking and killing. WDYT? > > The patch included a lot of stuff that didn't seem to have anything to > do with buffer liveness and checking... I assume you're referring to the following changes: > * lisp/gnus/gnus-agent.el (gnus-agent-synchronize-group-flags): > Fix indentation. > * lisp/gnus/gnus-win.el (gnus-delete-windows-in-gnusey-frames) > (gnus-remove-some-windows): Simplify. If so, I can commit them separately (assuming they're welcome). If not, I would be grateful for elaboration on which parts of the patch you're not okay with. Thanks, -- Basil