From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#35770: [PATCH] Broken duplicate case elimination in switch byte-compilation Date: Wed, 22 May 2019 07:21:12 -0400 Message-ID: <87d0kaag5z.fsf@gmail.com> References: <91DFE4D0-BDB6-4365-BA51-A2A3F209177C@acm.org> <752237291204505cd6b3fb98f667c2718fa6361f.camel@acm.org> <7C514C39-A204-44F4-A806-0B7DC3F4E6B4@acm.org> <83sgt67o2x.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="198327"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: Stefan Monnier , vibhavp@gmail.com, 35770@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 22 13:22:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hTPK0-000pSd-S8 for geb-bug-gnu-emacs@m.gmane.org; Wed, 22 May 2019 13:22:13 +0200 Original-Received: from localhost ([127.0.0.1]:40478 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTPJz-0005Fx-Ij for geb-bug-gnu-emacs@m.gmane.org; Wed, 22 May 2019 07:22:11 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38381) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTPJs-0005Ff-K1 for bug-gnu-emacs@gnu.org; Wed, 22 May 2019 07:22:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hTPJr-0001iP-P1 for bug-gnu-emacs@gnu.org; Wed, 22 May 2019 07:22:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56330) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hTPJq-0001fr-5J for bug-gnu-emacs@gnu.org; Wed, 22 May 2019 07:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hTPJp-0006Zx-S6 for bug-gnu-emacs@gnu.org; Wed, 22 May 2019 07:22:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 May 2019 11:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35770 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35770-submit@debbugs.gnu.org id=B35770.155852408325222 (code B ref 35770); Wed, 22 May 2019 11:22:01 +0000 Original-Received: (at 35770) by debbugs.gnu.org; 22 May 2019 11:21:23 +0000 Original-Received: from localhost ([127.0.0.1]:41641 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTPJD-0006Yk-4d for submit@debbugs.gnu.org; Wed, 22 May 2019 07:21:23 -0400 Original-Received: from mail-it1-f179.google.com ([209.85.166.179]:53309) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTPJB-0006YX-M3 for 35770@debbugs.gnu.org; Wed, 22 May 2019 07:21:22 -0400 Original-Received: by mail-it1-f179.google.com with SMTP id m141so2839480ita.3 for <35770@debbugs.gnu.org>; Wed, 22 May 2019 04:21:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=TnbJ/FDRwwjoWI2VAfT40OIFjn9S2XxhVcxjxYxWmeI=; b=rDpdgGS+WNfgHk8czo0XEBrmTtznRbkaMwowErLI8DsddCwO6KdwxQcP+cMF41OQHl cqwp6FOFhX+rJYC68i0fELOOsDTDFWCdBRNqcr5pG5lEDMBOgLZHNd6awc9G7DQp32Nj txCwJqNWaDQnRlsjonuc+hJWUKmkpdytY/AzQYMTY5DwKBFuA6GypaOmtrO6otI3vUcH jFMVVGNOpxdFO71kMFrkGAVRpwc3uecUnXbylSBA+eoB8DWshcUMBQgJjXMVKa/ocny/ 9iXpfYjSXQTb3Nm3XrDy9ihwvsh9RTagWiPZ8YXiL+ybbA9iHGfympgKUoTeyw6xbyFJ WnNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=TnbJ/FDRwwjoWI2VAfT40OIFjn9S2XxhVcxjxYxWmeI=; b=YKu3Zo0tOeHCAMuwf1loP/bldAT+RGtf7Qu0lib8qdScwl/6H/1LdeAxqJNy7bbxVp 1CQBwQrnC3hhI2mmFNF+gXX+mr2TN01yFl9ByS5YEyP48/LjlljaTbm5RoYffEx7DYOe 7bbVqnyxKIXrY8OL7q7yb+6I9iCkCQ2kj8X0OPIHw5KgZAGh4nn4veXXhxBIp61kJ97o gqp0MNmfpGwJQ1e9p8Ecn5o6KRCqt0S7YkDoiXfA7yTH39ur1JUaE+bynOJE2cuoB/vi iqGwJvLjqhVs3fKOBfHc5tuQZOo6UjEfwby7/egU0y2gRPKgXE3JHK5Cy7GFw/ywjjal AIew== X-Gm-Message-State: APjAAAUL34ILk9ZjqR0WykGcamAdIVCL8C606FQJgNCHwz3hIH21bwkz sSA2BorTjnMZf3GtsfW9XMZsmFc2 X-Google-Smtp-Source: APXvYqyZdLyR1ig1RseYhs0PsQK/W+gxwXOu5/8arOIgks7DLNSJebNMpViy9coyp1C0nooh5gdyyQ== X-Received: by 2002:a24:4569:: with SMTP id y102mr7653791ita.51.1558524073776; Wed, 22 May 2019 04:21:13 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id l136sm3893639itc.23.2019.05.22.04.21.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 22 May 2019 04:21:13 -0700 (PDT) In-Reply-To: ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Wed, 22 May 2019 13:11:19 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159646 Archived-At: Mattias Engdeg=C3=A5rd writes: > 22 maj 2019 kl. 12.58 skrev Eli Zaretskii : >>=20 >> However, in this case I really wonder why we should be so eager to >> install the change on the emacs-26 branch. How long this wrong code >> has been with us? > > About two years, and it only matters for (arguably) buggy code, so you ar= e probably right. I think the significant milestone is that it's been with us since 26.1, i.e., this is a regression since Emacs 25. > On the other hand, different behaviour in compiled and interpreted > code does not make it easier to find such bugs. Another option is turning off byte-compile-cond-use-jump-table by default.