From: Noam Postavsky <npostavs@gmail.com>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>,
vibhavp@gmail.com, 35770@debbugs.gnu.org
Subject: bug#35770: [PATCH] Broken duplicate case elimination in switch byte-compilation
Date: Wed, 22 May 2019 07:21:12 -0400 [thread overview]
Message-ID: <87d0kaag5z.fsf@gmail.com> (raw)
In-Reply-To: <FCE9FA17-5CFE-49D0-83A8-3C32B7FA4B9F@acm.org> ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Wed, 22 May 2019 13:11:19 +0200")
Mattias Engdegård <mattiase@acm.org> writes:
> 22 maj 2019 kl. 12.58 skrev Eli Zaretskii <eliz@gnu.org>:
>>
>> However, in this case I really wonder why we should be so eager to
>> install the change on the emacs-26 branch. How long this wrong code
>> has been with us?
>
> About two years, and it only matters for (arguably) buggy code, so you are probably right.
I think the significant milestone is that it's been with us since 26.1,
i.e., this is a regression since Emacs 25.
> On the other hand, different behaviour in compiled and interpreted
> code does not make it easier to find such bugs.
Another option is turning off byte-compile-cond-use-jump-table by
default.
next prev parent reply other threads:[~2019-05-22 11:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 9:33 bug#35770: [PATCH] Broken duplicate case elimination in switch byte-compilation Mattias Engdegård
2019-05-17 12:16 ` Stefan Monnier
2019-05-17 14:48 ` Mattias Engdegård
2019-05-22 10:52 ` Mattias Engdegård
2019-05-22 10:58 ` Eli Zaretskii
2019-05-22 11:11 ` Mattias Engdegård
2019-05-22 11:21 ` Noam Postavsky [this message]
2019-05-22 11:23 ` Eli Zaretskii
2019-05-22 14:19 ` Stefan Monnier
2019-05-26 17:05 ` Mattias Engdegård
2019-05-26 18:43 ` Eli Zaretskii
2019-05-26 22:06 ` Stefan Monnier
2019-05-27 11:27 ` Mattias Engdegård
2019-06-01 13:58 ` Noam Postavsky
2019-06-01 15:47 ` Eli Zaretskii
2019-06-01 21:53 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0kaag5z.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=35770@debbugs.gnu.org \
--cc=mattiase@acm.org \
--cc=monnier@iro.umontreal.ca \
--cc=vibhavp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.