From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Damien Cassou Newsgroups: gmane.emacs.bugs Subject: bug#36024: 26.2.50; [PATCH] Fix oauth2 to pass a type parameter when requesting authorization Date: Fri, 31 May 2019 14:17:15 +0200 Message-ID: <87d0jyrf78.fsf@cassou.me> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="4802"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Julien Danjou , =?UTF-8?Q?R=C3=BCdiger?= Sonderfeld To: 36024@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri May 31 14:30:24 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hWgfv-00015m-GY for geb-bug-gnu-emacs@m.gmane.org; Fri, 31 May 2019 14:30:23 +0200 Original-Received: from localhost ([127.0.0.1]:42691 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWgfu-0002cD-BV for geb-bug-gnu-emacs@m.gmane.org; Fri, 31 May 2019 08:30:22 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48517) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWgfh-0002aA-SW for bug-gnu-emacs@gnu.org; Fri, 31 May 2019 08:30:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hWgfe-0001Lz-Tj for bug-gnu-emacs@gnu.org; Fri, 31 May 2019 08:30:09 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49680) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hWgfb-0001Jx-8h for bug-gnu-emacs@gnu.org; Fri, 31 May 2019 08:30:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hWgfb-0001Ic-3E for bug-gnu-emacs@gnu.org; Fri, 31 May 2019 08:30:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Damien Cassou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 31 May 2019 12:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 36024 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.15593057864913 (code B ref -1); Fri, 31 May 2019 12:30:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 31 May 2019 12:29:46 +0000 Original-Received: from localhost ([127.0.0.1]:34989 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hWgfK-0001HA-C7 for submit@debbugs.gnu.org; Fri, 31 May 2019 08:29:46 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33930) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hWgfF-0001Gh-C4 for submit@debbugs.gnu.org; Fri, 31 May 2019 08:29:45 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:60592) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hWgfA-0000vm-7R for submit@debbugs.gnu.org; Fri, 31 May 2019 08:29:36 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47879) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWgf8-0002Dj-MF for bug-gnu-emacs@gnu.org; Fri, 31 May 2019 08:29:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hWgTR-0005zn-4K for bug-gnu-emacs@gnu.org; Fri, 31 May 2019 08:17:30 -0400 Original-Received: from mail.choca.pics ([2001:bc8:20ab::1]:43794) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hWgTQ-0005uN-U8 for bug-gnu-emacs@gnu.org; Fri, 31 May 2019 08:17:29 -0400 Original-Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 5CE43F1A3C7; Fri, 31 May 2019 14:17:18 +0200 (CEST) Original-Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10032) with ESMTP id Xo_4Vctmym8I; Fri, 31 May 2019 14:17:17 +0200 (CEST) Original-Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 54377F1A3C8; Fri, 31 May 2019 14:17:17 +0200 (CEST) X-Virus-Scanned: amavisd-new at choca.pics Original-Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10026) with ESMTP id yyibPGdnnmWq; Fri, 31 May 2019 14:17:17 +0200 (CEST) Original-Received: from luz4 (arennes-659-1-13-31.w86-215.abo.wanadoo.fr [86.215.172.31]) by mail.choca.pics (Postfix) with ESMTPSA id 06D0FF1A3C7; Fri, 31 May 2019 14:17:17 +0200 (CEST) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159964 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, it seems that oauth2 doesn't pass any type parameter when requesting authorization even though it seems to be required by the spec. See the patch for details. I'm no expert so please double-check. --=20 Damien Cassou F=C3=B6retagsplatsen AB Phone/Fax: +46 (0)8 774 63 00 Mobile: +33 (0)6 80 50 18 91 Address: Skeppsbron 26, 4tr, SE-111 30 Stockholm Web: www.foretagsplatsen.se --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-oauth2-to-pass-a-type-parameter-when-requesting-.patch >From a0d2132e5b3c8a47c4d2a2ec9d4233127ad0214c Mon Sep 17 00:00:00 2001 From: Damien Cassou Date: Fri, 31 May 2019 14:07:46 +0200 Subject: [PATCH] Fix oauth2 to pass a type parameter when requesting authorization * oauth2.el (oauth2-request-authorization): Add a "type=user_agent" parameter to the URL as it seems to be required by the protocol: https://tools.ietf.org/html/draft-ietf-oauth-v2-05#section-3.5.1 --- oauth2.el | 1 + 1 file changed, 1 insertion(+) diff --git a/oauth2.el b/oauth2.el index c8807f3..f6438ba 100644 --- a/oauth2.el +++ b/oauth2.el @@ -48,6 +48,7 @@ (defun oauth2-request-authorization (auth-url client-id &optional scope state re (if (string-match-p "\?" auth-url) "&" "?") "client_id=" (url-hexify-string client-id) "&response_type=code" + "&type=user_agent" "&redirect_uri=" (url-hexify-string (or redirect-uri "urn:ietf:wg:oauth:2.0:oob")) (if scope (concat "&scope=" (url-hexify-string scope)) "") (if state (concat "&state=" (url-hexify-string state)) ""))) -- 2.21.0 --=-=-=--